]> git.ipfire.org Git - thirdparty/gcc.git/commit
Make full use of context-sensitive ranges in access warnings.
authorMartin Sebor <msebor@redhat.com>
Tue, 26 Oct 2021 20:38:11 +0000 (14:38 -0600)
committerMartin Sebor <msebor@redhat.com>
Tue, 26 Oct 2021 22:53:23 +0000 (16:53 -0600)
commit9a27acc30a34b7854db32eac562306cebac6fa1e
tree50aec5b68739f53fc25c813f8ab5c029167141dd
parent88b504b7a8c5affb0ffa97990d22af2b199e36ed
Make full use of context-sensitive ranges in access warnings.

gcc/ChangeLog:

* builtins.c (check_strncat_sizes): Pass access_data ctor additional
arguments.
(expand_builtin_memcmp): Move code to gimple-ssa-warn-access.cc.
(expand_builtin_fork_or_exec): Same.
* gimple-array-bounds.cc (array_bounds_checker::check_mem_ref): Pass
compute_objsize additional arguments.
(inbounds_memaccess_p): Same.
(array_bounds_checker::check_array_bounds): Add an assert.  Stash
statement in a member.
(check_array_bounds_dom_walker::before_dom_children): Same.
* gimple-array-bounds.h (array_bounds_checker::m_stmt): New member.
* gimple-ssa-sprintf.c (get_destination_size): Add an argument.
(handle_printf_call): Pass a new argument.
* gimple-ssa-warn-access.cc (get_size_range): Add an argument.
(check_access): Add an argument and pass it along to callees.
(check_read_access): Make a member function.
(pass_waccess::check_strcat): Pass access_data ctor additional
arguments.
(pass_waccess::check_strncat): Same.
(pass_waccess::check_stxcpy): Same.
(pass_waccess::check_stxncpy): Same.
(pass_waccess::check_strncmp): Same.
(pass_waccess::check_read_access): Same.
(pass_waccess::check_builtin): Same.
(pass_waccess::maybe_check_access_sizes): Same.
(pass_waccess::maybe_check_dealloc_call): Same.
* gimple-ssa-warn-access.h (check_read_access): Declare a new
member function.
* pointer-query.cc (compute_objsize_r): Add an argument.
(gimple_call_return_array): Same.
(gimple_call_alloc_size): Same.
(access_ref::access_ref): Same.
(access_ref::get_ref): Same.
(pointer_query::get_ref): Same.
(handle_min_max_size): Pass an arguments to callees.
(handle_array_ref): Add an argument.
(handle_mem_ref): Same.
(compute_objsize): Same.
* pointer-query.h (struct access_ref): Adjust signatures.
(struct access_data): Same.
(gimple_call_alloc_size): Add an argument.
(gimple_parm_array_size): Same.
(compute_objsize): Same.
* tree-ssa-strlen.c (strlen_pass::adjust_last_stmt): Pass an additional
argument to compute_objsize.
(strlen_pass::maybe_warn_overflow): Same.
(maybe_diag_stxncpy_trunc): Same.

gcc/testsuite/ChangeLog:

* gcc.dg/Wstringop-overflow-22.c: Correct typos.
* gcc.dg/Wstringop-overflow-81.c: New test.

libstdc++-v3/ChangeLog:

* testsuite/21_strings/basic_string/capacity/1.cc: Also suppress
-Wstringop-overread.
* testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc: Same.
13 files changed:
gcc/builtins.c
gcc/gimple-array-bounds.cc
gcc/gimple-array-bounds.h
gcc/gimple-ssa-sprintf.c
gcc/gimple-ssa-warn-access.cc
gcc/gimple-ssa-warn-access.h
gcc/pointer-query.cc
gcc/pointer-query.h
gcc/testsuite/gcc.dg/Wstringop-overflow-22.c
gcc/testsuite/gcc.dg/Wstringop-overflow-81.c [new file with mode: 0644]
gcc/tree-ssa-strlen.c
libstdc++-v3/testsuite/21_strings/basic_string/capacity/1.cc
libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc