]> git.ipfire.org Git - thirdparty/gcc.git/commit
reassoc: Don't call fold_convert if !fold_convertible_p [PR105374]
authorJakub Jelinek <jakub@redhat.com>
Tue, 26 Apr 2022 07:57:34 +0000 (09:57 +0200)
committerJakub Jelinek <jakub@redhat.com>
Tue, 26 Apr 2022 07:57:34 +0000 (09:57 +0200)
commitd4836ac9acd0c991a4fe1dec9438773a2c4eb5ac
tree4c74da4417607abbd05b8ce961f90f27e7cfb440
parent1b45ae16fffc856b5d84aeea12040dd82452cd07
reassoc: Don't call fold_convert if !fold_convertible_p [PR105374]

As mentioned in the PR, we ICE because maybe_fold_*_comparisons returns
an expression with V4SImode type and we try to fold_convert it to
V4BImode, which isn't allowed.

IMHO no matter whether we change maybe_fold_*_comparisons we should
play safe on the reassoc side and punt if we can't convert like
we punt for many other reasons.  This fixes the testcase on ARM.

Testcase not included, not exactly sure where and what directives it
should have in gcc.target/arm/ testsuite.  Christophe, do you think you
could handle that incrementally?

2022-04-26  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/105374
* tree-ssa-reassoc.cc (eliminate_redundant_comparison): Punt if
!fold_convertible_p rather than assuming fold_convert must succeed.
gcc/tree-ssa-reassoc.cc