From 3609f65491f3240e69d634262d1158c9d27048be Mon Sep 17 00:00:00 2001 From: jason Date: Fri, 14 Jun 2019 13:22:33 +0000 Subject: [PATCH] PR c++/85552 - wrong instantiation of dtor for DMI. The problem here is that when processing direct-initialization of a data member, we don't need to worry about destruction semantics; that will be handled in the [cd]tor. Conveniently, we already have tf_no_cleanup from a similar fix to new-expressions. * typeck2.c (digest_nsdmi_init): Set tf_no_cleanup for direct-init. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@272287 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/cp/ChangeLog | 5 ++++ gcc/cp/typeck2.c | 5 +++- gcc/testsuite/g++.dg/cpp0x/nsdmi-list5.C | 30 ++++++++++++++++++++++++ 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/cpp0x/nsdmi-list5.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index c6823b57aa7b..62e541736ecf 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,8 @@ +2019-06-12 Jason Merrill + + PR c++/85552 - wrong instantiation of dtor for DMI. + * typeck2.c (digest_nsdmi_init): Set tf_no_cleanup for direct-init. + 2019-06-13 Paolo Carlini * decl.c (grokdeclarator): Use id_loc in five additional places diff --git a/gcc/cp/typeck2.c b/gcc/cp/typeck2.c index 0109d6e52f56..e8627dd38c00 100644 --- a/gcc/cp/typeck2.c +++ b/gcc/cp/typeck2.c @@ -1309,7 +1309,10 @@ digest_nsdmi_init (tree decl, tree init, tsubst_flags_t complain) tree type = TREE_TYPE (decl); int flags = LOOKUP_IMPLICIT; if (DIRECT_LIST_INIT_P (init)) - flags = LOOKUP_NORMAL; + { + flags = LOOKUP_NORMAL; + complain |= tf_no_cleanup; + } if (BRACE_ENCLOSED_INITIALIZER_P (init) && CP_AGGREGATE_TYPE_P (type)) init = reshape_init (type, init, complain); diff --git a/gcc/testsuite/g++.dg/cpp0x/nsdmi-list5.C b/gcc/testsuite/g++.dg/cpp0x/nsdmi-list5.C new file mode 100644 index 000000000000..a12740b23b04 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/nsdmi-list5.C @@ -0,0 +1,30 @@ +// PR c++/85552 +// { dg-do compile { target c++11 } } + +template +struct uptr { + uptr() { } + uptr(void*) { } + ~uptr() { static_assert(sizeof(T), "complete type"); } +}; + +class S; + +class Compiles +{ + uptr s; +}; + +class DoesntCompile +{ + ~DoesntCompile(); + DoesntCompile(); + + uptr s1 { }; + uptr s2 { nullptr }; +}; + +int main() +{ + return 0; +} -- 2.39.2