]> git.ipfire.org Git - thirdparty/git.git/blame - fsck.c
fsck: warn about '.' and '..' in trees
[thirdparty/git.git] / fsck.c
CommitLineData
355885d5
MK
1#include "cache.h"
2#include "object.h"
3#include "blob.h"
4#include "tree.h"
5#include "tree-walk.h"
6#include "commit.h"
7#include "tag.h"
8#include "fsck.h"
9
10static int fsck_walk_tree(struct tree *tree, fsck_walk_func walk, void *data)
11{
12 struct tree_desc desc;
13 struct name_entry entry;
14 int res = 0;
15
16 if (parse_tree(tree))
17 return -1;
18
19 init_tree_desc(&desc, tree->buffer, tree->size);
20 while (tree_entry(&desc, &entry)) {
21 int result;
22
23 if (S_ISGITLINK(entry.mode))
24 continue;
25 if (S_ISDIR(entry.mode))
26 result = walk(&lookup_tree(entry.sha1)->object, OBJ_TREE, data);
27 else if (S_ISREG(entry.mode) || S_ISLNK(entry.mode))
28 result = walk(&lookup_blob(entry.sha1)->object, OBJ_BLOB, data);
29 else {
82247e9b 30 result = error("in tree %s: entry %s has bad mode %.6o",
355885d5
MK
31 sha1_to_hex(tree->object.sha1), entry.path, entry.mode);
32 }
33 if (result < 0)
34 return result;
35 if (!res)
36 res = result;
37 }
38 return res;
39}
40
41static int fsck_walk_commit(struct commit *commit, fsck_walk_func walk, void *data)
42{
43 struct commit_list *parents;
44 int res;
45 int result;
46
47 if (parse_commit(commit))
48 return -1;
49
50 result = walk((struct object *)commit->tree, OBJ_TREE, data);
51 if (result < 0)
52 return result;
53 res = result;
54
55 parents = commit->parents;
56 while (parents) {
57 result = walk((struct object *)parents->item, OBJ_COMMIT, data);
58 if (result < 0)
59 return result;
60 if (!res)
61 res = result;
62 parents = parents->next;
63 }
64 return res;
65}
66
67static int fsck_walk_tag(struct tag *tag, fsck_walk_func walk, void *data)
68{
69 if (parse_tag(tag))
70 return -1;
71 return walk(tag->tagged, OBJ_ANY, data);
72}
73
74int fsck_walk(struct object *obj, fsck_walk_func walk, void *data)
75{
76 if (!obj)
77 return -1;
78 switch (obj->type) {
79 case OBJ_BLOB:
80 return 0;
81 case OBJ_TREE:
82 return fsck_walk_tree((struct tree *)obj, walk, data);
83 case OBJ_COMMIT:
84 return fsck_walk_commit((struct commit *)obj, walk, data);
85 case OBJ_TAG:
86 return fsck_walk_tag((struct tag *)obj, walk, data);
87 default:
88 error("Unknown object type for %s", sha1_to_hex(obj->sha1));
89 return -1;
90 }
91}
ba002f3b
MK
92
93/*
94 * The entries in a tree are ordered in the _path_ order,
95 * which means that a directory entry is ordered by adding
96 * a slash to the end of it.
97 *
98 * So a directory called "a" is ordered _after_ a file
99 * called "a.c", because "a/" sorts after "a.c".
100 */
101#define TREE_UNORDERED (-1)
102#define TREE_HAS_DUPS (-2)
103
104static int verify_ordered(unsigned mode1, const char *name1, unsigned mode2, const char *name2)
105{
106 int len1 = strlen(name1);
107 int len2 = strlen(name2);
108 int len = len1 < len2 ? len1 : len2;
109 unsigned char c1, c2;
110 int cmp;
111
112 cmp = memcmp(name1, name2, len);
113 if (cmp < 0)
114 return 0;
115 if (cmp > 0)
116 return TREE_UNORDERED;
117
118 /*
119 * Ok, the first <len> characters are the same.
120 * Now we need to order the next one, but turn
121 * a '\0' into a '/' for a directory entry.
122 */
123 c1 = name1[len];
124 c2 = name2[len];
125 if (!c1 && !c2)
126 /*
127 * git-write-tree used to write out a nonsense tree that has
128 * entries with the same name, one blob and one tree. Make
129 * sure we do not have duplicate entries.
130 */
131 return TREE_HAS_DUPS;
132 if (!c1 && S_ISDIR(mode1))
133 c1 = '/';
134 if (!c2 && S_ISDIR(mode2))
135 c2 = '/';
136 return c1 < c2 ? 0 : TREE_UNORDERED;
137}
138
139static int fsck_tree(struct tree *item, int strict, fsck_error error_func)
140{
141 int retval;
c479d14a 142 int has_null_sha1 = 0;
ba002f3b
MK
143 int has_full_path = 0;
144 int has_empty_name = 0;
5d34a435
JK
145 int has_dot = 0;
146 int has_dotdot = 0;
ba002f3b
MK
147 int has_zero_pad = 0;
148 int has_bad_modes = 0;
149 int has_dup_entries = 0;
150 int not_properly_sorted = 0;
151 struct tree_desc desc;
152 unsigned o_mode;
153 const char *o_name;
ba002f3b
MK
154
155 init_tree_desc(&desc, item->buffer, item->size);
156
157 o_mode = 0;
158 o_name = NULL;
ba002f3b
MK
159
160 while (desc.size) {
161 unsigned mode;
162 const char *name;
c479d14a 163 const unsigned char *sha1;
ba002f3b 164
c479d14a 165 sha1 = tree_entry_extract(&desc, &name, &mode);
ba002f3b 166
c479d14a
JK
167 if (is_null_sha1(sha1))
168 has_null_sha1 = 1;
ba002f3b
MK
169 if (strchr(name, '/'))
170 has_full_path = 1;
171 if (!*name)
172 has_empty_name = 1;
5d34a435
JK
173 if (!strcmp(name, "."))
174 has_dot = 1;
175 if (!strcmp(name, ".."))
176 has_dotdot = 1;
ba002f3b
MK
177 has_zero_pad |= *(char *)desc.buffer == '0';
178 update_tree_entry(&desc);
179
180 switch (mode) {
181 /*
182 * Standard modes..
183 */
184 case S_IFREG | 0755:
185 case S_IFREG | 0644:
186 case S_IFLNK:
187 case S_IFDIR:
188 case S_IFGITLINK:
189 break;
190 /*
191 * This is nonstandard, but we had a few of these
192 * early on when we honored the full set of mode
193 * bits..
194 */
195 case S_IFREG | 0664:
196 if (!strict)
197 break;
198 default:
199 has_bad_modes = 1;
200 }
201
202 if (o_name) {
203 switch (verify_ordered(o_mode, o_name, mode, name)) {
204 case TREE_UNORDERED:
205 not_properly_sorted = 1;
206 break;
207 case TREE_HAS_DUPS:
208 has_dup_entries = 1;
209 break;
210 default:
211 break;
212 }
213 }
214
215 o_mode = mode;
216 o_name = name;
ba002f3b
MK
217 }
218
219 retval = 0;
c479d14a
JK
220 if (has_null_sha1)
221 retval += error_func(&item->object, FSCK_WARN, "contains entries pointing to null sha1");
ba002f3b
MK
222 if (has_full_path)
223 retval += error_func(&item->object, FSCK_WARN, "contains full pathnames");
224 if (has_empty_name)
225 retval += error_func(&item->object, FSCK_WARN, "contains empty pathname");
5d34a435
JK
226 if (has_dot)
227 retval += error_func(&item->object, FSCK_WARN, "contains '.'");
228 if (has_dotdot)
229 retval += error_func(&item->object, FSCK_WARN, "contains '..'");
ba002f3b
MK
230 if (has_zero_pad)
231 retval += error_func(&item->object, FSCK_WARN, "contains zero-padded file modes");
232 if (has_bad_modes)
233 retval += error_func(&item->object, FSCK_WARN, "contains bad file modes");
234 if (has_dup_entries)
235 retval += error_func(&item->object, FSCK_ERROR, "contains duplicate file entries");
236 if (not_properly_sorted)
237 retval += error_func(&item->object, FSCK_ERROR, "not properly sorted");
238 return retval;
239}
240
daae1922
JN
241static int fsck_ident(char **ident, struct object *obj, fsck_error error_func)
242{
53f53cff 243 if (**ident == '<')
daae1922 244 return error_func(obj, FSCK_ERROR, "invalid author/committer line - missing space before email");
53f53cff
DI
245 *ident += strcspn(*ident, "<>\n");
246 if (**ident == '>')
247 return error_func(obj, FSCK_ERROR, "invalid author/committer line - bad name");
daae1922
JN
248 if (**ident != '<')
249 return error_func(obj, FSCK_ERROR, "invalid author/committer line - missing email");
53f53cff
DI
250 if ((*ident)[-1] != ' ')
251 return error_func(obj, FSCK_ERROR, "invalid author/committer line - missing space before email");
daae1922
JN
252 (*ident)++;
253 *ident += strcspn(*ident, "<>\n");
254 if (**ident != '>')
255 return error_func(obj, FSCK_ERROR, "invalid author/committer line - bad email");
256 (*ident)++;
257 if (**ident != ' ')
258 return error_func(obj, FSCK_ERROR, "invalid author/committer line - missing space before date");
259 (*ident)++;
260 if (**ident == '0' && (*ident)[1] != ' ')
261 return error_func(obj, FSCK_ERROR, "invalid author/committer line - zero-padded date");
262 *ident += strspn(*ident, "0123456789");
263 if (**ident != ' ')
264 return error_func(obj, FSCK_ERROR, "invalid author/committer line - bad date");
265 (*ident)++;
266 if ((**ident != '+' && **ident != '-') ||
267 !isdigit((*ident)[1]) ||
268 !isdigit((*ident)[2]) ||
269 !isdigit((*ident)[3]) ||
270 !isdigit((*ident)[4]) ||
271 ((*ident)[5] != '\n'))
272 return error_func(obj, FSCK_ERROR, "invalid author/committer line - bad time zone");
273 (*ident) += 6;
274 return 0;
275}
276
ba002f3b
MK
277static int fsck_commit(struct commit *commit, fsck_error error_func)
278{
279 char *buffer = commit->buffer;
280 unsigned char tree_sha1[20], sha1[20];
281 struct commit_graft *graft;
282 int parents = 0;
daae1922 283 int err;
ba002f3b 284
f2909743 285 if (commit->date == ULONG_MAX)
ba002f3b
MK
286 return error_func(&commit->object, FSCK_ERROR, "invalid author/committer line");
287
288 if (memcmp(buffer, "tree ", 5))
289 return error_func(&commit->object, FSCK_ERROR, "invalid format - expected 'tree' line");
290 if (get_sha1_hex(buffer+5, tree_sha1) || buffer[45] != '\n')
291 return error_func(&commit->object, FSCK_ERROR, "invalid 'tree' line format - bad sha1");
292 buffer += 46;
293 while (!memcmp(buffer, "parent ", 7)) {
294 if (get_sha1_hex(buffer+7, sha1) || buffer[47] != '\n')
295 return error_func(&commit->object, FSCK_ERROR, "invalid 'parent' line format - bad sha1");
296 buffer += 48;
297 parents++;
298 }
299 graft = lookup_commit_graft(commit->object.sha1);
300 if (graft) {
301 struct commit_list *p = commit->parents;
302 parents = 0;
303 while (p) {
304 p = p->next;
305 parents++;
306 }
307 if (graft->nr_parent == -1 && !parents)
308 ; /* shallow commit */
309 else if (graft->nr_parent != parents)
310 return error_func(&commit->object, FSCK_ERROR, "graft objects missing");
311 } else {
312 struct commit_list *p = commit->parents;
313 while (p && parents) {
314 p = p->next;
315 parents--;
316 }
317 if (p || parents)
318 return error_func(&commit->object, FSCK_ERROR, "parent objects missing");
319 }
320 if (memcmp(buffer, "author ", 7))
321 return error_func(&commit->object, FSCK_ERROR, "invalid format - expected 'author' line");
daae1922
JN
322 buffer += 7;
323 err = fsck_ident(&buffer, &commit->object, error_func);
324 if (err)
325 return err;
326 if (memcmp(buffer, "committer ", strlen("committer ")))
327 return error_func(&commit->object, FSCK_ERROR, "invalid format - expected 'committer' line");
328 buffer += strlen("committer ");
329 err = fsck_ident(&buffer, &commit->object, error_func);
330 if (err)
331 return err;
ba002f3b
MK
332 if (!commit->tree)
333 return error_func(&commit->object, FSCK_ERROR, "could not load commit's tree %s", sha1_to_hex(tree_sha1));
334
335 return 0;
336}
337
338static int fsck_tag(struct tag *tag, fsck_error error_func)
339{
340 struct object *tagged = tag->tagged;
341
342 if (!tagged)
343 return error_func(&tag->object, FSCK_ERROR, "could not load tagged object");
344 return 0;
345}
346
347int fsck_object(struct object *obj, int strict, fsck_error error_func)
348{
349 if (!obj)
350 return error_func(obj, FSCK_ERROR, "no valid object to fsck");
351
352 if (obj->type == OBJ_BLOB)
353 return 0;
354 if (obj->type == OBJ_TREE)
355 return fsck_tree((struct tree *) obj, strict, error_func);
356 if (obj->type == OBJ_COMMIT)
357 return fsck_commit((struct commit *) obj, error_func);
358 if (obj->type == OBJ_TAG)
359 return fsck_tag((struct tag *) obj, error_func);
360
361 return error_func(obj, FSCK_ERROR, "unknown type '%d' (internal fsck error)",
362 obj->type);
363}
d6ffc8d7
MK
364
365int fsck_error_function(struct object *obj, int type, const char *fmt, ...)
366{
367 va_list ap;
f285a2d7 368 struct strbuf sb = STRBUF_INIT;
d6ffc8d7 369
5dd56489 370 strbuf_addf(&sb, "object %s:", sha1_to_hex(obj->sha1));
d6ffc8d7
MK
371
372 va_start(ap, fmt);
ebeb6090 373 strbuf_vaddf(&sb, fmt, ap);
d6ffc8d7
MK
374 va_end(ap);
375
9db56f71 376 error("%s", sb.buf);
d6ffc8d7
MK
377 strbuf_release(&sb);
378 return 1;
379}