]> git.ipfire.org Git - thirdparty/git.git/blame - http-walker.c
Git 2.12
[thirdparty/git.git] / http-walker.c
CommitLineData
6eb7ed54
DB
1#include "cache.h"
2#include "commit.h"
30ae764b 3#include "walker.h"
29508e1e 4#include "http.h"
94e99012 5#include "list.h"
abcbdc03 6#include "transport.h"
7baa3e86 7
9cba13ca 8struct alt_base {
2afea3bc 9 char *base;
b3661567
DB
10 int got_indices;
11 struct packed_git *packs;
12 struct alt_base *next;
13};
14
e388ab74 15enum object_request_state {
1d389ab6
NH
16 WAITING,
17 ABORTED,
18 ACTIVE,
4b05548f 19 COMPLETE
1d389ab6 20};
6eb7ed54 21
9cba13ca 22struct object_request {
30ae764b 23 struct walker *walker;
1d389ab6
NH
24 unsigned char sha1[20];
25 struct alt_base *repo;
e388ab74 26 enum object_request_state state;
5424bc55 27 struct http_object_request *req;
94e99012 28 struct list_head node;
1d389ab6
NH
29};
30
e388ab74 31struct alternates_request {
30ae764b 32 struct walker *walker;
8e29f6a0 33 const char *base;
54ba4c5f 34 struct strbuf *url;
028c2976 35 struct strbuf *buffer;
acc075a8
NH
36 struct active_request_slot *slot;
37 int http_specific;
38};
39
30ae764b
DB
40struct walker_data {
41 const char *url;
42 int got_alternates;
43 struct alt_base *alt;
30ae764b
DB
44};
45
94e99012 46static LIST_HEAD(object_queue_head);
bc8f2652 47
30ae764b 48static void fetch_alternates(struct walker *walker, const char *base);
1d389ab6 49
29508e1e 50static void process_object_response(void *callback_data);
1d389ab6 51
30ae764b
DB
52static void start_object_request(struct walker *walker,
53 struct object_request *obj_req)
1d389ab6 54{
1d389ab6 55 struct active_request_slot *slot;
5424bc55 56 struct http_object_request *req;
1d389ab6 57
5424bc55
TRC
58 req = new_http_object_request(obj_req->repo->base, obj_req->sha1);
59 if (req == NULL) {
e388ab74 60 obj_req->state = ABORTED;
1d389ab6
NH
61 return;
62 }
5424bc55 63 obj_req->req = req;
1d389ab6 64
5424bc55 65 slot = req->slot;
29508e1e 66 slot->callback_func = process_object_response;
e388ab74 67 slot->callback_data = obj_req;
1d389ab6 68
a7a8d378 69 /* Try to get the request started, abort the request on error */
e388ab74 70 obj_req->state = ACTIVE;
1d389ab6 71 if (!start_active_slot(slot)) {
e388ab74 72 obj_req->state = ABORTED;
5424bc55 73 release_http_object_request(req);
e388ab74 74 return;
1d389ab6 75 }
1d389ab6
NH
76}
77
e388ab74 78static void finish_object_request(struct object_request *obj_req)
1d389ab6 79{
5424bc55 80 if (finish_http_object_request(obj_req->req))
1d389ab6 81 return;
1d389ab6 82
5424bc55 83 if (obj_req->req->rename == 0)
30ae764b 84 walker_say(obj_req->walker, "got %s\n", sha1_to_hex(obj_req->sha1));
1d389ab6
NH
85}
86
29508e1e
NH
87static void process_object_response(void *callback_data)
88{
e388ab74
NH
89 struct object_request *obj_req =
90 (struct object_request *)callback_data;
30ae764b
DB
91 struct walker *walker = obj_req->walker;
92 struct walker_data *data = walker->data;
93 struct alt_base *alt = data->alt;
29508e1e 94
5424bc55 95 process_http_object_request(obj_req->req);
e388ab74 96 obj_req->state = COMPLETE;
29508e1e
NH
97
98 /* Use alternates if necessary */
5424bc55 99 if (missing_target(obj_req->req)) {
30ae764b 100 fetch_alternates(walker, alt->base);
e388ab74
NH
101 if (obj_req->repo->next != NULL) {
102 obj_req->repo =
103 obj_req->repo->next;
5424bc55 104 release_http_object_request(obj_req->req);
30ae764b 105 start_object_request(walker, obj_req);
29508e1e
NH
106 return;
107 }
108 }
109
e388ab74 110 finish_object_request(obj_req);
29508e1e
NH
111}
112
e388ab74 113static void release_object_request(struct object_request *obj_req)
1d389ab6 114{
5424bc55
TRC
115 if (obj_req->req !=NULL && obj_req->req->localfile != -1)
116 error("fd leakage in release: %d", obj_req->req->localfile);
1d389ab6 117
94e99012 118 list_del(&obj_req->node);
e388ab74 119 free(obj_req);
1d389ab6
NH
120}
121
a7a8d378 122#ifdef USE_CURL_MULTI
30ae764b 123static int fill_active_slot(struct walker *walker)
1d389ab6 124{
45c17412 125 struct object_request *obj_req;
94e99012 126 struct list_head *pos, *tmp, *head = &object_queue_head;
1d389ab6 127
94e99012
EW
128 list_for_each_safe(pos, tmp, head) {
129 obj_req = list_entry(pos, struct object_request, node);
e388ab74
NH
130 if (obj_req->state == WAITING) {
131 if (has_sha1_file(obj_req->sha1))
09db444f 132 obj_req->state = COMPLETE;
45c17412 133 else {
30ae764b 134 start_object_request(walker, obj_req);
45c17412
DB
135 return 1;
136 }
f1a906a3 137 }
8fcf7f9a 138 }
45c17412 139 return 0;
1d389ab6 140}
a7a8d378 141#endif
1d389ab6 142
30ae764b 143static void prefetch(struct walker *walker, unsigned char *sha1)
1d389ab6 144{
e388ab74 145 struct object_request *newreq;
30ae764b 146 struct walker_data *data = walker->data;
1d389ab6
NH
147
148 newreq = xmalloc(sizeof(*newreq));
30ae764b 149 newreq->walker = walker;
e702496e 150 hashcpy(newreq->sha1, sha1);
30ae764b 151 newreq->repo = data->alt;
1d389ab6 152 newreq->state = WAITING;
5424bc55 153 newreq->req = NULL;
1d389ab6 154
e9176745 155 http_is_verbose = walker->get_verbosely;
94e99012 156 list_add_tail(&newreq->node, &object_queue_head);
29508e1e 157
a7a8d378 158#ifdef USE_CURL_MULTI
29508e1e
NH
159 fill_active_slots();
160 step_active_slots();
a7a8d378 161#endif
1d389ab6
NH
162}
163
abcbdc03
JK
164static int is_alternate_allowed(const char *url)
165{
166 const char *protocols[] = {
167 "http", "https", "ftp", "ftps"
168 };
169 int i;
170
171 for (i = 0; i < ARRAY_SIZE(protocols); i++) {
172 const char *end;
173 if (skip_prefix(url, protocols[i], &end) &&
174 starts_with(end, "://"))
175 break;
176 }
177
178 if (i >= ARRAY_SIZE(protocols)) {
179 warning("ignoring alternate with unknown protocol: %s", url);
180 return 0;
181 }
182 if (!is_transport_allowed(protocols[i], 0)) {
183 warning("ignoring alternate with restricted protocol: %s", url);
184 return 0;
185 }
186
187 return 1;
188}
189
e388ab74 190static void process_alternates_response(void *callback_data)
b3661567 191{
e388ab74
NH
192 struct alternates_request *alt_req =
193 (struct alternates_request *)callback_data;
30ae764b
DB
194 struct walker *walker = alt_req->walker;
195 struct walker_data *cdata = walker->data;
acc075a8 196 struct active_request_slot *slot = alt_req->slot;
30ae764b 197 struct alt_base *tail = cdata->alt;
8e29f6a0 198 const char *base = alt_req->base;
a04ff3ec 199 const char null_byte = '\0';
acc075a8
NH
200 char *data;
201 int i = 0;
1d389ab6 202
acc075a8
NH
203 if (alt_req->http_specific) {
204 if (slot->curl_result != CURLE_OK ||
028c2976 205 !alt_req->buffer->len) {
acc075a8
NH
206
207 /* Try reusing the slot to get non-http alternates */
208 alt_req->http_specific = 0;
54ba4c5f
JK
209 strbuf_reset(alt_req->url);
210 strbuf_addf(alt_req->url, "%s/objects/info/alternates",
211 base);
acc075a8 212 curl_easy_setopt(slot->curl, CURLOPT_URL,
54ba4c5f 213 alt_req->url->buf);
acc075a8
NH
214 active_requests++;
215 slot->in_use = 1;
c9826473
NH
216 if (slot->finished != NULL)
217 (*slot->finished) = 0;
a3f583cb 218 if (!start_active_slot(slot)) {
30ae764b 219 cdata->got_alternates = -1;
29508e1e 220 slot->in_use = 0;
c9826473
NH
221 if (slot->finished != NULL)
222 (*slot->finished) = 1;
1d389ab6 223 }
a3f583cb 224 return;
b3661567 225 }
acc075a8 226 } else if (slot->curl_result != CURLE_OK) {
be4a015b 227 if (!missing_target(slot)) {
30ae764b 228 cdata->got_alternates = -1;
acc075a8
NH
229 return;
230 }
b3661567
DB
231 }
232
a04ff3ec 233 fwrite_buffer((char *)&null_byte, 1, 1, alt_req->buffer);
028c2976
MH
234 alt_req->buffer->len--;
235 data = alt_req->buffer->buf;
1b0c1e67 236
028c2976 237 while (i < alt_req->buffer->len) {
b3661567 238 int posn = i;
028c2976 239 while (posn < alt_req->buffer->len && data[posn] != '\n')
b3661567
DB
240 posn++;
241 if (data[posn] == '\n') {
1b0c1e67
DB
242 int okay = 0;
243 int serverlen = 0;
244 struct alt_base *newalt;
b3661567 245 if (data[i] == '/') {
4c42aa1a
TRC
246 /*
247 * This counts
5df1e0d0
JH
248 * http://git.host/pub/scm/linux.git/
249 * -----------here^
250 * so memcpy(dst, base, serverlen) will
251 * copy up to "...git.host".
252 */
253 const char *colon_ss = strstr(base,"://");
254 if (colon_ss) {
255 serverlen = (strchr(colon_ss + 3, '/')
256 - base);
257 okay = 1;
258 }
1b0c1e67 259 } else if (!memcmp(data + i, "../", 3)) {
4c42aa1a
TRC
260 /*
261 * Relative URL; chop the corresponding
5df1e0d0
JH
262 * number of subpath from base (and ../
263 * from data), and concatenate the result.
264 *
265 * The code first drops ../ from data, and
266 * then drops one ../ from data and one path
267 * from base. IOW, one extra ../ is dropped
268 * from data than path is dropped from base.
269 *
270 * This is not wrong. The alternate in
271 * http://git.host/pub/scm/linux.git/
272 * to borrow from
273 * http://git.host/pub/scm/linus.git/
274 * is ../../linus.git/objects/. You need
275 * two ../../ to borrow from your direct
276 * neighbour.
277 */
1b0c1e67
DB
278 i += 3;
279 serverlen = strlen(base);
8fcf7f9a 280 while (i + 2 < posn &&
1b0c1e67
DB
281 !memcmp(data + i, "../", 3)) {
282 do {
283 serverlen--;
284 } while (serverlen &&
285 base[serverlen - 1] != '/');
286 i += 3;
287 }
a9486b02 288 /* If the server got removed, give up. */
8fcf7f9a 289 okay = strchr(base, ':') - base + 3 <
4c42aa1a 290 serverlen;
acc075a8 291 } else if (alt_req->http_specific) {
1b0c1e67
DB
292 char *colon = strchr(data + i, ':');
293 char *slash = strchr(data + i, '/');
294 if (colon && slash && colon < data + posn &&
295 slash < data + posn && colon < slash) {
296 okay = 1;
297 }
298 }
5df1e0d0 299 /* skip "objects\n" at end */
1b0c1e67 300 if (okay) {
59b8263a
RS
301 struct strbuf target = STRBUF_INIT;
302 strbuf_add(&target, base, serverlen);
303 strbuf_add(&target, data + i, posn - i - 7);
abcbdc03
JK
304
305 if (is_alternate_allowed(target.buf)) {
306 warning("adding alternate object store: %s",
307 target.buf);
308 newalt = xmalloc(sizeof(*newalt));
309 newalt->next = NULL;
310 newalt->base = strbuf_detach(&target, NULL);
311 newalt->got_indices = 0;
312 newalt->packs = NULL;
313
314 while (tail->next != NULL)
315 tail = tail->next;
316 tail->next = newalt;
317 }
b3661567
DB
318 }
319 }
320 i = posn + 1;
321 }
bc8f2652 322
30ae764b 323 cdata->got_alternates = 1;
acc075a8
NH
324}
325
30ae764b 326static void fetch_alternates(struct walker *walker, const char *base)
acc075a8 327{
028c2976 328 struct strbuf buffer = STRBUF_INIT;
54ba4c5f 329 struct strbuf url = STRBUF_INIT;
acc075a8 330 struct active_request_slot *slot;
cb754fdf 331 struct alternates_request alt_req;
30ae764b 332 struct walker_data *cdata = walker->data;
acc075a8 333
cb4d2d35
JK
334 if (http_follow_config != HTTP_FOLLOW_ALWAYS)
335 return;
336
4c42aa1a
TRC
337 /*
338 * If another request has already started fetching alternates,
339 * wait for them to arrive and return to processing this request's
340 * curl message
341 */
29508e1e 342#ifdef USE_CURL_MULTI
30ae764b 343 while (cdata->got_alternates == 0) {
29508e1e 344 step_active_slots();
acc075a8 345 }
29508e1e 346#endif
acc075a8
NH
347
348 /* Nothing to do if they've already been fetched */
30ae764b 349 if (cdata->got_alternates == 1)
acc075a8
NH
350 return;
351
352 /* Start the fetch */
30ae764b 353 cdata->got_alternates = 0;
acc075a8 354
30ae764b 355 if (walker->get_verbosely)
acc075a8 356 fprintf(stderr, "Getting alternates list for %s\n", base);
8fcf7f9a 357
54ba4c5f 358 strbuf_addf(&url, "%s/objects/info/http-alternates", base);
acc075a8 359
4c42aa1a
TRC
360 /*
361 * Use a callback to process the result, since another request
362 * may fail and need to have alternates loaded before continuing
363 */
acc075a8 364 slot = get_active_slot();
e388ab74 365 slot->callback_func = process_alternates_response;
30ae764b 366 alt_req.walker = walker;
acc075a8
NH
367 slot->callback_data = &alt_req;
368
369 curl_easy_setopt(slot->curl, CURLOPT_FILE, &buffer);
29508e1e 370 curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer);
54ba4c5f 371 curl_easy_setopt(slot->curl, CURLOPT_URL, url.buf);
acc075a8
NH
372
373 alt_req.base = base;
54ba4c5f 374 alt_req.url = &url;
acc075a8
NH
375 alt_req.buffer = &buffer;
376 alt_req.http_specific = 1;
377 alt_req.slot = slot;
378
379 if (start_active_slot(slot))
380 run_active_slot(slot);
381 else
30ae764b 382 cdata->got_alternates = -1;
acc075a8 383
028c2976 384 strbuf_release(&buffer);
54ba4c5f 385 strbuf_release(&url);
b3661567
DB
386}
387
30ae764b 388static int fetch_indices(struct walker *walker, struct alt_base *repo)
182005b9 389{
b8caac2b 390 int ret;
1d389ab6 391
b3661567 392 if (repo->got_indices)
182005b9
DB
393 return 0;
394
30ae764b 395 if (walker->get_verbosely)
6fd72e39 396 fprintf(stderr, "Getting pack list for %s\n", repo->base);
8fcf7f9a 397
b8caac2b
TRC
398 switch (http_get_info_packs(repo->base, &repo->packs)) {
399 case HTTP_OK:
400 case HTTP_MISSING_TARGET:
401 repo->got_indices = 1;
402 ret = 0;
403 break;
404 default:
5e3a7691 405 repo->got_indices = 0;
b8caac2b 406 ret = -1;
b3661567 407 }
182005b9 408
3a462bc9 409 return ret;
182005b9
DB
410}
411
07c19e72 412static int http_fetch_pack(struct walker *walker, struct alt_base *repo, unsigned char *sha1)
182005b9 413{
182005b9 414 struct packed_git *target;
49a0f240 415 int ret;
cb754fdf 416 struct slot_results results;
2264dfa5 417 struct http_pack_request *preq;
182005b9 418
30ae764b 419 if (fetch_indices(walker, repo))
182005b9 420 return -1;
b3661567 421 target = find_sha1_pack(sha1, repo->packs);
182005b9 422 if (!target)
b3661567 423 return -1;
182005b9 424
30ae764b 425 if (walker->get_verbosely) {
182005b9
DB
426 fprintf(stderr, "Getting pack %s\n",
427 sha1_to_hex(target->sha1));
428 fprintf(stderr, " which contains %s\n",
429 sha1_to_hex(sha1));
430 }
431
2264dfa5
TRC
432 preq = new_http_pack_request(target, repo->base);
433 if (preq == NULL)
434 goto abort;
435 preq->lst = &repo->packs;
436 preq->slot->results = &results;
182005b9 437
2264dfa5
TRC
438 if (start_active_slot(preq->slot)) {
439 run_active_slot(preq->slot);
c8568e13 440 if (results.curl_result != CURLE_OK) {
2264dfa5
TRC
441 error("Unable to get pack file %s\n%s", preq->url,
442 curl_errorstr);
443 goto abort;
1d389ab6
NH
444 }
445 } else {
2264dfa5
TRC
446 error("Unable to start request");
447 goto abort;
182005b9
DB
448 }
449
2264dfa5
TRC
450 ret = finish_http_pack_request(preq);
451 release_http_pack_request(preq);
49a0f240 452 if (ret)
b721e01f 453 return ret;
49a0f240 454
182005b9 455 return 0;
2264dfa5
TRC
456
457abort:
458 return -1;
182005b9
DB
459}
460
53f31389
MW
461static void abort_object_request(struct object_request *obj_req)
462{
53f31389
MW
463 release_object_request(obj_req);
464}
465
43b8bba6 466static int fetch_object(struct walker *walker, unsigned char *sha1)
6eb7ed54
DB
467{
468 char *hex = sha1_to_hex(sha1);
29508e1e 469 int ret = 0;
94e99012 470 struct object_request *obj_req = NULL;
5424bc55 471 struct http_object_request *req;
94e99012 472 struct list_head *pos, *head = &object_queue_head;
1d389ab6 473
94e99012
EW
474 list_for_each(pos, head) {
475 obj_req = list_entry(pos, struct object_request, node);
476 if (!hashcmp(obj_req->sha1, sha1))
477 break;
478 }
e388ab74 479 if (obj_req == NULL)
1d389ab6
NH
480 return error("Couldn't find request for %s in the queue", hex);
481
e388ab74 482 if (has_sha1_file(obj_req->sha1)) {
5424bc55
TRC
483 if (obj_req->req != NULL)
484 abort_http_object_request(obj_req->req);
53f31389 485 abort_object_request(obj_req);
11f0dafe
NH
486 return 0;
487 }
488
a7a8d378 489#ifdef USE_CURL_MULTI
4c42aa1a 490 while (obj_req->state == WAITING)
29508e1e 491 step_active_slots();
a7a8d378 492#else
30ae764b 493 start_object_request(walker, obj_req);
a7a8d378 494#endif
6eb7ed54 495
5424bc55
TRC
496 /*
497 * obj_req->req might change when fetching alternates in the callback
498 * process_object_response; therefore, the "shortcut" variable, req,
499 * is used only after we're done with slots.
500 */
4c42aa1a 501 while (obj_req->state == ACTIVE)
5424bc55
TRC
502 run_active_slot(obj_req->req->slot);
503
504 req = obj_req->req;
4c42aa1a 505
5424bc55
TRC
506 if (req->localfile != -1) {
507 close(req->localfile);
508 req->localfile = -1;
313c4714 509 }
6eb7ed54 510
17966c0a
EW
511 /*
512 * we turned off CURLOPT_FAILONERROR to avoid losing a
513 * persistent connection and got CURLE_OK.
514 */
3680f16f 515 if (req->http_code >= 300 && req->curl_result == CURLE_OK &&
17966c0a 516 (starts_with(req->url, "http://") ||
3680f16f 517 starts_with(req->url, "https://"))) {
17966c0a 518 req->curl_result = CURLE_HTTP_RETURNED_ERROR;
3680f16f
JK
519 xsnprintf(req->errorstr, sizeof(req->errorstr),
520 "HTTP request failed");
521 }
17966c0a 522
e388ab74 523 if (obj_req->state == ABORTED) {
29508e1e 524 ret = error("Request for %s aborted", hex);
5424bc55
TRC
525 } else if (req->curl_result != CURLE_OK &&
526 req->http_code != 416) {
527 if (missing_target(req))
e2029eb9
PB
528 ret = -1; /* Be silent, it is probably in a pack. */
529 else
530 ret = error("%s (curl_result = %d, http_code = %ld, sha1 = %s)",
5424bc55
TRC
531 req->errorstr, req->curl_result,
532 req->http_code, hex);
533 } else if (req->zret != Z_STREAM_END) {
30ae764b 534 walker->corrupt_object_found++;
5424bc55
TRC
535 ret = error("File %s (%s) corrupt", hex, req->url);
536 } else if (hashcmp(obj_req->sha1, req->real_sha1)) {
bd2afde8 537 ret = error("File %s has bad hash", hex);
5424bc55 538 } else if (req->rename < 0) {
7b934ec0 539 ret = error("unable to write sha1 filename %s",
0da8b2e7 540 sha1_file_name(req->sha1));
6eb7ed54 541 }
49a0f240 542
5424bc55 543 release_http_object_request(req);
e388ab74 544 release_object_request(obj_req);
29508e1e 545 return ret;
6eb7ed54
DB
546}
547
30ae764b 548static int fetch(struct walker *walker, unsigned char *sha1)
b3661567 549{
30ae764b
DB
550 struct walker_data *data = walker->data;
551 struct alt_base *altbase = data->alt;
1d389ab6 552
43b8bba6 553 if (!fetch_object(walker, sha1))
1d389ab6 554 return 0;
b3661567 555 while (altbase) {
07c19e72 556 if (!http_fetch_pack(walker, altbase, sha1))
b3661567 557 return 0;
30ae764b 558 fetch_alternates(walker, data->alt->base);
b3661567
DB
559 altbase = altbase->next;
560 }
bd2afde8 561 return error("Unable to find %s under %s", sha1_to_hex(sha1),
30ae764b 562 data->alt->base);
b3661567
DB
563}
564
c13b2633 565static int fetch_ref(struct walker *walker, struct ref *ref)
cd541a68 566{
30ae764b 567 struct walker_data *data = walker->data;
c13b2633 568 return http_fetch_ref(data->alt->base, ref);
cd541a68
DB
569}
570
30ae764b
DB
571static void cleanup(struct walker *walker)
572{
09ae9aca
TRC
573 struct walker_data *data = walker->data;
574 struct alt_base *alt, *alt_next;
575
576 if (data) {
577 alt = data->alt;
578 while (alt) {
579 alt_next = alt->next;
580
581 free(alt->base);
582 free(alt);
583
584 alt = alt_next;
585 }
586 free(data);
587 walker->data = NULL;
588 }
30ae764b
DB
589}
590
888692b7 591struct walker *get_http_walker(const char *url)
6eb7ed54 592{
9c880b3e 593 char *s;
30ae764b
DB
594 struct walker_data *data = xmalloc(sizeof(struct walker_data));
595 struct walker *walker = xmalloc(sizeof(struct walker));
6eb7ed54 596
30ae764b 597 data->alt = xmalloc(sizeof(*data->alt));
95244ae3 598 data->alt->base = xstrdup(url);
30ae764b 599 for (s = data->alt->base + strlen(data->alt->base) - 1; *s == '/'; --s)
9c880b3e 600 *s = 0;
6eb7ed54 601
30ae764b
DB
602 data->alt->got_indices = 0;
603 data->alt->packs = NULL;
604 data->alt->next = NULL;
605 data->got_alternates = -1;
fc57b6aa 606
30ae764b
DB
607 walker->corrupt_object_found = 0;
608 walker->fetch = fetch;
609 walker->fetch_ref = fetch_ref;
610 walker->prefetch = prefetch;
611 walker->cleanup = cleanup;
612 walker->data = data;
6eb7ed54 613
30ae764b
DB
614#ifdef USE_CURL_MULTI
615 add_fill_function(walker, (int (*)(void *)) fill_active_slot);
616#endif
8e29f6a0 617
30ae764b 618 return walker;
6eb7ed54 619}