]> git.ipfire.org Git - thirdparty/git.git/blame - t/t1404-update-ref-errors.sh
The third batch
[thirdparty/git.git] / t / t1404-update-ref-errors.sh
CommitLineData
433efcad
MH
1#!/bin/sh
2
bf0c6603 3test_description='Test git update-ref error handling'
03267e86
ÆAB
4
5TEST_PASSES_SANITIZE_LEAK=true
433efcad
MH
6. ./test-lib.sh
7
017f7221
MH
8# Create some references, perhaps run pack-refs --all, then try to
9# create some more references. Ensure that the second creation fails
10# with the correct error message.
11# Usage: test_update_rejected <before> <pack> <create> <error>
12# <before> is a ws-separated list of refs to create before the test
13# <pack> (true or false) tells whether to pack the refs before the test
14# <create> is a list of variables to attempt creating
15# <error> is a string to look for in the stderr of update-ref.
16# All references are created in the namespace specified by the current
17# value of $prefix.
433efcad 18test_update_rejected () {
0e4b63b5
MH
19 before="$1" &&
20 pack="$2" &&
21 create="$3" &&
22 error="$4" &&
433efcad
MH
23 printf "create $prefix/%s $C\n" $before |
24 git update-ref --stdin &&
25 git for-each-ref $prefix >unchanged &&
26 if $pack
27 then
28 git pack-refs --all
29 fi &&
30 printf "create $prefix/%s $C\n" $create >input &&
31 test_must_fail git update-ref --stdin <input 2>output.err &&
6789275d 32 test_grep -F "$error" output.err &&
433efcad
MH
33 git for-each-ref $prefix >actual &&
34 test_cmp unchanged actual
35}
36
2e9de01a
MH
37# Test adding and deleting D/F-conflicting references in a single
38# transaction.
39df_test() {
40 prefix="$1"
41 pack=: symadd=false symdel=false add_del=false addref= delref=
42 shift
43 while test $# -gt 0
44 do
45 case "$1" in
46 --pack)
47 pack="git pack-refs --all"
48 shift
49 ;;
50 --sym-add)
51 # Perform the add via a symbolic reference
52 symadd=true
53 shift
54 ;;
55 --sym-del)
56 # Perform the del via a symbolic reference
57 symdel=true
58 shift
59 ;;
60 --del-add)
61 # Delete first reference then add second
62 add_del=false
63 delref="$prefix/r/$2"
64 addref="$prefix/r/$3"
65 shift 3
66 ;;
67 --add-del)
68 # Add first reference then delete second
69 add_del=true
70 addref="$prefix/r/$2"
71 delref="$prefix/r/$3"
72 shift 3
73 ;;
74 *)
75 echo 1>&2 "Extra args to df_test: $*"
76 return 1
77 ;;
78 esac
79 done
80 git update-ref "$delref" $C &&
81 if $symadd
82 then
83 addname="$prefix/s/symadd" &&
84 git symbolic-ref "$addname" "$addref"
85 else
86 addname="$addref"
87 fi &&
88 if $symdel
89 then
90 delname="$prefix/s/symdel" &&
91 git symbolic-ref "$delname" "$delref"
92 else
93 delname="$delref"
94 fi &&
2e9de01a
MH
95 $pack &&
96 if $add_del
97 then
98 printf "%s\n" "create $addname $D" "delete $delname"
99 else
100 printf "%s\n" "delete $delname" "create $addname $D"
101 fi >commands &&
102 test_must_fail git update-ref --stdin <commands 2>output.err &&
3f87bb2c 103 grep "fatal:\( cannot lock ref $SQ$addname$SQ:\)\? $SQ$delref$SQ exists; cannot create $SQ$addref$SQ" output.err &&
2e9de01a
MH
104 printf "%s\n" "$C $delref" >expected-refs &&
105 git for-each-ref --format="%(objectname) %(refname)" $prefix/r >actual-refs &&
106 test_cmp expected-refs actual-refs
107}
108
433efcad
MH
109test_expect_success 'setup' '
110
111 git commit --allow-empty -m Initial &&
19dd7d06
MH
112 C=$(git rev-parse HEAD) &&
113 git commit --allow-empty -m Second &&
c5119dcf
MH
114 D=$(git rev-parse HEAD) &&
115 git commit --allow-empty -m Third &&
116 E=$(git rev-parse HEAD)
433efcad
MH
117'
118
119test_expect_success 'existing loose ref is a simple prefix of new' '
120
121 prefix=refs/1l &&
0e4b63b5 122 test_update_rejected "a c e" false "b c/x d" \
bd482d6e 123 "$SQ$prefix/c$SQ exists; cannot create $SQ$prefix/c/x$SQ"
433efcad
MH
124
125'
126
127test_expect_success 'existing packed ref is a simple prefix of new' '
128
129 prefix=refs/1p &&
0e4b63b5 130 test_update_rejected "a c e" true "b c/x d" \
bd482d6e 131 "$SQ$prefix/c$SQ exists; cannot create $SQ$prefix/c/x$SQ"
433efcad
MH
132
133'
134
135test_expect_success 'existing loose ref is a deeper prefix of new' '
136
137 prefix=refs/2l &&
0e4b63b5 138 test_update_rejected "a c e" false "b c/x/y d" \
bd482d6e 139 "$SQ$prefix/c$SQ exists; cannot create $SQ$prefix/c/x/y$SQ"
433efcad
MH
140
141'
142
143test_expect_success 'existing packed ref is a deeper prefix of new' '
144
145 prefix=refs/2p &&
0e4b63b5 146 test_update_rejected "a c e" true "b c/x/y d" \
bd482d6e 147 "$SQ$prefix/c$SQ exists; cannot create $SQ$prefix/c/x/y$SQ"
433efcad
MH
148
149'
150
151test_expect_success 'new ref is a simple prefix of existing loose' '
152
153 prefix=refs/3l &&
0e4b63b5 154 test_update_rejected "a c/x e" false "b c d" \
bd482d6e 155 "$SQ$prefix/c/x$SQ exists; cannot create $SQ$prefix/c$SQ"
433efcad
MH
156
157'
158
159test_expect_success 'new ref is a simple prefix of existing packed' '
160
161 prefix=refs/3p &&
0e4b63b5 162 test_update_rejected "a c/x e" true "b c d" \
bd482d6e 163 "$SQ$prefix/c/x$SQ exists; cannot create $SQ$prefix/c$SQ"
433efcad
MH
164
165'
166
167test_expect_success 'new ref is a deeper prefix of existing loose' '
168
169 prefix=refs/4l &&
0e4b63b5 170 test_update_rejected "a c/x/y e" false "b c d" \
bd482d6e 171 "$SQ$prefix/c/x/y$SQ exists; cannot create $SQ$prefix/c$SQ"
433efcad
MH
172
173'
174
175test_expect_success 'new ref is a deeper prefix of existing packed' '
176
177 prefix=refs/4p &&
0e4b63b5 178 test_update_rejected "a c/x/y e" true "b c d" \
bd482d6e 179 "$SQ$prefix/c/x/y$SQ exists; cannot create $SQ$prefix/c$SQ"
433efcad
MH
180
181'
182
e911104c 183test_expect_success 'one new ref is a simple prefix of another' '
433efcad
MH
184
185 prefix=refs/5 &&
0e4b63b5 186 test_update_rejected "a e" false "b c c/x d" \
bd482d6e 187 "cannot process $SQ$prefix/c$SQ and $SQ$prefix/c/x$SQ at the same time"
433efcad
MH
188
189'
190
3f87bb2c 191test_expect_success 'D/F conflict prevents add long + delete short' '
2e9de01a
MH
192 df_test refs/df-al-ds --add-del foo/bar foo
193'
194
3f87bb2c 195test_expect_success 'D/F conflict prevents add short + delete long' '
2e9de01a
MH
196 df_test refs/df-as-dl --add-del foo foo/bar
197'
198
3f87bb2c 199test_expect_success 'D/F conflict prevents delete long + add short' '
2e9de01a
MH
200 df_test refs/df-dl-as --del-add foo/bar foo
201'
202
3f87bb2c 203test_expect_success 'D/F conflict prevents delete short + add long' '
2e9de01a
MH
204 df_test refs/df-ds-al --del-add foo foo/bar
205'
206
3f87bb2c 207test_expect_success 'D/F conflict prevents add long + delete short packed' '
2e9de01a
MH
208 df_test refs/df-al-dsp --pack --add-del foo/bar foo
209'
210
3f87bb2c 211test_expect_success 'D/F conflict prevents add short + delete long packed' '
2e9de01a
MH
212 df_test refs/df-as-dlp --pack --add-del foo foo/bar
213'
214
3f87bb2c 215test_expect_success 'D/F conflict prevents delete long packed + add short' '
2e9de01a
MH
216 df_test refs/df-dlp-as --pack --del-add foo/bar foo
217'
218
3f87bb2c 219test_expect_success 'D/F conflict prevents delete short packed + add long' '
2e9de01a
MH
220 df_test refs/df-dsp-al --pack --del-add foo foo/bar
221'
222
223# Try some combinations involving symbolic refs...
224
3f87bb2c 225test_expect_success 'D/F conflict prevents indirect add long + delete short' '
2e9de01a
MH
226 df_test refs/df-ial-ds --sym-add --add-del foo/bar foo
227'
228
3f87bb2c 229test_expect_success 'D/F conflict prevents indirect add long + indirect delete short' '
2e9de01a
MH
230 df_test refs/df-ial-ids --sym-add --sym-del --add-del foo/bar foo
231'
232
3f87bb2c 233test_expect_success 'D/F conflict prevents indirect add short + indirect delete long' '
2e9de01a
MH
234 df_test refs/df-ias-idl --sym-add --sym-del --add-del foo foo/bar
235'
236
3f87bb2c 237test_expect_success 'D/F conflict prevents indirect delete long + indirect add short' '
2e9de01a
MH
238 df_test refs/df-idl-ias --sym-add --sym-del --del-add foo/bar foo
239'
240
3f87bb2c 241test_expect_success 'D/F conflict prevents indirect add long + delete short packed' '
2e9de01a
MH
242 df_test refs/df-ial-dsp --sym-add --pack --add-del foo/bar foo
243'
244
3f87bb2c 245test_expect_success 'D/F conflict prevents indirect add long + indirect delete short packed' '
2e9de01a
MH
246 df_test refs/df-ial-idsp --sym-add --sym-del --pack --add-del foo/bar foo
247'
248
3f87bb2c 249test_expect_success 'D/F conflict prevents add long + indirect delete short packed' '
2e9de01a
MH
250 df_test refs/df-al-idsp --sym-del --pack --add-del foo/bar foo
251'
252
3f87bb2c 253test_expect_success 'D/F conflict prevents indirect delete long packed + indirect add short' '
2e9de01a
MH
254 df_test refs/df-idlp-ias --sym-add --sym-del --pack --del-add foo/bar foo
255'
256
c5119dcf
MH
257# Test various errors when reading the old values of references...
258
259test_expect_success 'missing old value blocks update' '
260 prefix=refs/missing-update &&
261 cat >expected <<-EOF &&
bd482d6e 262 fatal: cannot lock ref $SQ$prefix/foo$SQ: unable to resolve reference $SQ$prefix/foo$SQ
c5119dcf
MH
263 EOF
264 printf "%s\n" "update $prefix/foo $E $D" |
265 test_must_fail git update-ref --stdin 2>output.err &&
266 test_cmp expected output.err
267'
268
269test_expect_success 'incorrect old value blocks update' '
270 prefix=refs/incorrect-update &&
271 git update-ref $prefix/foo $C &&
272 cat >expected <<-EOF &&
bd482d6e 273 fatal: cannot lock ref $SQ$prefix/foo$SQ: is at $C but expected $D
c5119dcf
MH
274 EOF
275 printf "%s\n" "update $prefix/foo $E $D" |
276 test_must_fail git update-ref --stdin 2>output.err &&
277 test_cmp expected output.err
278'
279
280test_expect_success 'existing old value blocks create' '
281 prefix=refs/existing-create &&
282 git update-ref $prefix/foo $C &&
283 cat >expected <<-EOF &&
bd482d6e 284 fatal: cannot lock ref $SQ$prefix/foo$SQ: reference already exists
c5119dcf
MH
285 EOF
286 printf "%s\n" "create $prefix/foo $E" |
287 test_must_fail git update-ref --stdin 2>output.err &&
288 test_cmp expected output.err
289'
290
291test_expect_success 'incorrect old value blocks delete' '
292 prefix=refs/incorrect-delete &&
293 git update-ref $prefix/foo $C &&
294 cat >expected <<-EOF &&
bd482d6e 295 fatal: cannot lock ref $SQ$prefix/foo$SQ: is at $C but expected $D
c5119dcf
MH
296 EOF
297 printf "%s\n" "delete $prefix/foo $D" |
298 test_must_fail git update-ref --stdin 2>output.err &&
299 test_cmp expected output.err
300'
301
302test_expect_success 'missing old value blocks indirect update' '
303 prefix=refs/missing-indirect-update &&
304 git symbolic-ref $prefix/symref $prefix/foo &&
305 cat >expected <<-EOF &&
bd482d6e 306 fatal: cannot lock ref $SQ$prefix/symref$SQ: unable to resolve reference $SQ$prefix/foo$SQ
c5119dcf
MH
307 EOF
308 printf "%s\n" "update $prefix/symref $E $D" |
309 test_must_fail git update-ref --stdin 2>output.err &&
310 test_cmp expected output.err
311'
312
313test_expect_success 'incorrect old value blocks indirect update' '
314 prefix=refs/incorrect-indirect-update &&
315 git symbolic-ref $prefix/symref $prefix/foo &&
316 git update-ref $prefix/foo $C &&
317 cat >expected <<-EOF &&
bd482d6e 318 fatal: cannot lock ref $SQ$prefix/symref$SQ: is at $C but expected $D
c5119dcf
MH
319 EOF
320 printf "%s\n" "update $prefix/symref $E $D" |
321 test_must_fail git update-ref --stdin 2>output.err &&
322 test_cmp expected output.err
323'
324
325test_expect_success 'existing old value blocks indirect create' '
326 prefix=refs/existing-indirect-create &&
327 git symbolic-ref $prefix/symref $prefix/foo &&
328 git update-ref $prefix/foo $C &&
329 cat >expected <<-EOF &&
bd482d6e 330 fatal: cannot lock ref $SQ$prefix/symref$SQ: reference already exists
c5119dcf
MH
331 EOF
332 printf "%s\n" "create $prefix/symref $E" |
333 test_must_fail git update-ref --stdin 2>output.err &&
334 test_cmp expected output.err
335'
336
337test_expect_success 'incorrect old value blocks indirect delete' '
338 prefix=refs/incorrect-indirect-delete &&
339 git symbolic-ref $prefix/symref $prefix/foo &&
340 git update-ref $prefix/foo $C &&
341 cat >expected <<-EOF &&
bd482d6e 342 fatal: cannot lock ref $SQ$prefix/symref$SQ: is at $C but expected $D
c5119dcf
MH
343 EOF
344 printf "%s\n" "delete $prefix/symref $D" |
345 test_must_fail git update-ref --stdin 2>output.err &&
346 test_cmp expected output.err
347'
348
349test_expect_success 'missing old value blocks indirect no-deref update' '
350 prefix=refs/missing-noderef-update &&
351 git symbolic-ref $prefix/symref $prefix/foo &&
352 cat >expected <<-EOF &&
bd482d6e 353 fatal: cannot lock ref $SQ$prefix/symref$SQ: reference is missing but expected $D
c5119dcf
MH
354 EOF
355 printf "%s\n" "option no-deref" "update $prefix/symref $E $D" |
356 test_must_fail git update-ref --stdin 2>output.err &&
357 test_cmp expected output.err
358'
359
360test_expect_success 'incorrect old value blocks indirect no-deref update' '
361 prefix=refs/incorrect-noderef-update &&
362 git symbolic-ref $prefix/symref $prefix/foo &&
363 git update-ref $prefix/foo $C &&
364 cat >expected <<-EOF &&
bd482d6e 365 fatal: cannot lock ref $SQ$prefix/symref$SQ: is at $C but expected $D
c5119dcf
MH
366 EOF
367 printf "%s\n" "option no-deref" "update $prefix/symref $E $D" |
368 test_must_fail git update-ref --stdin 2>output.err &&
369 test_cmp expected output.err
370'
371
e3f51039 372test_expect_success 'existing old value blocks indirect no-deref create' '
c5119dcf
MH
373 prefix=refs/existing-noderef-create &&
374 git symbolic-ref $prefix/symref $prefix/foo &&
375 git update-ref $prefix/foo $C &&
376 cat >expected <<-EOF &&
bd482d6e 377 fatal: cannot lock ref $SQ$prefix/symref$SQ: reference already exists
c5119dcf
MH
378 EOF
379 printf "%s\n" "option no-deref" "create $prefix/symref $E" |
380 test_must_fail git update-ref --stdin 2>output.err &&
381 test_cmp expected output.err
382'
383
384test_expect_success 'incorrect old value blocks indirect no-deref delete' '
385 prefix=refs/incorrect-noderef-delete &&
386 git symbolic-ref $prefix/symref $prefix/foo &&
387 git update-ref $prefix/foo $C &&
388 cat >expected <<-EOF &&
bd482d6e 389 fatal: cannot lock ref $SQ$prefix/symref$SQ: is at $C but expected $D
c5119dcf
MH
390 EOF
391 printf "%s\n" "option no-deref" "delete $prefix/symref $D" |
392 test_must_fail git update-ref --stdin 2>output.err &&
393 test_cmp expected output.err
394'
395
433efcad 396test_done