]> git.ipfire.org Git - thirdparty/git.git/blame - upload-pack.c
strmap: enable allocations to come from a mem_pool
[thirdparty/git.git] / upload-pack.c
CommitLineData
def88e9a 1#include "cache.h"
b2141fc1 2#include "config.h"
def88e9a
LT
3#include "refs.h"
4#include "pkt-line.h"
958c24b1 5#include "sideband.h"
109cd76d 6#include "repository.h"
cbd53a21 7#include "object-store.h"
f6b42a81
JH
8#include "tag.h"
9#include "object.h"
f0243f26 10#include "commit.h"
9b8dc263
JS
11#include "diff.h"
12#include "revision.h"
13#include "list-objects.h"
10ac85c7
JH
14#include "list-objects-filter.h"
15#include "list-objects-filter-options.h"
cc41fa8d 16#include "run-command.h"
47a59185 17#include "connect.h"
051e4005 18#include "sigchain.h"
ff5effdf 19#include "version.h"
daebaa78 20#include "string-list.h"
dbbcd44f 21#include "strvec.h"
5411b10c 22#include "prio-queue.h"
aa9bab29 23#include "protocol.h"
10ac85c7 24#include "quote.h"
a3d6b53e 25#include "upload-pack.h"
3145ea95 26#include "serve.h"
829a3215 27#include "commit-graph.h"
ba3ca1ed 28#include "commit-reach.h"
120ad2b0 29#include "shallow.h"
def88e9a 30
208acbfb 31/* Remember to update object flag allocation in object.h */
937a515a
JH
32#define THEY_HAVE (1u << 11)
33#define OUR_REF (1u << 12)
34#define WANTED (1u << 13)
35#define COMMON_KNOWN (1u << 14)
937a515a 36
f53514bc
JS
37#define SHALLOW (1u << 16)
38#define NOT_SHALLOW (1u << 17)
39#define CLIENT_SHALLOW (1u << 18)
390eb36b 40#define HIDDEN_REF (1u << 19)
f53514bc 41
d1035cac
JT
42#define ALL_FLAGS (THEY_HAVE | OUR_REF | WANTED | COMMON_KNOWN | SHALLOW | \
43 NOT_SHALLOW | CLIENT_SHALLOW | HIDDEN_REF)
44
629060d9
CC
45/* Enum for allowed unadvertised object request (UOR) */
46enum allow_uor {
47 /* Allow specifying sha1 if it is a ref tip. */
48 ALLOW_TIP_SHA1 = 0x01,
49 /* Allow request of a sha1 if it is reachable from a ref (possibly hidden ref). */
50 ALLOW_REACHABLE_SHA1 = 0x02,
51 /* Allow request of any sha1. Implies ALLOW_TIP_SHA1 and ALLOW_REACHABLE_SHA1. */
52 ALLOW_ANY_SHA1 = 0x07
53};
960deccb 54
a8497288
CC
55/*
56 * Please annotate, and if possible group together, fields used only
57 * for protocol v0 or only for protocol v2.
58 */
e8498322 59struct upload_pack_data {
a8497288 60 struct string_list symref; /* v0 only */
e8498322
CC
61 struct object_array want_obj;
62 struct object_array have_obj;
a8497288
CC
63 struct oid_array haves; /* v2 only */
64 struct string_list wanted_refs; /* v2 only */
e8498322
CC
65
66 struct object_array shallows;
67 struct string_list deepen_not;
de0e9f74 68 struct object_array extra_edge_obj;
e8498322
CC
69 int depth;
70 timestamp_t deepen_since;
71 int deepen_rev_list;
72 int deepen_relative;
f203a88c 73 int keepalive;
35b43a10 74 int shallow_nr;
f01c7916 75 timestamp_t oldest_have;
e8498322 76
d40f04e0 77 unsigned int timeout; /* v0 only */
e9d882b8
CC
78 enum {
79 NO_MULTI_ACK = 0,
80 MULTI_ACK = 1,
81 MULTI_ACK_DETAILED = 2
82 } multi_ack; /* v0 only */
d40f04e0 83
f8edd1ca
CC
84 /* 0 for no sideband, otherwise DEFAULT_PACKET_MAX or LARGE_PACKET_MAX */
85 int use_sideband;
86
dd4b732d 87 struct string_list uri_protocols;
629060d9 88 enum allow_uor allow_uor;
f1514c6a 89
e8498322 90 struct list_objects_filter_options filter_options;
6dd3456a 91 struct string_list allowed_filters;
e8498322
CC
92
93 struct packet_writer writer;
94
339a9840
CC
95 const char *pack_objects_hook;
96
a8497288 97 unsigned stateless_rpc : 1; /* v0 only */
d40f04e0
CC
98 unsigned no_done : 1; /* v0 only */
99 unsigned daemon_mode : 1; /* v0 only */
59a90261 100 unsigned filter_capability_requested : 1; /* v0 only */
e8498322
CC
101
102 unsigned use_thin_pack : 1;
103 unsigned use_ofs_delta : 1;
104 unsigned no_progress : 1;
105 unsigned use_include_tag : 1;
59abe196 106 unsigned allow_filter : 1;
6dd3456a 107 unsigned allow_filter_fallback : 1;
5b01a4e8 108 unsigned long tree_filter_max_depth;
a8497288
CC
109
110 unsigned done : 1; /* v2 only */
d1d7a945 111 unsigned allow_ref_in_want : 1; /* v2 only */
e3835cd4 112 unsigned allow_sideband_all : 1; /* v2 only */
e8498322
CC
113};
114
115static void upload_pack_data_init(struct upload_pack_data *data)
116{
438528f6 117 struct string_list symref = STRING_LIST_INIT_DUP;
e8498322
CC
118 struct string_list wanted_refs = STRING_LIST_INIT_DUP;
119 struct object_array want_obj = OBJECT_ARRAY_INIT;
120 struct object_array have_obj = OBJECT_ARRAY_INIT;
121 struct oid_array haves = OID_ARRAY_INIT;
122 struct object_array shallows = OBJECT_ARRAY_INIT;
123 struct string_list deepen_not = STRING_LIST_INIT_DUP;
dd4b732d 124 struct string_list uri_protocols = STRING_LIST_INIT_DUP;
de0e9f74 125 struct object_array extra_edge_obj = OBJECT_ARRAY_INIT;
6dd3456a 126 struct string_list allowed_filters = STRING_LIST_INIT_DUP;
e8498322
CC
127
128 memset(data, 0, sizeof(*data));
438528f6 129 data->symref = symref;
e8498322
CC
130 data->wanted_refs = wanted_refs;
131 data->want_obj = want_obj;
132 data->have_obj = have_obj;
133 data->haves = haves;
134 data->shallows = shallows;
135 data->deepen_not = deepen_not;
dd4b732d 136 data->uri_protocols = uri_protocols;
de0e9f74 137 data->extra_edge_obj = extra_edge_obj;
6dd3456a
TB
138 data->allowed_filters = allowed_filters;
139 data->allow_filter_fallback = 1;
5b01a4e8 140 data->tree_filter_max_depth = ULONG_MAX;
e8498322 141 packet_writer_init(&data->writer, 1);
f203a88c
CC
142
143 data->keepalive = 5;
e8498322
CC
144}
145
146static void upload_pack_data_clear(struct upload_pack_data *data)
147{
438528f6 148 string_list_clear(&data->symref, 1);
e8498322
CC
149 string_list_clear(&data->wanted_refs, 1);
150 object_array_clear(&data->want_obj);
151 object_array_clear(&data->have_obj);
152 oid_array_clear(&data->haves);
153 object_array_clear(&data->shallows);
154 string_list_clear(&data->deepen_not, 0);
de0e9f74 155 object_array_clear(&data->extra_edge_obj);
e8498322 156 list_objects_filter_release(&data->filter_options);
6dd3456a 157 string_list_clear(&data->allowed_filters, 1);
339a9840
CC
158
159 free((char *)data->pack_objects_hook);
e8498322
CC
160}
161
d40f04e0 162static void reset_timeout(unsigned int timeout)
960deccb
PA
163{
164 alarm(timeout);
165}
fb9040cc 166
f8edd1ca
CC
167static void send_client_data(int fd, const char *data, ssize_t sz,
168 int use_sideband)
583b7ea3 169{
4c4b7d1d
LF
170 if (use_sideband) {
171 send_sideband(1, fd, data, sz, use_sideband);
fcf0fe9e 172 return;
4c4b7d1d 173 }
958c24b1
JH
174 if (fd == 3)
175 /* emergency quit */
176 fd = 2;
177 if (fd == 2) {
93822c22 178 /* XXX: are we happy to lose stuff here? */
958c24b1 179 xwrite(fd, data, sz);
fcf0fe9e 180 return;
583b7ea3 181 }
cdf4fb8e 182 write_or_die(fd, data, sz);
583b7ea3
JH
183}
184
b790e0f6
NTND
185static int write_one_shallow(const struct commit_graft *graft, void *cb_data)
186{
187 FILE *fp = cb_data;
188 if (graft->nr_parent == -1)
7683e2e6 189 fprintf(fp, "--shallow %s\n", oid_to_hex(&graft->oid));
b790e0f6
NTND
190 return 0;
191}
192
acaaca7d
JT
193struct output_state {
194 char buffer[8193];
195 int used;
dd4b732d
JT
196 unsigned packfile_uris_started : 1;
197 unsigned packfile_started : 1;
acaaca7d
JT
198};
199
200static int relay_pack_data(int pack_objects_out, struct output_state *os,
dd4b732d 201 int use_sideband, int write_packfile_line)
acaaca7d
JT
202{
203 /*
204 * We keep the last byte to ourselves
205 * in case we detect broken rev-list, so that we
206 * can leave the stream corrupted. This is
207 * unfortunate -- unpack-objects would happily
208 * accept a valid packdata with trailing garbage,
209 * so appending garbage after we pass all the
210 * pack data is not good enough to signal
211 * breakage to downstream.
212 */
213 ssize_t readsz;
214
215 readsz = xread(pack_objects_out, os->buffer + os->used,
216 sizeof(os->buffer) - os->used);
217 if (readsz < 0) {
218 return readsz;
219 }
220 os->used += readsz;
221
dd4b732d
JT
222 while (!os->packfile_started) {
223 char *p;
224 if (os->used >= 4 && !memcmp(os->buffer, "PACK", 4)) {
225 os->packfile_started = 1;
226 if (write_packfile_line) {
227 if (os->packfile_uris_started)
228 packet_delim(1);
229 packet_write_fmt(1, "\1packfile\n");
230 }
231 break;
232 }
233 if ((p = memchr(os->buffer, '\n', os->used))) {
234 if (!os->packfile_uris_started) {
235 os->packfile_uris_started = 1;
236 if (!write_packfile_line)
237 BUG("packfile_uris requires sideband-all");
238 packet_write_fmt(1, "\1packfile-uris\n");
239 }
240 *p = '\0';
241 packet_write_fmt(1, "\1%s\n", os->buffer);
242
243 os->used -= p - os->buffer + 1;
244 memmove(os->buffer, p + 1, os->used);
245 } else {
246 /*
247 * Incomplete line.
248 */
249 return readsz;
250 }
251 }
252
acaaca7d
JT
253 if (os->used > 1) {
254 send_client_data(1, os->buffer, os->used - 1, use_sideband);
255 os->buffer[0] = os->buffer[os->used - 1];
256 os->used = 1;
257 } else {
258 send_client_data(1, os->buffer, os->used, use_sideband);
259 os->used = 0;
260 }
261
262 return readsz;
263}
264
dd4b732d
JT
265static void create_pack_file(struct upload_pack_data *pack_data,
266 const struct string_list *uri_protocols)
fb9040cc 267{
d3180279 268 struct child_process pack_objects = CHILD_PROCESS_INIT;
acaaca7d
JT
269 struct output_state output_state = { { 0 } };
270 char progress[128];
583b7ea3
JH
271 char abort_msg[] = "aborting due to possible repository "
272 "corruption on the remote side.";
1456b043 273 ssize_t sz;
65a3629e 274 int i;
cdab4858 275 FILE *pipe_fd;
75bfc6c2 276
339a9840 277 if (!pack_data->pack_objects_hook)
20b20a22
JK
278 pack_objects.git_cmd = 1;
279 else {
c972bf4c
JK
280 strvec_push(&pack_objects.args, pack_data->pack_objects_hook);
281 strvec_push(&pack_objects.args, "git");
20b20a22
JK
282 pack_objects.use_shell = 1;
283 }
284
35b43a10 285 if (pack_data->shallow_nr) {
c972bf4c
JK
286 strvec_push(&pack_objects.args, "--shallow-file");
287 strvec_push(&pack_objects.args, "");
f0cea83f 288 }
c972bf4c
JK
289 strvec_push(&pack_objects.args, "pack-objects");
290 strvec_push(&pack_objects.args, "--revs");
b5a2068c 291 if (pack_data->use_thin_pack)
c972bf4c 292 strvec_push(&pack_objects.args, "--thin");
75bfc6c2 293
c972bf4c 294 strvec_push(&pack_objects.args, "--stdout");
35b43a10 295 if (pack_data->shallow_nr)
c972bf4c 296 strvec_push(&pack_objects.args, "--shallow");
b5a2068c 297 if (!pack_data->no_progress)
c972bf4c 298 strvec_push(&pack_objects.args, "--progress");
b5a2068c 299 if (pack_data->use_ofs_delta)
c972bf4c 300 strvec_push(&pack_objects.args, "--delta-base-offset");
b5a2068c 301 if (pack_data->use_include_tag)
c972bf4c 302 strvec_push(&pack_objects.args, "--include-tag");
c9f03259 303 if (pack_data->filter_options.choice) {
cf9ceb5a 304 const char *spec =
c9f03259 305 expand_list_objects_filter_spec(&pack_data->filter_options);
0b6069fe
JT
306 if (pack_objects.use_shell) {
307 struct strbuf buf = STRBUF_INIT;
cf9ceb5a 308 sq_quote_buf(&buf, spec);
c972bf4c 309 strvec_pushf(&pack_objects.args, "--filter=%s", buf.buf);
0b6069fe
JT
310 strbuf_release(&buf);
311 } else {
f6d8942b 312 strvec_pushf(&pack_objects.args, "--filter=%s", spec);
0b6069fe 313 }
10ac85c7 314 }
dd4b732d
JT
315 if (uri_protocols) {
316 for (i = 0; i < uri_protocols->nr; i++)
c972bf4c 317 strvec_pushf(&pack_objects.args, "--uri-protocol=%s",
dd4b732d
JT
318 uri_protocols->items[i].string);
319 }
cc41fa8d 320
b9612197 321 pack_objects.in = -1;
cc41fa8d
JS
322 pack_objects.out = -1;
323 pack_objects.err = -1;
21edd3f1 324
4c324c00 325 if (start_command(&pack_objects))
7e44c935 326 die("git upload-pack: unable to fork git-pack-objects");
b1c71b72 327
cdab4858
NTND
328 pipe_fd = xfdopen(pack_objects.in, "w");
329
35b43a10 330 if (pack_data->shallow_nr)
b790e0f6
NTND
331 for_each_commit_graft(write_one_shallow, pipe_fd);
332
c9f03259 333 for (i = 0; i < pack_data->want_obj.nr; i++)
cdab4858 334 fprintf(pipe_fd, "%s\n",
c9f03259 335 oid_to_hex(&pack_data->want_obj.objects[i].item->oid));
cdab4858 336 fprintf(pipe_fd, "--not\n");
c9f03259 337 for (i = 0; i < pack_data->have_obj.nr; i++)
cdab4858 338 fprintf(pipe_fd, "%s\n",
c9f03259 339 oid_to_hex(&pack_data->have_obj.objects[i].item->oid));
de0e9f74 340 for (i = 0; i < pack_data->extra_edge_obj.nr; i++)
cdab4858 341 fprintf(pipe_fd, "%s\n",
de0e9f74 342 oid_to_hex(&pack_data->extra_edge_obj.objects[i].item->oid));
cdab4858
NTND
343 fprintf(pipe_fd, "\n");
344 fflush(pipe_fd);
345 fclose(pipe_fd);
f0cea83f 346
cc41fa8d
JS
347 /* We read from pack_objects.err to capture stderr output for
348 * progress bar, and pack_objects.out to capture the pack data.
b1c71b72 349 */
b1c71b72
JH
350
351 while (1) {
b1c71b72 352 struct pollfd pfd[2];
f203a88c 353 int pe, pu, pollsize, polltimeout;
05e95155 354 int ret;
b1c71b72 355
d40f04e0 356 reset_timeout(pack_data->timeout);
0d516ada 357
b1c71b72 358 pollsize = 0;
363b7817 359 pe = pu = -1;
b1c71b72 360
cc41fa8d
JS
361 if (0 <= pack_objects.out) {
362 pfd[pollsize].fd = pack_objects.out;
b1c71b72
JH
363 pfd[pollsize].events = POLLIN;
364 pu = pollsize;
365 pollsize++;
366 }
cc41fa8d
JS
367 if (0 <= pack_objects.err) {
368 pfd[pollsize].fd = pack_objects.err;
363b7817
JH
369 pfd[pollsize].events = POLLIN;
370 pe = pollsize;
371 pollsize++;
372 }
b1c71b72 373
4c324c00
JS
374 if (!pollsize)
375 break;
376
f203a88c
CC
377 polltimeout = pack_data->keepalive < 0
378 ? -1
379 : 1000 * pack_data->keepalive;
380
381 ret = poll(pfd, pollsize, polltimeout);
6c71f8b0 382
05e95155 383 if (ret < 0) {
4c324c00 384 if (errno != EINTR) {
d2b6afa2 385 error_errno("poll failed, resuming");
4c324c00 386 sleep(1);
b1c71b72 387 }
4c324c00
JS
388 continue;
389 }
6b59f51b
NP
390 if (0 <= pe && (pfd[pe].revents & (POLLIN|POLLHUP))) {
391 /* Status ready; we ship that in the side-band
392 * or dump to the standard error.
393 */
394 sz = xread(pack_objects.err, progress,
395 sizeof(progress));
396 if (0 < sz)
f8edd1ca
CC
397 send_client_data(2, progress, sz,
398 pack_data->use_sideband);
6b59f51b
NP
399 else if (sz == 0) {
400 close(pack_objects.err);
401 pack_objects.err = -1;
402 }
403 else
404 goto fail;
405 /* give priority to status messages */
406 continue;
407 }
4c324c00 408 if (0 <= pu && (pfd[pu].revents & (POLLIN|POLLHUP))) {
acaaca7d
JT
409 int result = relay_pack_data(pack_objects.out,
410 &output_state,
dd4b732d
JT
411 pack_data->use_sideband,
412 !!uri_protocols);
acaaca7d
JT
413
414 if (result == 0) {
4c324c00
JS
415 close(pack_objects.out);
416 pack_objects.out = -1;
acaaca7d 417 } else if (result < 0) {
4c324c00 418 goto fail;
b1c71b72 419 }
4c324c00 420 }
05e95155
JK
421
422 /*
423 * We hit the keepalive timeout without saying anything; send
424 * an empty message on the data sideband just to let the other
425 * side know we're still working on it, but don't have any data
426 * yet.
427 *
428 * If we don't have a sideband channel, there's no room in the
429 * protocol to say anything, so those clients are just out of
430 * luck.
431 */
f8edd1ca 432 if (!ret && pack_data->use_sideband) {
05e95155
JK
433 static const char buf[] = "0005\1";
434 write_or_die(1, buf, 5);
435 }
4c324c00 436 }
b1c71b72 437
4c324c00 438 if (finish_command(&pack_objects)) {
7e44c935 439 error("git upload-pack: git-pack-objects died with error.");
4c324c00
JS
440 goto fail;
441 }
b1c71b72 442
4c324c00 443 /* flush the data */
acaaca7d
JT
444 if (output_state.used > 0) {
445 send_client_data(1, output_state.buffer, output_state.used,
f8edd1ca 446 pack_data->use_sideband);
4c324c00 447 fprintf(stderr, "flushed.\n");
b1c71b72 448 }
f8edd1ca 449 if (pack_data->use_sideband)
4c324c00
JS
450 packet_flush(1);
451 return;
452
b1c71b72 453 fail:
f8edd1ca
CC
454 send_client_data(3, abort_msg, sizeof(abort_msg),
455 pack_data->use_sideband);
7e44c935 456 die("git upload-pack: %s", abort_msg);
fb9040cc
LT
457}
458
ea2c6e60 459static int do_got_oid(struct upload_pack_data *data, const struct object_id *oid)
def88e9a 460{
937a515a 461 int we_knew_they_have = 0;
ea2c6e60 462 struct object *o = parse_object(the_repository, oid);
b1e9fff7 463
b1e9fff7 464 if (!o)
cf93982f 465 die("oops (%s)", oid_to_hex(oid));
182a8dab 466 if (o->type == OBJ_COMMIT) {
b1e9fff7 467 struct commit_list *parents;
937a515a 468 struct commit *commit = (struct commit *)o;
b1e9fff7 469 if (o->flags & THEY_HAVE)
937a515a
JH
470 we_knew_they_have = 1;
471 else
472 o->flags |= THEY_HAVE;
f01c7916
CC
473 if (!data->oldest_have || (commit->date < data->oldest_have))
474 data->oldest_have = commit->date;
937a515a 475 for (parents = commit->parents;
b1e9fff7
JH
476 parents;
477 parents = parents->next)
478 parents->item->object.flags |= THEY_HAVE;
fb9040cc 479 }
937a515a 480 if (!we_knew_they_have) {
460ed0d4 481 add_object_array(o, NULL, &data->have_obj);
937a515a
JH
482 return 1;
483 }
484 return 0;
485}
486
ea2c6e60
CC
487static int got_oid(struct upload_pack_data *data,
488 const char *hex, struct object_id *oid)
489{
490 if (get_oid_hex(hex, oid))
491 die("git upload-pack: expected SHA1 object, got '%s'", hex);
77aa0941
JT
492 if (!has_object_file_with_flags(oid,
493 OBJECT_INFO_QUICK | OBJECT_INFO_SKIP_FETCH_OBJECT))
ea2c6e60
CC
494 return -1;
495 return do_got_oid(data, oid);
496}
497
08667348 498static int ok_to_give_up(struct upload_pack_data *data)
937a515a 499{
4fbcca4e 500 uint32_t min_generation = GENERATION_NUMBER_ZERO;
937a515a 501
08667348 502 if (!data->have_obj.nr)
937a515a
JH
503 return 0;
504
08667348 505 return can_all_from_reach_with_flag(&data->want_obj, THEY_HAVE,
f01c7916 506 COMMON_KNOWN, data->oldest_have,
4fbcca4e 507 min_generation);
def88e9a
LT
508}
509
07977695
CC
510static int get_common_commits(struct upload_pack_data *data,
511 struct packet_reader *reader)
def88e9a 512{
cf93982f 513 struct object_id oid;
514 char last_hex[GIT_MAX_HEXSZ + 1];
49bee717
SP
515 int got_common = 0;
516 int got_other = 0;
4e10cf9a 517 int sent_ready = 0;
def88e9a 518
f0243f26
JS
519 save_commit_buffer = 0;
520
eeefa7c9 521 for (;;) {
8bf3b758
NTND
522 const char *arg;
523
d40f04e0 524 reset_timeout(data->timeout);
def88e9a 525
01f9ec64 526 if (packet_reader_read(reader) != PACKET_READ_NORMAL) {
e9d882b8 527 if (data->multi_ack == MULTI_ACK_DETAILED
07977695
CC
528 && got_common
529 && !got_other
08667348 530 && ok_to_give_up(data)) {
4e10cf9a 531 sent_ready = 1;
81c634e9 532 packet_write_fmt(1, "ACK %s ready\n", last_hex);
4e10cf9a 533 }
53d69506 534 if (data->have_obj.nr == 0 || data->multi_ack)
81c634e9 535 packet_write_fmt(1, "NAK\n");
4e10cf9a 536
d40f04e0 537 if (data->no_done && sent_ready) {
81c634e9 538 packet_write_fmt(1, "ACK %s\n", last_hex);
4e10cf9a
JH
539 return 0;
540 }
df654abc 541 if (data->stateless_rpc)
42526b47 542 exit(0);
49bee717
SP
543 got_common = 0;
544 got_other = 0;
def88e9a
LT
545 continue;
546 }
01f9ec64 547 if (skip_prefix(reader->line, "have ", &arg)) {
460ed0d4 548 switch (got_oid(data, arg, &oid)) {
937a515a 549 case -1: /* they have what we do not */
49bee717 550 got_other = 1;
53d69506 551 if (data->multi_ack
08667348 552 && ok_to_give_up(data)) {
cf93982f 553 const char *hex = oid_to_hex(&oid);
e9d882b8 554 if (data->multi_ack == MULTI_ACK_DETAILED) {
4e10cf9a 555 sent_ready = 1;
81c634e9 556 packet_write_fmt(1, "ACK %s ready\n", hex);
4e10cf9a 557 } else
81c634e9 558 packet_write_fmt(1, "ACK %s continue\n", hex);
78affc49 559 }
937a515a
JH
560 break;
561 default:
49bee717 562 got_common = 1;
55dc227d 563 oid_to_hex_r(last_hex, &oid);
e9d882b8 564 if (data->multi_ack == MULTI_ACK_DETAILED)
81c634e9 565 packet_write_fmt(1, "ACK %s common\n", last_hex);
53d69506 566 else if (data->multi_ack)
81c634e9 567 packet_write_fmt(1, "ACK %s continue\n", last_hex);
07977695 568 else if (data->have_obj.nr == 1)
81c634e9 569 packet_write_fmt(1, "ACK %s\n", last_hex);
937a515a 570 break;
af2d3aa4 571 }
def88e9a
LT
572 continue;
573 }
01f9ec64 574 if (!strcmp(reader->line, "done")) {
07977695 575 if (data->have_obj.nr > 0) {
53d69506 576 if (data->multi_ack)
81c634e9 577 packet_write_fmt(1, "ACK %s\n", last_hex);
1bd8c8f0
JS
578 return 0;
579 }
81c634e9 580 packet_write_fmt(1, "NAK\n");
def88e9a
LT
581 return -1;
582 }
01f9ec64 583 die("git upload-pack: expected SHA1 list, got '%s'", reader->line);
def88e9a 584 }
def88e9a
LT
585}
586
629060d9 587static int is_our_ref(struct object *o, enum allow_uor allow_uor)
390eb36b 588{
629060d9
CC
589 int allow_hidden_ref = (allow_uor &
590 (ALLOW_TIP_SHA1 | ALLOW_REACHABLE_SHA1));
7199c093 591 return o->flags & ((allow_hidden_ref ? HIDDEN_REF : 0) | OUR_REF);
390eb36b
JH
592}
593
2997178e
NTND
594/*
595 * on successful case, it's up to the caller to close cmd->out
596 */
597static int do_reachable_revlist(struct child_process *cmd,
079aa97e 598 struct object_array *src,
f1514c6a 599 struct object_array *reachable,
629060d9 600 enum allow_uor allow_uor)
051e4005
JH
601{
602 static const char *argv[] = {
603 "rev-list", "--stdin", NULL,
604 };
051e4005 605 struct object *o;
a698d67b 606 FILE *cmd_in = NULL;
051e4005
JH
607 int i;
608
2997178e
NTND
609 cmd->argv = argv;
610 cmd->git_cmd = 1;
611 cmd->no_stderr = 1;
612 cmd->in = -1;
613 cmd->out = -1;
051e4005
JH
614
615 /*
7fcbd37f
NTND
616 * If the next rev-list --stdin encounters an unknown commit,
617 * it terminates, which will cause SIGPIPE in the write loop
051e4005
JH
618 * below.
619 */
620 sigchain_push(SIGPIPE, SIG_IGN);
621
2997178e 622 if (start_command(cmd))
7fcbd37f
NTND
623 goto error;
624
a698d67b
RS
625 cmd_in = xfdopen(cmd->in, "w");
626
051e4005
JH
627 for (i = get_max_object_index(); 0 < i; ) {
628 o = get_indexed_object(--i);
2a745324
BH
629 if (!o)
630 continue;
079aa97e
NTND
631 if (reachable && o->type == OBJ_COMMIT)
632 o->flags &= ~TMP_MARK;
629060d9 633 if (!is_our_ref(o, allow_uor))
051e4005 634 continue;
a698d67b 635 if (fprintf(cmd_in, "^%s\n", oid_to_hex(&o->oid)) < 0)
051e4005
JH
636 goto error;
637 }
3f0f6624
NTND
638 for (i = 0; i < src->nr; i++) {
639 o = src->objects[i].item;
629060d9 640 if (is_our_ref(o, allow_uor)) {
079aa97e
NTND
641 if (reachable)
642 add_object_array(o, NULL, reachable);
051e4005 643 continue;
079aa97e
NTND
644 }
645 if (reachable && o->type == OBJ_COMMIT)
646 o->flags |= TMP_MARK;
a698d67b 647 if (fprintf(cmd_in, "%s\n", oid_to_hex(&o->oid)) < 0)
051e4005
JH
648 goto error;
649 }
a698d67b
RS
650 if (ferror(cmd_in) || fflush(cmd_in))
651 goto error;
652 fclose(cmd_in);
2997178e
NTND
653 cmd->in = -1;
654 sigchain_pop(SIGPIPE);
051e4005 655
2997178e
NTND
656 return 0;
657
658error:
051e4005
JH
659 sigchain_pop(SIGPIPE);
660
a698d67b
RS
661 if (cmd_in)
662 fclose(cmd_in);
2997178e
NTND
663 if (cmd->out >= 0)
664 close(cmd->out);
665 return -1;
666}
667
f1514c6a 668static int get_reachable_list(struct upload_pack_data *data,
079aa97e
NTND
669 struct object_array *reachable)
670{
671 struct child_process cmd = CHILD_PROCESS_INIT;
672 int i;
673 struct object *o;
55dc227d 674 char namebuf[GIT_MAX_HEXSZ + 2]; /* ^ + hash + LF */
675 const unsigned hexsz = the_hash_algo->hexsz;
079aa97e 676
f1514c6a 677 if (do_reachable_revlist(&cmd, &data->shallows, reachable,
629060d9 678 data->allow_uor) < 0)
079aa97e
NTND
679 return -1;
680
55dc227d 681 while ((i = read_in_full(cmd.out, namebuf, hexsz + 1)) == hexsz + 1) {
62b89d43 682 struct object_id oid;
55dc227d 683 const char *p;
079aa97e 684
62b89d43 685 if (parse_oid_hex(namebuf, &oid, &p) || *p != '\n')
079aa97e
NTND
686 break;
687
d0229abd 688 o = lookup_object(the_repository, &oid);
079aa97e
NTND
689 if (o && o->type == OBJ_COMMIT) {
690 o->flags &= ~TMP_MARK;
691 }
692 }
693 for (i = get_max_object_index(); 0 < i; i--) {
694 o = get_indexed_object(i - 1);
695 if (o && o->type == OBJ_COMMIT &&
696 (o->flags & TMP_MARK)) {
697 add_object_array(o, NULL, reachable);
698 o->flags &= ~TMP_MARK;
699 }
700 }
701 close(cmd.out);
702
703 if (finish_command(&cmd))
704 return -1;
705
706 return 0;
707}
708
629060d9 709static int has_unreachable(struct object_array *src, enum allow_uor allow_uor)
2997178e
NTND
710{
711 struct child_process cmd = CHILD_PROCESS_INIT;
712 char buf[1];
713 int i;
714
629060d9 715 if (do_reachable_revlist(&cmd, src, NULL, allow_uor) < 0)
2997178e 716 return 1;
051e4005
JH
717
718 /*
719 * The commits out of the rev-list are not ancestors of
720 * our ref.
721 */
2997178e 722 i = read_in_full(cmd.out, buf, 1);
051e4005
JH
723 if (i)
724 goto error;
725 close(cmd.out);
7fcbd37f 726 cmd.out = -1;
051e4005
JH
727
728 /*
729 * rev-list may have died by encountering a bad commit
730 * in the history, in which case we do want to bail out
731 * even when it showed no commit.
732 */
733 if (finish_command(&cmd))
734 goto error;
735
736 /* All the non-tip ones are ancestors of what we advertised */
3f0f6624 737 return 0;
051e4005
JH
738
739error:
7fcbd37f
NTND
740 if (cmd.out >= 0)
741 close(cmd.out);
3f0f6624
NTND
742 return 1;
743}
7fcbd37f 744
b08c9742 745static void check_non_tip(struct upload_pack_data *data)
3f0f6624
NTND
746{
747 int i;
748
749 /*
750 * In the normal in-process case without
751 * uploadpack.allowReachableSHA1InWant,
752 * non-tip requests can never happen.
753 */
629060d9 754 if (!data->stateless_rpc && !(data->allow_uor & ALLOW_REACHABLE_SHA1))
3f0f6624 755 goto error;
629060d9 756 if (!has_unreachable(&data->want_obj, data->allow_uor))
3f0f6624
NTND
757 /* All the non-tip ones are ancestors of what we advertised */
758 return;
051e4005
JH
759
760error:
761 /* Pick one of them (we know there at least is one) */
b08c9742
CC
762 for (i = 0; i < data->want_obj.nr; i++) {
763 struct object *o = data->want_obj.objects[i].item;
629060d9 764 if (!is_our_ref(o, data->allow_uor)) {
b08c9742 765 packet_writer_error(&data->writer,
014ade74
JK
766 "upload-pack: not our ref %s",
767 oid_to_hex(&o->oid));
051e4005 768 die("git upload-pack: not our ref %s",
f2fd0760 769 oid_to_hex(&o->oid));
014ade74 770 }
051e4005
JH
771 }
772}
773
35b43a10 774static void send_shallow(struct upload_pack_data *data,
bc2e795c 775 struct commit_list *result)
5c24cdea
NTND
776{
777 while (result) {
778 struct object *object = &result->item->object;
779 if (!(object->flags & (CLIENT_SHALLOW|NOT_SHALLOW))) {
35b43a10 780 packet_writer_write(&data->writer, "shallow %s",
bc2e795c 781 oid_to_hex(&object->oid));
19143f13 782 register_shallow(the_repository, &object->oid);
35b43a10 783 data->shallow_nr++;
5c24cdea
NTND
784 }
785 result = result->next;
786 }
787}
788
329f9960 789static void send_unshallow(struct upload_pack_data *data)
e8e44de7 790{
e8e44de7 791 int i;
873700c9 792
329f9960
CC
793 for (i = 0; i < data->shallows.nr; i++) {
794 struct object *object = data->shallows.objects[i].item;
e8e44de7
NTND
795 if (object->flags & NOT_SHALLOW) {
796 struct commit_list *parents;
329f9960 797 packet_writer_write(&data->writer, "unshallow %s",
bc2e795c 798 oid_to_hex(&object->oid));
e8e44de7 799 object->flags &= ~CLIENT_SHALLOW;
873700c9
NTND
800 /*
801 * We want to _register_ "object" as shallow, but we
802 * also need to traverse object's parents to deepen a
803 * shallow clone. Unregister it for now so we can
804 * parse and add the parents to the want list, then
805 * re-register it.
806 */
e92b848c 807 unregister_shallow(&object->oid);
e8e44de7
NTND
808 object->parsed = 0;
809 parse_commit_or_die((struct commit *)object);
810 parents = ((struct commit *)object)->parents;
811 while (parents) {
812 add_object_array(&parents->item->object,
329f9960 813 NULL, &data->want_obj);
e8e44de7
NTND
814 parents = parents->next;
815 }
de0e9f74 816 add_object_array(object, NULL, &data->extra_edge_obj);
e8e44de7
NTND
817 }
818 /* make sure commit traversal conforms to client */
19143f13 819 register_shallow(the_repository, &object->oid);
e8e44de7 820 }
873700c9
NTND
821}
822
5056cf4a
JT
823static int check_ref(const char *refname_full, const struct object_id *oid,
824 int flag, void *cb_data);
b1492f22 825static void deepen(struct upload_pack_data *data, int depth)
873700c9 826{
c8813487 827 if (depth == INFINITE_DEPTH && !is_repository_shallow(the_repository)) {
873700c9
NTND
828 int i;
829
b1492f22
CC
830 for (i = 0; i < data->shallows.nr; i++) {
831 struct object *object = data->shallows.objects[i].item;
873700c9
NTND
832 object->flags |= NOT_SHALLOW;
833 }
b1492f22 834 } else if (data->deepen_relative) {
cccf74e2
NTND
835 struct object_array reachable_shallows = OBJECT_ARRAY_INIT;
836 struct commit_list *result;
837
5056cf4a
JT
838 /*
839 * Checking for reachable shallows requires that our refs be
840 * marked with OUR_REF.
841 */
842 head_ref_namespaced(check_ref, NULL);
843 for_each_namespaced_ref(check_ref, NULL);
844
f1514c6a 845 get_reachable_list(data, &reachable_shallows);
cccf74e2
NTND
846 result = get_shallow_commits(&reachable_shallows,
847 depth + 1,
848 SHALLOW, NOT_SHALLOW);
35b43a10 849 send_shallow(data, result);
cccf74e2
NTND
850 free_commit_list(result);
851 object_array_clear(&reachable_shallows);
873700c9
NTND
852 } else {
853 struct commit_list *result;
854
b1492f22 855 result = get_shallow_commits(&data->want_obj, depth,
873700c9 856 SHALLOW, NOT_SHALLOW);
35b43a10 857 send_shallow(data, result);
873700c9
NTND
858 free_commit_list(result);
859 }
860
329f9960 861 send_unshallow(data);
e8e44de7
NTND
862}
863
446e42c5
CC
864static void deepen_by_rev_list(struct upload_pack_data *data,
865 int ac,
866 const char **av)
569e554b
NTND
867{
868 struct commit_list *result;
869
6abada18 870 disable_commit_graph(the_repository);
569e554b 871 result = get_shallow_commits_by_rev_list(ac, av, SHALLOW, NOT_SHALLOW);
35b43a10 872 send_shallow(data, result);
569e554b 873 free_commit_list(result);
329f9960 874 send_unshallow(data);
685fbd32
BW
875}
876
877/* Returns 1 if a shallow list is sent or 0 otherwise */
ee703c8a 878static int send_shallow_list(struct upload_pack_data *data)
685fbd32
BW
879{
880 int ret = 0;
881
ee703c8a 882 if (data->depth > 0 && data->deepen_rev_list)
685fbd32 883 die("git upload-pack: deepen and deepen-since (or deepen-not) cannot be used together");
ee703c8a 884 if (data->depth > 0) {
b1492f22 885 deepen(data, data->depth);
685fbd32 886 ret = 1;
ee703c8a 887 } else if (data->deepen_rev_list) {
c972bf4c 888 struct strvec av = STRVEC_INIT;
685fbd32
BW
889 int i;
890
c972bf4c 891 strvec_push(&av, "rev-list");
ee703c8a 892 if (data->deepen_since)
c972bf4c 893 strvec_pushf(&av, "--max-age=%"PRItime, data->deepen_since);
ee703c8a 894 if (data->deepen_not.nr) {
c972bf4c 895 strvec_push(&av, "--not");
ee703c8a
CC
896 for (i = 0; i < data->deepen_not.nr; i++) {
897 struct string_list_item *s = data->deepen_not.items + i;
c972bf4c 898 strvec_push(&av, s->string);
685fbd32 899 }
c972bf4c 900 strvec_push(&av, "--not");
685fbd32 901 }
ee703c8a
CC
902 for (i = 0; i < data->want_obj.nr; i++) {
903 struct object *o = data->want_obj.objects[i].item;
c972bf4c 904 strvec_push(&av, oid_to_hex(&o->oid));
685fbd32 905 }
d70a9eb6 906 deepen_by_rev_list(data, av.nr, av.v);
c972bf4c 907 strvec_clear(&av);
685fbd32
BW
908 ret = 1;
909 } else {
ee703c8a 910 if (data->shallows.nr > 0) {
685fbd32 911 int i;
ee703c8a 912 for (i = 0; i < data->shallows.nr; i++)
00624d60 913 register_shallow(the_repository,
ee703c8a 914 &data->shallows.objects[i].item->oid);
685fbd32
BW
915 }
916 }
917
35b43a10 918 data->shallow_nr += data->shallows.nr;
685fbd32 919 return ret;
569e554b
NTND
920}
921
ae2948f3
BW
922static int process_shallow(const char *line, struct object_array *shallows)
923{
924 const char *arg;
925 if (skip_prefix(line, "shallow ", &arg)) {
926 struct object_id oid;
927 struct object *object;
928 if (get_oid_hex(arg, &oid))
929 die("invalid shallow line: %s", line);
109cd76d 930 object = parse_object(the_repository, &oid);
ae2948f3
BW
931 if (!object)
932 return 1;
933 if (object->type != OBJ_COMMIT)
934 die("invalid shallow object %s", oid_to_hex(&oid));
935 if (!(object->flags & CLIENT_SHALLOW)) {
936 object->flags |= CLIENT_SHALLOW;
937 add_object_array(object, NULL, shallows);
938 }
939 return 1;
940 }
941
942 return 0;
943}
944
945static int process_deepen(const char *line, int *depth)
946{
947 const char *arg;
948 if (skip_prefix(line, "deepen ", &arg)) {
949 char *end = NULL;
950 *depth = (int)strtol(arg, &end, 0);
951 if (!end || *end || *depth <= 0)
952 die("Invalid deepen: %s", line);
953 return 1;
954 }
955
956 return 0;
957}
958
959static int process_deepen_since(const char *line, timestamp_t *deepen_since, int *deepen_rev_list)
960{
961 const char *arg;
962 if (skip_prefix(line, "deepen-since ", &arg)) {
963 char *end = NULL;
964 *deepen_since = parse_timestamp(arg, &end, 0);
965 if (!end || *end || !deepen_since ||
966 /* revisions.c's max_age -1 is special */
967 *deepen_since == -1)
968 die("Invalid deepen-since: %s", line);
969 *deepen_rev_list = 1;
970 return 1;
971 }
972 return 0;
973}
974
975static int process_deepen_not(const char *line, struct string_list *deepen_not, int *deepen_rev_list)
976{
977 const char *arg;
978 if (skip_prefix(line, "deepen-not ", &arg)) {
979 char *ref = NULL;
980 struct object_id oid;
0b1dbf53 981 if (expand_ref(the_repository, arg, strlen(arg), &oid, &ref) != 1)
ae2948f3
BW
982 die("git upload-pack: ambiguous deepen-not: %s", line);
983 string_list_append(deepen_not, ref);
984 free(ref);
985 *deepen_rev_list = 1;
986 return 1;
987 }
988 return 0;
569e554b
NTND
989}
990
6dd3456a
TB
991NORETURN __attribute__((format(printf,2,3)))
992static void send_err_and_die(struct upload_pack_data *data,
993 const char *fmt, ...)
994{
995 struct strbuf buf = STRBUF_INIT;
996 va_list ap;
997
998 va_start(ap, fmt);
999 strbuf_vaddf(&buf, fmt, ap);
1000 va_end(ap);
1001
1002 packet_writer_error(&data->writer, "%s", buf.buf);
1003 die("%s", buf.buf);
1004}
1005
1006static void check_one_filter(struct upload_pack_data *data,
1007 struct list_objects_filter_options *opts)
1008{
1009 const char *key = list_object_filter_config_name(opts->choice);
1010 struct string_list_item *item = string_list_lookup(&data->allowed_filters,
1011 key);
1012 int allowed;
1013
1014 if (item)
1015 allowed = (intptr_t)item->util;
1016 else
1017 allowed = data->allow_filter_fallback;
1018
1019 if (!allowed)
1020 send_err_and_die(data, "filter '%s' not supported", key);
5b01a4e8
TB
1021
1022 if (opts->choice == LOFC_TREE_DEPTH &&
1023 opts->tree_exclude_depth > data->tree_filter_max_depth)
1024 send_err_and_die(data,
1025 "tree filter allows max depth %lu, but got %lu",
1026 data->tree_filter_max_depth,
1027 opts->tree_exclude_depth);
6dd3456a
TB
1028}
1029
1030static void check_filter_recurse(struct upload_pack_data *data,
1031 struct list_objects_filter_options *opts)
1032{
1033 size_t i;
1034
1035 check_one_filter(data, opts);
1036 if (opts->choice != LOFC_COMBINE)
1037 return;
1038
1039 for (i = 0; i < opts->sub_nr; i++)
1040 check_filter_recurse(data, &opts->sub[i]);
1041}
1042
1043static void die_if_using_banned_filter(struct upload_pack_data *data)
1044{
1045 check_filter_recurse(data, &data->filter_options);
1046}
1047
d92ae2c0
CC
1048static void receive_needs(struct upload_pack_data *data,
1049 struct packet_reader *reader)
fb9040cc 1050{
051e4005 1051 int has_non_tip = 0;
fb9040cc 1052
35b43a10 1053 data->shallow_nr = 0;
fb9040cc 1054 for (;;) {
565ebbf7 1055 struct object *o;
f47182c8 1056 const char *features;
cf93982f 1057 struct object_id oid_buf;
8bf3b758
NTND
1058 const char *arg;
1059
d40f04e0 1060 reset_timeout(data->timeout);
01f9ec64 1061 if (packet_reader_read(reader) != PACKET_READ_NORMAL)
ed09aef0 1062 break;
e091eb93 1063
7a516764 1064 if (process_shallow(reader->line, &data->shallows))
ed09aef0 1065 continue;
7a516764 1066 if (process_deepen(reader->line, &data->depth))
016e6ccb 1067 continue;
7a516764 1068 if (process_deepen_since(reader->line, &data->deepen_since, &data->deepen_rev_list))
569e554b 1069 continue;
7a516764 1070 if (process_deepen_not(reader->line, &data->deepen_not, &data->deepen_rev_list))
269a7a83 1071 continue;
ae2948f3 1072
01f9ec64 1073 if (skip_prefix(reader->line, "filter ", &arg)) {
59a90261 1074 if (!data->filter_capability_requested)
10ac85c7 1075 die("git upload-pack: filtering capability not negotiated");
d92ae2c0
CC
1076 list_objects_filter_die_if_populated(&data->filter_options);
1077 parse_list_objects_filter(&data->filter_options, arg);
6dd3456a 1078 die_if_using_banned_filter(data);
10ac85c7
JH
1079 continue;
1080 }
9bfa0f9b 1081
01f9ec64 1082 if (!skip_prefix(reader->line, "want ", &arg) ||
55dc227d 1083 parse_oid_hex(arg, &oid_buf, &features))
7e44c935 1084 die("git upload-pack: protocol error, "
01f9ec64 1085 "expected to get object ID, not '%s'", reader->line);
f47182c8 1086
cccf74e2 1087 if (parse_feature_request(features, "deepen-relative"))
7a516764 1088 data->deepen_relative = 1;
f47182c8 1089 if (parse_feature_request(features, "multi_ack_detailed"))
e9d882b8 1090 data->multi_ack = MULTI_ACK_DETAILED;
f47182c8 1091 else if (parse_feature_request(features, "multi_ack"))
e9d882b8 1092 data->multi_ack = MULTI_ACK;
f47182c8 1093 if (parse_feature_request(features, "no-done"))
d40f04e0 1094 data->no_done = 1;
f47182c8 1095 if (parse_feature_request(features, "thin-pack"))
b5a2068c 1096 data->use_thin_pack = 1;
f47182c8 1097 if (parse_feature_request(features, "ofs-delta"))
b5a2068c 1098 data->use_ofs_delta = 1;
f47182c8 1099 if (parse_feature_request(features, "side-band-64k"))
f8edd1ca 1100 data->use_sideband = LARGE_PACKET_MAX;
f47182c8 1101 else if (parse_feature_request(features, "side-band"))
f8edd1ca 1102 data->use_sideband = DEFAULT_PACKET_MAX;
f47182c8 1103 if (parse_feature_request(features, "no-progress"))
b5a2068c 1104 data->no_progress = 1;
f47182c8 1105 if (parse_feature_request(features, "include-tag"))
b5a2068c 1106 data->use_include_tag = 1;
59abe196
CC
1107 if (data->allow_filter &&
1108 parse_feature_request(features, "filter"))
59a90261 1109 data->filter_capability_requested = 1;
565ebbf7 1110
109cd76d 1111 o = parse_object(the_repository, &oid_buf);
bdb31ead 1112 if (!o) {
4ace0283 1113 packet_writer_error(&data->writer,
bc2e795c
JT
1114 "upload-pack: not our ref %s",
1115 oid_to_hex(&oid_buf));
9f9aa761 1116 die("git upload-pack: not our ref %s",
cf93982f 1117 oid_to_hex(&oid_buf));
bdb31ead 1118 }
565ebbf7
JH
1119 if (!(o->flags & WANTED)) {
1120 o->flags |= WANTED;
629060d9
CC
1121 if (!((data->allow_uor & ALLOW_ANY_SHA1) == ALLOW_ANY_SHA1
1122 || is_our_ref(o, data->allow_uor)))
051e4005 1123 has_non_tip = 1;
d92ae2c0 1124 add_object_array(o, NULL, &data->want_obj);
565ebbf7 1125 }
fb9040cc 1126 }
9462e3f5 1127
051e4005
JH
1128 /*
1129 * We have sent all our refs already, and the other end
1130 * should have chosen out of them. When we are operating
1131 * in the stateless RPC mode, however, their choice may
1132 * have been based on the set of older refs advertised
1133 * by another process that handled the initial request.
1134 */
1135 if (has_non_tip)
b08c9742 1136 check_non_tip(data);
051e4005 1137
f8edd1ca 1138 if (!data->use_sideband && data->daemon_mode)
b5a2068c 1139 data->no_progress = 1;
9462e3f5 1140
7a516764 1141 if (data->depth == 0 && !data->deepen_rev_list && data->shallows.nr == 0)
f53514bc 1142 return;
569e554b 1143
ee703c8a 1144 if (send_shallow_list(data))
685fbd32 1145 packet_flush(1);
fb9040cc
LT
1146}
1147
daebaa78 1148/* return non-zero if the ref is hidden, otherwise 0 */
78a766ab
LF
1149static int mark_our_ref(const char *refname, const char *refname_full,
1150 const struct object_id *oid)
cbbe50db 1151{
0ebbcf70 1152 struct object *o = lookup_unknown_object(oid);
daebaa78 1153
78a766ab 1154 if (ref_is_hidden(refname, refname_full)) {
390eb36b 1155 o->flags |= HIDDEN_REF;
daebaa78 1156 return 1;
390eb36b 1157 }
3f1da57f 1158 o->flags |= OUR_REF;
cbbe50db
JH
1159 return 0;
1160}
1161
78a766ab 1162static int check_ref(const char *refname_full, const struct object_id *oid,
363e98bf 1163 int flag, void *cb_data)
e172755b 1164{
78a766ab
LF
1165 const char *refname = strip_namespace(refname_full);
1166
1167 mark_our_ref(refname, refname_full, oid);
e172755b
JK
1168 return 0;
1169}
1170
7171d8c1
JH
1171static void format_symref_info(struct strbuf *buf, struct string_list *symref)
1172{
1173 struct string_list_item *item;
1174
1175 if (!symref->nr)
1176 return;
1177 for_each_string_list_item(item, symref)
1178 strbuf_addf(buf, " symref=%s:%s", item->string, (char *)item->util);
1179}
1180
363e98bf
MH
1181static int send_ref(const char *refname, const struct object_id *oid,
1182 int flag, void *cb_data)
def88e9a 1183{
ed09aef0 1184 static const char *capabilities = "multi_ack thin-pack side-band"
cccf74e2
NTND
1185 " side-band-64k ofs-delta shallow deepen-since deepen-not"
1186 " deepen-relative no-progress include-tag multi_ack_detailed";
6b01ecfe 1187 const char *refname_nons = strip_namespace(refname);
21758aff 1188 struct object_id peeled;
762f9276 1189 struct upload_pack_data *data = cb_data;
b5b16990 1190
78a766ab 1191 if (mark_our_ref(refname_nons, refname, oid))
daebaa78 1192 return 0;
cbbe50db 1193
7171d8c1
JH
1194 if (capabilities) {
1195 struct strbuf symref_info = STRBUF_INIT;
1196
762f9276 1197 format_symref_info(&symref_info, &data->symref);
bf30dbf8 1198 packet_write_fmt(1, "%s %s%c%s%s%s%s%s%s object-format=%s agent=%s\n",
363e98bf 1199 oid_to_hex(oid), refname_nons,
cf2ad8e6 1200 0, capabilities,
629060d9 1201 (data->allow_uor & ALLOW_TIP_SHA1) ?
7199c093 1202 " allow-tip-sha1-in-want" : "",
629060d9 1203 (data->allow_uor & ALLOW_REACHABLE_SHA1) ?
68ee6289 1204 " allow-reachable-sha1-in-want" : "",
df654abc 1205 data->stateless_rpc ? " no-done" : "",
7171d8c1 1206 symref_info.buf,
59abe196 1207 data->allow_filter ? " filter" : "",
bf30dbf8 1208 the_hash_algo->name,
ff5effdf 1209 git_user_agent_sanitized());
7171d8c1
JH
1210 strbuf_release(&symref_info);
1211 } else {
81c634e9 1212 packet_write_fmt(1, "%s %s\n", oid_to_hex(oid), refname_nons);
7171d8c1 1213 }
1f5881bb 1214 capabilities = NULL;
b420d909 1215 if (!peel_ref(refname, &peeled))
81c634e9 1216 packet_write_fmt(1, "%s %s^{}\n", oid_to_hex(&peeled), refname_nons);
def88e9a
LT
1217 return 0;
1218}
1219
7dabd056
MH
1220static int find_symref(const char *refname, const struct object_id *oid,
1221 int flag, void *cb_data)
7171d8c1
JH
1222{
1223 const char *symref_target;
1224 struct string_list_item *item;
7171d8c1
JH
1225
1226 if ((flag & REF_ISSYMREF) == 0)
1227 return 0;
744c040b 1228 symref_target = resolve_ref_unsafe(refname, 0, NULL, &flag);
7171d8c1
JH
1229 if (!symref_target || (flag & REF_ISSYMREF) == 0)
1230 die("'%s' is a symref but it is not?", refname);
533e0882
JK
1231 item = string_list_append(cb_data, strip_namespace(refname));
1232 item->util = xstrdup(strip_namespace(symref_target));
7171d8c1
JH
1233 return 0;
1234}
1235
6dd3456a
TB
1236static int parse_object_filter_config(const char *var, const char *value,
1237 struct upload_pack_data *data)
1238{
1239 struct strbuf buf = STRBUF_INIT;
1240 const char *sub, *key;
1241 size_t sub_len;
1242
1243 if (parse_config_key(var, "uploadpackfilter", &sub, &sub_len, &key))
1244 return 0;
1245
1246 if (!sub) {
1247 if (!strcmp(key, "allow"))
1248 data->allow_filter_fallback = git_config_bool(var, value);
1249 return 0;
1250 }
1251
1252 strbuf_add(&buf, sub, sub_len);
1253
1254 if (!strcmp(key, "allow"))
1255 string_list_insert(&data->allowed_filters, buf.buf)->util =
1256 (void *)(intptr_t)git_config_bool(var, value);
5b01a4e8
TB
1257 else if (!strcmp(buf.buf, "tree") && !strcmp(key, "maxdepth")) {
1258 if (!value) {
1259 strbuf_release(&buf);
1260 return config_error_nonbool(var);
1261 }
1262 string_list_insert(&data->allowed_filters, buf.buf)->util =
1263 (void *)(intptr_t)1;
1264 data->tree_filter_max_depth = git_config_ulong(var, value);
1265 }
6dd3456a
TB
1266
1267 strbuf_release(&buf);
1268 return 0;
1269}
1270
8a0e6f16 1271static int upload_pack_config(const char *var, const char *value, void *cb_data)
daebaa78 1272{
f203a88c
CC
1273 struct upload_pack_data *data = cb_data;
1274
7199c093
FM
1275 if (!strcmp("uploadpack.allowtipsha1inwant", var)) {
1276 if (git_config_bool(var, value))
629060d9 1277 data->allow_uor |= ALLOW_TIP_SHA1;
7199c093 1278 else
629060d9 1279 data->allow_uor &= ~ALLOW_TIP_SHA1;
68ee6289
FM
1280 } else if (!strcmp("uploadpack.allowreachablesha1inwant", var)) {
1281 if (git_config_bool(var, value))
629060d9 1282 data->allow_uor |= ALLOW_REACHABLE_SHA1;
68ee6289 1283 else
629060d9 1284 data->allow_uor &= ~ALLOW_REACHABLE_SHA1;
f8edeaa0
DT
1285 } else if (!strcmp("uploadpack.allowanysha1inwant", var)) {
1286 if (git_config_bool(var, value))
629060d9 1287 data->allow_uor |= ALLOW_ANY_SHA1;
f8edeaa0 1288 else
629060d9 1289 data->allow_uor &= ~ALLOW_ANY_SHA1;
7199c093 1290 } else if (!strcmp("uploadpack.keepalive", var)) {
f203a88c
CC
1291 data->keepalive = git_config_int(var, value);
1292 if (!data->keepalive)
1293 data->keepalive = -1;
10ac85c7 1294 } else if (!strcmp("uploadpack.allowfilter", var)) {
59abe196 1295 data->allow_filter = git_config_bool(var, value);
516e2b76 1296 } else if (!strcmp("uploadpack.allowrefinwant", var)) {
d1d7a945 1297 data->allow_ref_in_want = git_config_bool(var, value);
0bbc0bc5 1298 } else if (!strcmp("uploadpack.allowsidebandall", var)) {
e3835cd4 1299 data->allow_sideband_all = git_config_bool(var, value);
8e712ef6
EN
1300 } else if (!strcmp("core.precomposeunicode", var)) {
1301 precomposed_unicode = git_config_bool(var, value);
05e95155 1302 }
aaaa8818 1303
6dc905d9
MR
1304 if (current_config_scope() != CONFIG_SCOPE_LOCAL &&
1305 current_config_scope() != CONFIG_SCOPE_WORKTREE) {
aaaa8818 1306 if (!strcmp("uploadpack.packobjectshook", var))
339a9840 1307 return git_config_string(&data->pack_objects_hook, var, value);
aaaa8818
JK
1308 }
1309
6dd3456a
TB
1310 parse_object_filter_config(var, value, data);
1311
daebaa78
JH
1312 return parse_hide_refs_config(var, value, "uploadpack");
1313}
1314
a3d6b53e 1315void upload_pack(struct upload_pack_options *options)
def88e9a 1316{
01f9ec64 1317 struct packet_reader reader;
ebf8ebcc 1318 struct upload_pack_data data;
960deccb 1319
ebf8ebcc
CC
1320 upload_pack_data_init(&data);
1321
8a0e6f16
CC
1322 git_config(upload_pack_config, &data);
1323
df654abc 1324 data.stateless_rpc = options->stateless_rpc;
d40f04e0
CC
1325 data.daemon_mode = options->daemon_mode;
1326 data.timeout = options->timeout;
df654abc 1327
438528f6 1328 head_ref_namespaced(find_symref, &data.symref);
a6080a0a 1329
df654abc 1330 if (options->advertise_refs || !data.stateless_rpc) {
d40f04e0 1331 reset_timeout(data.timeout);
762f9276
CC
1332 head_ref_namespaced(send_ref, &data);
1333 for_each_namespaced_ref(send_ref, &data);
a3d6b53e
BW
1334 advertise_shallow_grafts(1);
1335 packet_flush(1);
1336 } else {
1337 head_ref_namespaced(check_ref, NULL);
1338 for_each_namespaced_ref(check_ref, NULL);
aa9bab29 1339 }
01f9ec64 1340
ebf8ebcc
CC
1341 if (!options->advertise_refs) {
1342 packet_reader_init(&reader, 0, NULL, 0,
1343 PACKET_READ_CHOMP_NEWLINE |
1344 PACKET_READ_DIE_ON_ERR_PACKET);
1345
d92ae2c0 1346 receive_needs(&data, &reader);
ebf8ebcc 1347 if (data.want_obj.nr) {
07977695 1348 get_common_commits(&data, &reader);
cae2ee10 1349 create_pack_file(&data, NULL);
ebf8ebcc 1350 }
a3d6b53e 1351 }
08450ef7 1352
ebf8ebcc 1353 upload_pack_data_clear(&data);
def88e9a 1354}
04b33055 1355
bc2e795c
JT
1356static int parse_want(struct packet_writer *writer, const char *line,
1357 struct object_array *want_obj)
3145ea95
BW
1358{
1359 const char *arg;
1360 if (skip_prefix(line, "want ", &arg)) {
1361 struct object_id oid;
1362 struct object *o;
1363
1364 if (get_oid_hex(arg, &oid))
1365 die("git upload-pack: protocol error, "
1366 "expected to get oid, not '%s'", line);
1367
109cd76d 1368 o = parse_object(the_repository, &oid);
3145ea95 1369 if (!o) {
bc2e795c
JT
1370 packet_writer_error(writer,
1371 "upload-pack: not our ref %s",
1372 oid_to_hex(&oid));
3145ea95
BW
1373 die("git upload-pack: not our ref %s",
1374 oid_to_hex(&oid));
1375 }
1376
1377 if (!(o->flags & WANTED)) {
1378 o->flags |= WANTED;
1d1243fe 1379 add_object_array(o, NULL, want_obj);
3145ea95
BW
1380 }
1381
1382 return 1;
1383 }
1384
1385 return 0;
1386}
1387
bc2e795c
JT
1388static int parse_want_ref(struct packet_writer *writer, const char *line,
1389 struct string_list *wanted_refs,
1d1243fe 1390 struct object_array *want_obj)
516e2b76
BW
1391{
1392 const char *arg;
1393 if (skip_prefix(line, "want-ref ", &arg)) {
1394 struct object_id oid;
1395 struct string_list_item *item;
1396 struct object *o;
1397
1398 if (read_ref(arg, &oid)) {
bc2e795c 1399 packet_writer_error(writer, "unknown ref %s", arg);
516e2b76
BW
1400 die("unknown ref %s", arg);
1401 }
1402
1403 item = string_list_append(wanted_refs, arg);
1404 item->util = oiddup(&oid);
1405
1406 o = parse_object_or_die(&oid, arg);
1407 if (!(o->flags & WANTED)) {
1408 o->flags |= WANTED;
1d1243fe 1409 add_object_array(o, NULL, want_obj);
516e2b76
BW
1410 }
1411
1412 return 1;
1413 }
1414
1415 return 0;
1416}
1417
3145ea95
BW
1418static int parse_have(const char *line, struct oid_array *haves)
1419{
1420 const char *arg;
1421 if (skip_prefix(line, "have ", &arg)) {
1422 struct object_id oid;
1423
1424 if (get_oid_hex(arg, &oid))
1425 die("git upload-pack: expected SHA1 object, got '%s'", arg);
1426 oid_array_append(haves, &oid);
1427 return 1;
aa9bab29
BW
1428 }
1429
def88e9a
LT
1430 return 0;
1431}
3145ea95
BW
1432
1433static void process_args(struct packet_reader *request,
389f161a 1434 struct upload_pack_data *data)
3145ea95 1435{
4845b772 1436 while (packet_reader_read(request) == PACKET_READ_NORMAL) {
3145ea95 1437 const char *arg = request->line;
ba95710a 1438 const char *p;
3145ea95
BW
1439
1440 /* process want */
389f161a 1441 if (parse_want(&data->writer, arg, &data->want_obj))
3145ea95 1442 continue;
d1d7a945 1443 if (data->allow_ref_in_want &&
bc2e795c 1444 parse_want_ref(&data->writer, arg, &data->wanted_refs,
389f161a 1445 &data->want_obj))
516e2b76 1446 continue;
3145ea95
BW
1447 /* process have line */
1448 if (parse_have(arg, &data->haves))
1449 continue;
1450
1451 /* process args like thin-pack */
1452 if (!strcmp(arg, "thin-pack")) {
b5a2068c 1453 data->use_thin_pack = 1;
3145ea95
BW
1454 continue;
1455 }
1456 if (!strcmp(arg, "ofs-delta")) {
b5a2068c 1457 data->use_ofs_delta = 1;
3145ea95
BW
1458 continue;
1459 }
1460 if (!strcmp(arg, "no-progress")) {
b5a2068c 1461 data->no_progress = 1;
3145ea95
BW
1462 continue;
1463 }
1464 if (!strcmp(arg, "include-tag")) {
b5a2068c 1465 data->use_include_tag = 1;
3145ea95
BW
1466 continue;
1467 }
1468 if (!strcmp(arg, "done")) {
1469 data->done = 1;
1470 continue;
1471 }
1472
685fbd32
BW
1473 /* Shallow related arguments */
1474 if (process_shallow(arg, &data->shallows))
1475 continue;
1476 if (process_deepen(arg, &data->depth))
1477 continue;
1478 if (process_deepen_since(arg, &data->deepen_since,
1479 &data->deepen_rev_list))
1480 continue;
1481 if (process_deepen_not(arg, &data->deepen_not,
1482 &data->deepen_rev_list))
1483 continue;
1484 if (!strcmp(arg, "deepen-relative")) {
1485 data->deepen_relative = 1;
1486 continue;
1487 }
1488
59abe196 1489 if (data->allow_filter && skip_prefix(arg, "filter ", &p)) {
08450ef7
CC
1490 list_objects_filter_die_if_populated(&data->filter_options);
1491 parse_list_objects_filter(&data->filter_options, p);
6dd3456a 1492 die_if_using_banned_filter(data);
ba95710a
JT
1493 continue;
1494 }
1495
07c3c2aa 1496 if ((git_env_bool("GIT_TEST_SIDEBAND_ALL", 0) ||
e3835cd4 1497 data->allow_sideband_all) &&
07c3c2aa 1498 !strcmp(arg, "sideband-all")) {
0bbc0bc5
JT
1499 data->writer.use_sideband = 1;
1500 continue;
1501 }
1502
dd4b732d
JT
1503 if (skip_prefix(arg, "packfile-uris ", &p)) {
1504 string_list_split(&data->uri_protocols, p, ',', -1);
1505 continue;
1506 }
1507
3145ea95 1508 /* ignore unknown lines maybe? */
7cc6ed2d 1509 die("unexpected line: '%s'", arg);
3145ea95 1510 }
4845b772 1511
dd4b732d
JT
1512 if (data->uri_protocols.nr && !data->writer.use_sideband)
1513 string_list_clear(&data->uri_protocols, 0);
1514
4845b772
JK
1515 if (request->status != PACKET_READ_FLUSH)
1516 die(_("expected flush after fetch arguments"));
3145ea95
BW
1517}
1518
8dcf2278 1519static int process_haves(struct upload_pack_data *data, struct oid_array *common)
3145ea95
BW
1520{
1521 int i;
1522
1523 /* Process haves */
8dcf2278
CC
1524 for (i = 0; i < data->haves.nr; i++) {
1525 const struct object_id *oid = &data->haves.oid[i];
3145ea95 1526
77aa0941
JT
1527 if (!has_object_file_with_flags(oid,
1528 OBJECT_INFO_QUICK | OBJECT_INFO_SKIP_FETCH_OBJECT))
3145ea95
BW
1529 continue;
1530
1531 oid_array_append(common, oid);
1532
ea2c6e60 1533 do_got_oid(data, oid);
3145ea95
BW
1534 }
1535
1536 return 0;
1537}
1538
6fbbc437 1539static int send_acks(struct upload_pack_data *data, struct oid_array *acks)
3145ea95
BW
1540{
1541 int i;
1542
6fbbc437 1543 packet_writer_write(&data->writer, "acknowledgments\n");
3145ea95
BW
1544
1545 /* Send Acks */
1546 if (!acks->nr)
6fbbc437 1547 packet_writer_write(&data->writer, "NAK\n");
3145ea95
BW
1548
1549 for (i = 0; i < acks->nr; i++) {
6fbbc437 1550 packet_writer_write(&data->writer, "ACK %s\n",
bc2e795c 1551 oid_to_hex(&acks->oid[i]));
3145ea95
BW
1552 }
1553
08667348 1554 if (ok_to_give_up(data)) {
3145ea95 1555 /* Send Ready */
6fbbc437 1556 packet_writer_write(&data->writer, "ready\n");
3145ea95
BW
1557 return 1;
1558 }
1559
1560 return 0;
1561}
1562
389f161a 1563static int process_haves_and_send_acks(struct upload_pack_data *data)
3145ea95
BW
1564{
1565 struct oid_array common = OID_ARRAY_INIT;
3145ea95
BW
1566 int ret = 0;
1567
8dcf2278 1568 process_haves(data, &common);
3145ea95
BW
1569 if (data->done) {
1570 ret = 1;
6fbbc437 1571 } else if (send_acks(data, &common)) {
bc2e795c 1572 packet_writer_delim(&data->writer);
3145ea95
BW
1573 ret = 1;
1574 } else {
1575 /* Add Flush */
bc2e795c 1576 packet_writer_flush(&data->writer);
3145ea95
BW
1577 ret = 0;
1578 }
1579
3145ea95
BW
1580 oid_array_clear(&data->haves);
1581 oid_array_clear(&common);
1582 return ret;
1583}
1584
516e2b76
BW
1585static void send_wanted_ref_info(struct upload_pack_data *data)
1586{
1587 const struct string_list_item *item;
1588
1589 if (!data->wanted_refs.nr)
1590 return;
1591
bc2e795c 1592 packet_writer_write(&data->writer, "wanted-refs\n");
516e2b76
BW
1593
1594 for_each_string_list_item(item, &data->wanted_refs) {
bc2e795c
JT
1595 packet_writer_write(&data->writer, "%s %s\n",
1596 oid_to_hex(item->util),
1597 item->string);
516e2b76
BW
1598 }
1599
bc2e795c 1600 packet_writer_delim(&data->writer);
516e2b76
BW
1601}
1602
389f161a 1603static void send_shallow_info(struct upload_pack_data *data)
685fbd32
BW
1604{
1605 /* No shallow info needs to be sent */
1606 if (!data->depth && !data->deepen_rev_list && !data->shallows.nr &&
00624d60 1607 !is_repository_shallow(the_repository))
685fbd32
BW
1608 return;
1609
bc2e795c 1610 packet_writer_write(&data->writer, "shallow-info\n");
685fbd32 1611
ee703c8a 1612 if (!send_shallow_list(data) &&
00624d60 1613 is_repository_shallow(the_repository))
b1492f22 1614 deepen(data, INFINITE_DEPTH);
685fbd32
BW
1615
1616 packet_delim(1);
1617}
1618
3145ea95
BW
1619enum fetch_state {
1620 FETCH_PROCESS_ARGS = 0,
1621 FETCH_SEND_ACKS,
1622 FETCH_SEND_PACK,
1623 FETCH_DONE,
1624};
1625
c972bf4c 1626int upload_pack_v2(struct repository *r, struct strvec *keys,
3145ea95
BW
1627 struct packet_reader *request)
1628{
1629 enum fetch_state state = FETCH_PROCESS_ARGS;
1630 struct upload_pack_data data;
d1035cac
JT
1631
1632 clear_object_flags(ALL_FLAGS);
3145ea95
BW
1633
1634 upload_pack_data_init(&data);
f8edd1ca 1635 data.use_sideband = LARGE_PACKET_MAX;
3145ea95 1636
8a0e6f16
CC
1637 git_config(upload_pack_config, &data);
1638
3145ea95
BW
1639 while (state != FETCH_DONE) {
1640 switch (state) {
1641 case FETCH_PROCESS_ARGS:
389f161a 1642 process_args(request, &data);
3145ea95 1643
389f161a 1644 if (!data.want_obj.nr) {
3145ea95
BW
1645 /*
1646 * Request didn't contain any 'want' lines,
1647 * guess they didn't want anything.
1648 */
1649 state = FETCH_DONE;
1650 } else if (data.haves.nr) {
1651 /*
1652 * Request had 'have' lines, so lets ACK them.
1653 */
1654 state = FETCH_SEND_ACKS;
1655 } else {
1656 /*
1657 * Request had 'want's but no 'have's so we can
1658 * immedietly go to construct and send a pack.
1659 */
1660 state = FETCH_SEND_PACK;
1661 }
1662 break;
1663 case FETCH_SEND_ACKS:
389f161a 1664 if (process_haves_and_send_acks(&data))
3145ea95
BW
1665 state = FETCH_SEND_PACK;
1666 else
1667 state = FETCH_DONE;
1668 break;
1669 case FETCH_SEND_PACK:
516e2b76 1670 send_wanted_ref_info(&data);
389f161a 1671 send_shallow_info(&data);
685fbd32 1672
dd4b732d
JT
1673 if (data.uri_protocols.nr) {
1674 create_pack_file(&data, &data.uri_protocols);
1675 } else {
1676 packet_writer_write(&data.writer, "packfile\n");
1677 create_pack_file(&data, NULL);
1678 }
3145ea95
BW
1679 state = FETCH_DONE;
1680 break;
1681 case FETCH_DONE:
1682 continue;
1683 }
1684 }
1685
1686 upload_pack_data_clear(&data);
1687 return 0;
1688}
685fbd32
BW
1689
1690int upload_pack_advertise(struct repository *r,
1691 struct strbuf *value)
1692{
ba95710a
JT
1693 if (value) {
1694 int allow_filter_value;
516e2b76 1695 int allow_ref_in_want;
0bbc0bc5 1696 int allow_sideband_all_value;
dd4b732d 1697 char *str = NULL;
516e2b76 1698
685fbd32 1699 strbuf_addstr(value, "shallow");
516e2b76 1700
ba95710a
JT
1701 if (!repo_config_get_bool(the_repository,
1702 "uploadpack.allowfilter",
1703 &allow_filter_value) &&
1704 allow_filter_value)
1705 strbuf_addstr(value, " filter");
516e2b76
BW
1706
1707 if (!repo_config_get_bool(the_repository,
1708 "uploadpack.allowrefinwant",
1709 &allow_ref_in_want) &&
1710 allow_ref_in_want)
1711 strbuf_addstr(value, " ref-in-want");
0bbc0bc5 1712
07c3c2aa
JT
1713 if (git_env_bool("GIT_TEST_SIDEBAND_ALL", 0) ||
1714 (!repo_config_get_bool(the_repository,
1715 "uploadpack.allowsidebandall",
1716 &allow_sideband_all_value) &&
1717 allow_sideband_all_value))
0bbc0bc5 1718 strbuf_addstr(value, " sideband-all");
dd4b732d
JT
1719
1720 if (!repo_config_get_string(the_repository,
1721 "uploadpack.blobpackfileuri",
1722 &str) &&
1723 str) {
1724 strbuf_addstr(value, " packfile-uris");
1725 free(str);
1726 }
ba95710a 1727 }
516e2b76 1728
685fbd32
BW
1729 return 1;
1730}