]> git.ipfire.org Git - thirdparty/git.git/blobdiff - upload-pack.c
completion: nounset mode fixes
[thirdparty/git.git] / upload-pack.c
index 0523feaac2d9dd90c3c133907edacdbea6baaafb..39d0cf00be70ec76368dfbce9a2efab5815aea47 100644 (file)
@@ -42,8 +42,6 @@
 #define ALL_FLAGS (THEY_HAVE | OUR_REF | WANTED | COMMON_KNOWN | SHALLOW | \
                NOT_SHALLOW | CLIENT_SHALLOW | HIDDEN_REF)
 
-static timestamp_t oldest_have;
-
 /* Enum for allowed unadvertised object request (UOR) */
 enum allow_uor {
        /* Allow specifying sha1 if it is a ref tip. */
@@ -74,6 +72,7 @@ struct upload_pack_data {
        int deepen_relative;
        int keepalive;
        int shallow_nr;
+       timestamp_t oldest_have;
 
        unsigned int timeout;                                   /* v0 only */
        enum {
@@ -85,6 +84,7 @@ struct upload_pack_data {
        /* 0 for no sideband, otherwise DEFAULT_PACKET_MAX or LARGE_PACKET_MAX */
        int use_sideband;
 
+       struct string_list uri_protocols;
        enum allow_uor allow_uor;
 
        struct list_objects_filter_options filter_options;
@@ -118,6 +118,7 @@ static void upload_pack_data_init(struct upload_pack_data *data)
        struct oid_array haves = OID_ARRAY_INIT;
        struct object_array shallows = OBJECT_ARRAY_INIT;
        struct string_list deepen_not = STRING_LIST_INIT_DUP;
+       struct string_list uri_protocols = STRING_LIST_INIT_DUP;
        struct object_array extra_edge_obj = OBJECT_ARRAY_INIT;
 
        memset(data, 0, sizeof(*data));
@@ -128,6 +129,7 @@ static void upload_pack_data_init(struct upload_pack_data *data)
        data->haves = haves;
        data->shallows = shallows;
        data->deepen_not = deepen_not;
+       data->uri_protocols = uri_protocols;
        data->extra_edge_obj = extra_edge_obj;
        packet_writer_init(&data->writer, 1);
 
@@ -180,13 +182,86 @@ static int write_one_shallow(const struct commit_graft *graft, void *cb_data)
        return 0;
 }
 
-static void create_pack_file(struct upload_pack_data *pack_data)
+struct output_state {
+       char buffer[8193];
+       int used;
+       unsigned packfile_uris_started : 1;
+       unsigned packfile_started : 1;
+};
+
+static int relay_pack_data(int pack_objects_out, struct output_state *os,
+                          int use_sideband, int write_packfile_line)
+{
+       /*
+        * We keep the last byte to ourselves
+        * in case we detect broken rev-list, so that we
+        * can leave the stream corrupted.  This is
+        * unfortunate -- unpack-objects would happily
+        * accept a valid packdata with trailing garbage,
+        * so appending garbage after we pass all the
+        * pack data is not good enough to signal
+        * breakage to downstream.
+        */
+       ssize_t readsz;
+
+       readsz = xread(pack_objects_out, os->buffer + os->used,
+                      sizeof(os->buffer) - os->used);
+       if (readsz < 0) {
+               return readsz;
+       }
+       os->used += readsz;
+
+       while (!os->packfile_started) {
+               char *p;
+               if (os->used >= 4 && !memcmp(os->buffer, "PACK", 4)) {
+                       os->packfile_started = 1;
+                       if (write_packfile_line) {
+                               if (os->packfile_uris_started)
+                                       packet_delim(1);
+                               packet_write_fmt(1, "\1packfile\n");
+                       }
+                       break;
+               }
+               if ((p = memchr(os->buffer, '\n', os->used))) {
+                       if (!os->packfile_uris_started) {
+                               os->packfile_uris_started = 1;
+                               if (!write_packfile_line)
+                                       BUG("packfile_uris requires sideband-all");
+                               packet_write_fmt(1, "\1packfile-uris\n");
+                       }
+                       *p = '\0';
+                       packet_write_fmt(1, "\1%s\n", os->buffer);
+
+                       os->used -= p - os->buffer + 1;
+                       memmove(os->buffer, p + 1, os->used);
+               } else {
+                       /*
+                        * Incomplete line.
+                        */
+                       return readsz;
+               }
+       }
+
+       if (os->used > 1) {
+               send_client_data(1, os->buffer, os->used - 1, use_sideband);
+               os->buffer[0] = os->buffer[os->used - 1];
+               os->used = 1;
+       } else {
+               send_client_data(1, os->buffer, os->used, use_sideband);
+               os->used = 0;
+       }
+
+       return readsz;
+}
+
+static void create_pack_file(struct upload_pack_data *pack_data,
+                            const struct string_list *uri_protocols)
 {
        struct child_process pack_objects = CHILD_PROCESS_INIT;
-       char data[8193], progress[128];
+       struct output_state output_state = { { 0 } };
+       char progress[128];
        char abort_msg[] = "aborting due to possible repository "
                "corruption on the remote side.";
-       int buffered = -1;
        ssize_t sz;
        int i;
        FILE *pipe_fd;
@@ -230,6 +305,11 @@ static void create_pack_file(struct upload_pack_data *pack_data)
                                         spec);
                }
        }
+       if (uri_protocols) {
+               for (i = 0; i < uri_protocols->nr; i++)
+                       argv_array_pushf(&pack_objects.args, "--uri-protocol=%s",
+                                        uri_protocols->items[i].string);
+       }
 
        pack_objects.in = -1;
        pack_objects.out = -1;
@@ -319,40 +399,17 @@ static void create_pack_file(struct upload_pack_data *pack_data)
                        continue;
                }
                if (0 <= pu && (pfd[pu].revents & (POLLIN|POLLHUP))) {
-                       /* Data ready; we keep the last byte to ourselves
-                        * in case we detect broken rev-list, so that we
-                        * can leave the stream corrupted.  This is
-                        * unfortunate -- unpack-objects would happily
-                        * accept a valid packdata with trailing garbage,
-                        * so appending garbage after we pass all the
-                        * pack data is not good enough to signal
-                        * breakage to downstream.
-                        */
-                       char *cp = data;
-                       ssize_t outsz = 0;
-                       if (0 <= buffered) {
-                               *cp++ = buffered;
-                               outsz++;
-                       }
-                       sz = xread(pack_objects.out, cp,
-                                 sizeof(data) - outsz);
-                       if (0 < sz)
-                               ;
-                       else if (sz == 0) {
+                       int result = relay_pack_data(pack_objects.out,
+                                                    &output_state,
+                                                    pack_data->use_sideband,
+                                                    !!uri_protocols);
+
+                       if (result == 0) {
                                close(pack_objects.out);
                                pack_objects.out = -1;
-                       }
-                       else
+                       } else if (result < 0) {
                                goto fail;
-                       sz += outsz;
-                       if (1 < sz) {
-                               buffered = data[sz-1] & 0xFF;
-                               sz--;
                        }
-                       else
-                               buffered = -1;
-                       send_client_data(1, data, sz,
-                                        pack_data->use_sideband);
                }
 
                /*
@@ -377,9 +434,8 @@ static void create_pack_file(struct upload_pack_data *pack_data)
        }
 
        /* flush the data */
-       if (0 <= buffered) {
-               data[0] = buffered;
-               send_client_data(1, data, 1,
+       if (output_state.used > 0) {
+               send_client_data(1, output_state.buffer, output_state.used,
                                 pack_data->use_sideband);
                fprintf(stderr, "flushed.\n");
        }
@@ -393,18 +449,11 @@ static void create_pack_file(struct upload_pack_data *pack_data)
        die("git upload-pack: %s", abort_msg);
 }
 
-static int got_oid(const char *hex, struct object_id *oid,
-                  struct object_array *have_obj)
+static int do_got_oid(struct upload_pack_data *data, const struct object_id *oid)
 {
-       struct object *o;
        int we_knew_they_have = 0;
+       struct object *o = parse_object(the_repository, oid);
 
-       if (get_oid_hex(hex, oid))
-               die("git upload-pack: expected SHA1 object, got '%s'", hex);
-       if (!has_object_file(oid))
-               return -1;
-
-       o = parse_object(the_repository, oid);
        if (!o)
                die("oops (%s)", oid_to_hex(oid));
        if (o->type == OBJ_COMMIT) {
@@ -414,30 +463,39 @@ static int got_oid(const char *hex, struct object_id *oid,
                        we_knew_they_have = 1;
                else
                        o->flags |= THEY_HAVE;
-               if (!oldest_have || (commit->date < oldest_have))
-                       oldest_have = commit->date;
+               if (!data->oldest_have || (commit->date < data->oldest_have))
+                       data->oldest_have = commit->date;
                for (parents = commit->parents;
                     parents;
                     parents = parents->next)
                        parents->item->object.flags |= THEY_HAVE;
        }
        if (!we_knew_they_have) {
-               add_object_array(o, NULL, have_obj);
+               add_object_array(o, NULL, &data->have_obj);
                return 1;
        }
        return 0;
 }
 
-static int ok_to_give_up(const struct object_array *have_obj,
-                        struct object_array *want_obj)
+static int got_oid(struct upload_pack_data *data,
+                  const char *hex, struct object_id *oid)
+{
+       if (get_oid_hex(hex, oid))
+               die("git upload-pack: expected SHA1 object, got '%s'", hex);
+       if (!has_object_file(oid))
+               return -1;
+       return do_got_oid(data, oid);
+}
+
+static int ok_to_give_up(struct upload_pack_data *data)
 {
        uint32_t min_generation = GENERATION_NUMBER_ZERO;
 
-       if (!have_obj->nr)
+       if (!data->have_obj.nr)
                return 0;
 
-       return can_all_from_reach_with_flag(want_obj, THEY_HAVE,
-                                           COMMON_KNOWN, oldest_have,
+       return can_all_from_reach_with_flag(&data->want_obj, THEY_HAVE,
+                                           COMMON_KNOWN, data->oldest_have,
                                            min_generation);
 }
 
@@ -461,7 +519,7 @@ static int get_common_commits(struct upload_pack_data *data,
                        if (data->multi_ack == MULTI_ACK_DETAILED
                            && got_common
                            && !got_other
-                           && ok_to_give_up(&data->have_obj, &data->want_obj)) {
+                           && ok_to_give_up(data)) {
                                sent_ready = 1;
                                packet_write_fmt(1, "ACK %s ready\n", last_hex);
                        }
@@ -479,11 +537,11 @@ static int get_common_commits(struct upload_pack_data *data,
                        continue;
                }
                if (skip_prefix(reader->line, "have ", &arg)) {
-                       switch (got_oid(arg, &oid, &data->have_obj)) {
+                       switch (got_oid(data, arg, &oid)) {
                        case -1: /* they have what we do not */
                                got_other = 1;
                                if (data->multi_ack
-                                   && ok_to_give_up(&data->have_obj, &data->want_obj)) {
+                                   && ok_to_give_up(data)) {
                                        const char *hex = oid_to_hex(&oid);
                                        if (data->multi_ack == MULTI_ACK_DETAILED) {
                                                sent_ready = 1;
@@ -1187,7 +1245,7 @@ void upload_pack(struct upload_pack_options *options)
                receive_needs(&data, &reader);
                if (data.want_obj.nr) {
                        get_common_commits(&data, &reader);
-                       create_pack_file(&data);
+                       create_pack_file(&data, NULL);
                }
        }
 
@@ -1340,10 +1398,18 @@ static void process_args(struct packet_reader *request,
                        continue;
                }
 
+               if (skip_prefix(arg, "packfile-uris ", &p)) {
+                       string_list_split(&data->uri_protocols, p, ',', -1);
+                       continue;
+               }
+
                /* ignore unknown lines maybe? */
                die("unexpected line: '%s'", arg);
        }
 
+       if (data->uri_protocols.nr && !data->writer.use_sideband)
+               string_list_clear(&data->uri_protocols, 0);
+
        if (request->status != PACKET_READ_FLUSH)
                die(_("expected flush after fetch arguments"));
 }
@@ -1355,33 +1421,13 @@ static int process_haves(struct upload_pack_data *data, struct oid_array *common
        /* Process haves */
        for (i = 0; i < data->haves.nr; i++) {
                const struct object_id *oid = &data->haves.oid[i];
-               struct object *o;
-               int we_knew_they_have = 0;
 
                if (!has_object_file(oid))
                        continue;
 
                oid_array_append(common, oid);
 
-               o = parse_object(the_repository, oid);
-               if (!o)
-                       die("oops (%s)", oid_to_hex(oid));
-               if (o->type == OBJ_COMMIT) {
-                       struct commit_list *parents;
-                       struct commit *commit = (struct commit *)o;
-                       if (o->flags & THEY_HAVE)
-                               we_knew_they_have = 1;
-                       else
-                               o->flags |= THEY_HAVE;
-                       if (!oldest_have || (commit->date < oldest_have))
-                               oldest_have = commit->date;
-                       for (parents = commit->parents;
-                            parents;
-                            parents = parents->next)
-                               parents->item->object.flags |= THEY_HAVE;
-               }
-               if (!we_knew_they_have)
-                       add_object_array(o, NULL, &data->have_obj);
+               do_got_oid(data, oid);
        }
 
        return 0;
@@ -1402,7 +1448,7 @@ static int send_acks(struct upload_pack_data *data, struct oid_array *acks)
                                    oid_to_hex(&acks->oid[i]));
        }
 
-       if (ok_to_give_up(&data->have_obj, &data->want_obj)) {
+       if (ok_to_give_up(data)) {
                /* Send Ready */
                packet_writer_write(&data->writer, "ready\n");
                return 1;
@@ -1521,8 +1567,12 @@ int upload_pack_v2(struct repository *r, struct argv_array *keys,
                        send_wanted_ref_info(&data);
                        send_shallow_info(&data);
 
-                       packet_writer_write(&data.writer, "packfile\n");
-                       create_pack_file(&data);
+                       if (data.uri_protocols.nr) {
+                               create_pack_file(&data, &data.uri_protocols);
+                       } else {
+                               packet_writer_write(&data.writer, "packfile\n");
+                               create_pack_file(&data, NULL);
+                       }
                        state = FETCH_DONE;
                        break;
                case FETCH_DONE:
@@ -1541,6 +1591,7 @@ int upload_pack_advertise(struct repository *r,
                int allow_filter_value;
                int allow_ref_in_want;
                int allow_sideband_all_value;
+               char *str = NULL;
 
                strbuf_addstr(value, "shallow");
 
@@ -1562,6 +1613,14 @@ int upload_pack_advertise(struct repository *r,
                                           &allow_sideband_all_value) &&
                     allow_sideband_all_value))
                        strbuf_addstr(value, " sideband-all");
+
+               if (!repo_config_get_string(the_repository,
+                                           "uploadpack.blobpackfileuri",
+                                           &str) &&
+                   str) {
+                       strbuf_addstr(value, " packfile-uris");
+                       free(str);
+               }
        }
 
        return 1;