]> git.ipfire.org Git - thirdparty/git.git/commit - Makefile
git-compat-util: work around for access(X_OK) under root
authorClément Chigot <clement.chigot@atos.net>
Thu, 25 Apr 2019 07:01:56 +0000 (07:01 +0000)
committerJunio C Hamano <gitster@pobox.com>
Thu, 25 Apr 2019 08:49:44 +0000 (17:49 +0900)
commit400caafb2bb63712bb23cfa4d800261aab8e5cae
treeee1b449e160406742425b4c105497e4b3618c93c
parentee662bf5c66457dfa96a7148b2032a7f17868a54
git-compat-util: work around for access(X_OK) under root

On AIX, access(X_OK) may succeed when run as root even if the
execution isn't possible. This behavior is allowed by POSIX
which says:

  ... for a process with appropriate privileges, an implementation
  may indicate success for X_OK even if execute permission is not
  granted to any user.

It can lead hook programs to have their execution refused:

   git commit -m content
   fatal: cannot exec '.git/hooks/pre-commit': Permission denied

Add NEED_ACCESS_ROOT_HANDLER in order to use an access helper function.
It checks with stat if any executable flags is set when the current user
is root.

Signed-off-by: Clément Chigot <clement.chigot@atos.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Makefile
compat/access.c [new file with mode: 0644]
compat/fileno.c
config.mak.uname
git-compat-util.h