]> git.ipfire.org Git - thirdparty/git.git/commit - bisect.c
bisect: libify `handle_bad_merge_base` and its dependents
authorPranit Bauva <pranit.bauva@gmail.com>
Mon, 17 Feb 2020 08:40:38 +0000 (09:40 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 19 Feb 2020 17:37:15 +0000 (09:37 -0800)
commit9ec598e0d55ff263e47d95e7d4decef1eb1b6ac6
treed7abda0790a6582245f38db98e1f74629ff9507b
parent45b6370812cb9bc50212d50f071c8ae5dd851698
bisect: libify `handle_bad_merge_base` and its dependents

Since we want to get rid of git-bisect.sh, it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.

Emulate try catch in C by converting `exit(<positive-value>)` to
`return <negative-value>`. Follow POSIX conventions to return
<negative-value> to indicate error.

Update all callers to handle the error returns.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
bisect.c
bisect.h