]> git.ipfire.org Git - thirdparty/git.git/commit - builtin/cat-file.c
cat-file: fix a memory leak in --batch-command mode
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Fri, 1 Jul 2022 10:42:54 +0000 (12:42 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 1 Jul 2022 18:43:43 +0000 (11:43 -0700)
commitd90dafbe3180aa0ad095a5f2fa9c83bfa3d3767d
tree0c0be25af1ce54c981a022761185f263b2ee678b
parentfd74ac95ac31cefee41cb732255c25d910008fff
cat-file: fix a memory leak in --batch-command mode

Fix a memory leak introduced in 440c705ea63 (cat-file: add
--batch-command mode, 2022-02-18). The free_cmds() function was only
called on "queued_nr" if we had a "flush" command. As the "without
flush for blob info" test added in the same commit shows we can't rely
on that, so let's call free_cmds() again at the end.

Since "nr" follows the usual pattern of being set to 0 if we've
free()'d the memory already it's OK to call it twice, even in cases
where we are doing a "flush".

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/cat-file.c