]> git.ipfire.org Git - thirdparty/git.git/commit - builtin/index-pack.c
General const correctness fixes
authorShawn O. Pearce <spearce@spearce.org>
Wed, 7 Mar 2007 01:44:17 +0000 (20:44 -0500)
committerJunio C Hamano <junkio@cox.net>
Wed, 7 Mar 2007 18:47:10 +0000 (10:47 -0800)
commit3a55602eeca4ac8670e8698a7187e18b95683344
tree625a8af9c4655ace00b275c3e272c2764db3bcb8
parentff1f99453f1fe2fd9470f6ea268aed5a1839bd09
General const correctness fixes

We shouldn't attempt to assign constant strings into char*, as the
string is not writable at runtime.  Likewise we should always be
treating unsigned values as unsigned values, not as signed values.

Most of these are very straightforward.  The only exception is the
(unnecessary) xstrdup/free in builtin-branch.c for the detached
head case.  Since this is a user-level interactive type program
and that particular code path is executed no more than once, I feel
that the extra xstrdup call is well worth the easy elimination of
this warning.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
16 files changed:
builtin-blame.c
builtin-branch.c
builtin-for-each-ref.c
builtin-mailinfo.c
builtin-shortlog.c
builtin-show-branch.c
cache.h
commit.c
convert-objects.c
environment.c
fast-import.c
index-pack.c
interpolate.c
interpolate.h
path.c
sha1_file.c