]> git.ipfire.org Git - thirdparty/git.git/commit - commit-graph.c
commit-graph.c: prevent overflow in `fill_commit_in_graph()`
authorTaylor Blau <me@ttaylorr.com>
Wed, 12 Jul 2023 23:38:05 +0000 (19:38 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 14 Jul 2023 16:32:03 +0000 (09:32 -0700)
commit50a71c2942167654f95d00b450a961cf387547ec
treed2785c30dccea44c682171ec8a64a66779e36142
parent2740ed1c76df769aa1c6e75020ace72e2cc2e47f
commit-graph.c: prevent overflow in `fill_commit_in_graph()`

In a similar spirit as previous commits, ensure that we don't overflow
when the lex_index of the commit we are trying to fill out exceeds
2^32-1/(g->hash_len+16).

The other hunk touched in this patch is not susceptible to overflow,
since an explicit cast is made to a 64-bit unsigned value. For clarity
and consistency with the rest of the commits in this series, avoid a
tricky to reason about cast, and use `st_mult()` directly.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
commit-graph.c