]> git.ipfire.org Git - thirdparty/git.git/commit - commit.c
log_tree_diff: die when we fail to parse a commit
authorJeff King <peff@peff.net>
Thu, 24 Oct 2013 08:52:36 +0000 (04:52 -0400)
committerJunio C Hamano <gitster@pobox.com>
Thu, 24 Oct 2013 22:43:50 +0000 (15:43 -0700)
commit7059dccc6c60a872a314b19ac17702065a71d6bd
tree7fd82703079885e1adb864e8a8f185fdc6b45c8e
parente230c568c4b9a991e3175e5f65171a566fd8e39c
log_tree_diff: die when we fail to parse a commit

We currently call parse_commit and then assume we can
dereference the resulting "tree" struct field. If parsing
failed, however, that field is NULL and we end up
segfaulting.

Instead of a segfault, let's print an error message and die
a little more gracefully.

Note that this should never happen in practice, but may
happen in a corrupt repository.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
commit.c
commit.h
log-tree.c