]> git.ipfire.org Git - thirdparty/git.git/commit - commit.c
ident: rename IDENT_ERROR_ON_NO_NAME to IDENT_STRICT
authorJeff King <peff@peff.net>
Thu, 24 May 2012 23:28:40 +0000 (19:28 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 25 May 2012 00:16:41 +0000 (17:16 -0700)
commitf9bc573fdaeaf8621008f3f49aaaa64869791691
treebecd0a65e5488ae94fdf1781c70b5ab68eb85e0a
parentc73f384f92dcb0d7111533ed21f6c2dc9fcc323b
ident: rename IDENT_ERROR_ON_NO_NAME to IDENT_STRICT

Callers who ask for ERROR_ON_NO_NAME are not so much
concerned that the name will be blank (because, after all,
we will fall back to using the username), but rather it is a
check to make sure that low-quality identities do not end up
in things like commit messages or emails (whereas it is OK
for them to end up in things like reflogs).

When future commits add more quality checks on the identity,
each of these callers would want to use those checks, too.
Rather than modify each of them later to add a new flag,
let's refactor the flag.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/commit.c
builtin/log.c
builtin/merge.c
builtin/tag.c
builtin/var.c
cache.h
commit.c
gpg-interface.c
ident.c