]> git.ipfire.org Git - thirdparty/git.git/commit - compat/mingw.c
Move git_sort(), a stable sort, into into libgit.a
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Mon, 30 Sep 2019 17:21:54 +0000 (10:21 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 2 Oct 2019 05:44:51 +0000 (14:44 +0900)
commit97fff6101220b66bc293239ab2cf29fc3624072b
tree8c0c9a1415c4160b8d0f798d79e539d984d7c501
parent5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9
Move git_sort(), a stable sort, into into libgit.a

The `qsort()` function is not guaranteed to be stable, i.e. it does not
promise to maintain the order of items it is told to consider equal. In
contrast, the `git_sort()` function we carry in `compat/qsort.c` _is_
stable, by virtue of implementing a merge sort algorithm.

In preparation for using a stable sort in Git's rename detection, move
the stable sort into `libgit.a` so that it is compiled in
unconditionally, and rename it to `git_stable_qsort()`.

Note: this also makes the hack obsolete that was introduced in
fe21c6b285d (mingw: reencode environment variables on the fly (UTF-16
<-> UTF-8), 2018-10-30), where we included `compat/qsort.c` directly in
`compat/mingw.c` to use the stable sort.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Makefile
compat/mingw.c
git-compat-util.h
stable-qsort.c [moved from compat/qsort.c with 89% similarity]