]> git.ipfire.org Git - thirdparty/git.git/commit - config.c
handle_path_include: don't look at NULL value
authorJeff King <peff@peff.net>
Tue, 28 Jan 2014 01:37:30 +0000 (20:37 -0500)
committerJunio C Hamano <gitster@pobox.com>
Tue, 28 Jan 2014 19:59:49 +0000 (11:59 -0800)
commit67beb600563cf28186f44450e528df1ec4d524fd
tree1365fcd9d56c7d156756e4417b1af25f2ffaf768
parent53ec551c87c731c5c4171e943842998bdfb5548e
handle_path_include: don't look at NULL value

When we see config like:

  [include]
  path

the expand_user_path helper notices that the config value is
empty, but we then dereference NULL while printing the error
message (glibc will helpfully print "(null)" for us here,
but we cannot rely on that).

  $ git -c include.path rev-parse
  error: Could not expand include path '(null)'
  fatal: unable to parse command-line config

Instead of tweaking our message, let's actually use
config_error_nonbool to match other config variables that
expect a value:

  $ git -c include.path rev-parse
  error: Missing value for 'include.path'
  fatal: unable to parse command-line config

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
config.c