]> git.ipfire.org Git - thirdparty/git.git/commit - config.c
config: avoid calling `labs()` on too-large data type
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Thu, 13 Jun 2019 11:49:47 +0000 (04:49 -0700)
committerJunio C Hamano <gitster@pobox.com>
Thu, 13 Jun 2019 16:34:17 +0000 (09:34 -0700)
commit9dae4fe79f85dd0eaf41215bea76c68b65398fbc
treee6d017d7b63f0730eee15aa52def36f03067a23c
parent4fa42df972dc40fa3b50195ace838f2269da977a
config: avoid calling `labs()` on too-large data type

The `labs()` function operates, as the initial `l` suggests, on `long`
parameters. However, in `config.c` we tried to use it on values of type
`intmax_t`.

This problem was found by GCC v9.x.

To fix it, let's just "unroll" the function (i.e. negate the value if it
is negative).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
config.c