]> git.ipfire.org Git - thirdparty/git.git/commit - connect.c
connect: don't request v2 when pushing
authorBrandon Williams <bmwill@google.com>
Thu, 15 Mar 2018 17:31:31 +0000 (10:31 -0700)
committerJunio C Hamano <gitster@pobox.com>
Thu, 15 Mar 2018 19:01:09 +0000 (12:01 -0700)
commit1aa8dded3afff28d8f4c24a97b237a0d9e633173
tree15b0bc8637bea96070b572ba7724aeac259437f6
parent40fc51e39f178e81cbd7feadda51fca604f02ea8
connect: don't request v2 when pushing

In order to be able to ship protocol v2 with only supporting fetch, we
need clients to not issue a request to use protocol v2 when pushing
(since the client currently doesn't know how to push using protocol v2).
This allows a client to have protocol v2 configured in
`protocol.version` and take advantage of using v2 for fetch and falling
back to using v0 when pushing while v2 for push is being designed.

We could run into issues if we didn't fall back to protocol v2 when
pushing right now.  This is because currently a server will ignore a request to
use v2 when contacting the 'receive-pack' endpoint and fall back to
using v0, but when push v2 is rolled out to servers, the 'receive-pack'
endpoint will start responding using v2.  So we don't want to get into a
state where a client is requesting to push with v2 before they actually
know how to push using v2.

Signed-off-by: Brandon Williams <bmwill@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
connect.c
t/t5702-protocol-v2.sh