]> git.ipfire.org Git - thirdparty/git.git/commit - connect.c
connect.c: handle errors from split_cmdline
authorJeff King <peff@peff.net>
Tue, 11 Apr 2017 00:30:23 +0000 (20:30 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 17 Apr 2017 00:48:00 +0000 (17:48 -0700)
commit22e5ae5c8e6859e5670a2c6bbf5798778373144c
tree5a6dad8f1db78298d29162cc2fc4e3d3e6b3fb56
parent486c8e8c6a42a1e0537eedb2b5ab9e74eb58d5f7
connect.c: handle errors from split_cmdline

Commit e9d9a8a4d (connect: handle putty/plink also in
GIT_SSH_COMMAND, 2017-01-02) added a call to
split_cmdline(), but checks only for a non-zero return to
see if we got any output. Since the function returns
negative values (and a NULL argv) on error, we end up
dereferencing NULL and segfaulting.

Arguably we could report on the parsing error here, but it's
probably not worth it. This is a best-effort attempt to see
if we are using plink. So we can simply return here with
"no, it wasn't plink" and let the shell actually complain
about the bogus quoting.

Reported-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
connect.c
t/t5601-clone.sh