]> git.ipfire.org Git - thirdparty/git.git/commit - connect.c
ssh: 'simple' variant does not support --port
authorJonathan Nieder <jrnieder@gmail.com>
Mon, 20 Nov 2017 21:31:01 +0000 (13:31 -0800)
committerJunio C Hamano <gitster@pobox.com>
Tue, 21 Nov 2017 05:01:03 +0000 (14:01 +0900)
commit3fa5e0d07a979dfd1a1095a9dda4904c62189e00
treec76b4807066e4268f1ff0ced5e2f9deb8b76b73a
parenta3f5b66fac3b5f3b2c352c8086dbc3d476f9e3d4
ssh: 'simple' variant does not support --port

When trying to connect to an ssh:// URL with port explicitly specified
and the ssh command configured with GIT_SSH does not support such a
setting, it is less confusing to error out than to silently suppress
the port setting and continue.

This requires updating the GIT_SSH setting in t5603-clone-dirname.sh.
That test is about the directory name produced when cloning various
URLs.  It uses an ssh wrapper that ignores all its arguments but does
not declare that it supports a port argument; update it to set
GIT_SSH_VARIANT=ssh to do so.  (Real-life ssh wrappers that pass a
port argument to OpenSSH would also support -G and would not require
such an update.)

Reported-by: William Yan <wyan@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
connect.c
t/t5601-clone.sh
t/t5603-clone-dirname.sh