]> git.ipfire.org Git - thirdparty/git.git/commit - daemon.c
convert trivial sprintf / strcpy calls to xsnprintf
authorJeff King <peff@peff.net>
Thu, 24 Sep 2015 21:06:08 +0000 (17:06 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 25 Sep 2015 17:18:18 +0000 (10:18 -0700)
commit5096d4909f9b13c7a650d9dbb7c9702ea7413566
tree07229a8952f2d6782f3064d9dfd1e7855e8e5269
parentdb85a8a9c2fb492d3cd528dbbcc52075c607cf79
convert trivial sprintf / strcpy calls to xsnprintf

We sometimes sprintf into fixed-size buffers when we know
that the buffer is large enough to fit the input (either
because it's a constant, or because it's numeric input that
is bounded in size). Likewise with strcpy of constant
strings.

However, these sites make it hard to audit sprintf and
strcpy calls for buffer overflows, as a reader has to
cross-reference the size of the array with the input. Let's
use xsnprintf instead, which communicates to a reader that
we don't expect this to overflow (and catches the mistake in
case we do).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
20 files changed:
archive-tar.c
builtin/gc.c
builtin/init-db.c
builtin/ls-tree.c
builtin/merge-index.c
builtin/merge-recursive.c
builtin/read-tree.c
builtin/unpack-file.c
compat/mingw.c
compat/winansi.c
connect.c
convert.c
daemon.c
diff.c
http-push.c
http.c
ll-merge.c
refs.c
sideband.c
strbuf.c