]> git.ipfire.org Git - thirdparty/git.git/commit - date.c
date: use strbufs in date-formatting functions
authorJeff King <peff@peff.net>
Wed, 27 Aug 2014 07:57:08 +0000 (03:57 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 27 Aug 2014 17:32:56 +0000 (10:32 -0700)
commitc33ddc2e33d51da9391a81206a1d9e4a92d97d10
treeeb4a28190a98e436d07875d0785b21a27103f827
parentea5517f04b08bdb40eca72888220bd6a90d3cf17
date: use strbufs in date-formatting functions

Many of the date functions write into fixed-size buffers.
This is a minor pain, as we have to take special
precautions, and frequently end up copying the result into a
strbuf or heap-allocated buffer anyway (for which we
sometimes use strcpy!).

Let's instead teach parse_date, datestamp, etc to write to a
strbuf. The obvious downside is that we might need to
perform a heap allocation where we otherwise would not need
to. However, it turns out that the only two new allocations
required are:

  1. In test-date.c, where we don't care about efficiency.

  2. In determine_author_info, which is not performance
     critical (and where the use of a strbuf will help later
     refactoring).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/commit.c
cache.h
date.c
fast-import.c
ident.c
test-date.c