]> git.ipfire.org Git - thirdparty/git.git/commit - fetch-pack.c
fetch-pack: in protocol v2, reset in_vain upon ACK
authorJonathan Tan <jonathantanmy@google.com>
Tue, 28 Apr 2020 00:01:10 +0000 (17:01 -0700)
committerJunio C Hamano <gitster@pobox.com>
Tue, 28 Apr 2020 16:55:06 +0000 (09:55 -0700)
commit2f0a093dd640e0dad0b261dae2427f2541b5426c
treee774748e9d7d3e42f9a47759d9f1ecfdda80b613
parent4fa3f00abb55c3334cce71e201a5ff2c70f8561f
fetch-pack: in protocol v2, reset in_vain upon ACK

In the function process_acks() in fetch-pack.c, the variable
received_ack is meant to track that an ACK was received, but it was
never set. This results in negotiation terminating prematurely through
the in_vain counter, when the counter should have been reset upon every
ACK.

Therefore, reset the in_vain counter upon every ACK.

Helped-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
fetch-pack.c
t/t5500-fetch-pack.sh