]> git.ipfire.org Git - thirdparty/git.git/commit - git-bisect.sh
bisect--helper: `bisect_start` shell function partially in C
authorPranit Bauva <pranit.bauva@gmail.com>
Wed, 2 Jan 2019 15:38:36 +0000 (07:38 -0800)
committerJunio C Hamano <gitster@pobox.com>
Wed, 2 Jan 2019 18:23:03 +0000 (10:23 -0800)
commit06f5608c14e6972748b84649d5b8ffd335bbd209
tree1bacf3b41b803dfdbac4e6bf064b8bd841e2f133
parent450ebb7359ec379a282670e85536540734c45eed
bisect--helper: `bisect_start` shell function partially in C

Reimplement the `bisect_start` shell function partially in C and add
`bisect-start` subcommand to `git bisect--helper` to call it from
git-bisect.sh .

The last part is not converted because it calls another shell function.
`bisect_start` shell function will be completed after the `bisect_next`
shell function is ported in C.

Using `--bisect-start` subcommand is a temporary measure to port shell
function in C so as to use the existing test suite. As more functions
are ported, this subcommand will be retired and will be called by some
other methods.

Also introduce a method `bisect_append_log_quoted` to keep things short
and crisp.

Note that we are a bit lax about command-line parsing because the helper
is not supposed to be called by the user directly (but only from the git
bisect script).

Helped-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Helped-by: Stephan Beyer <s-beyer@gmx.net>
Mentored-by: Lars Schneider <larsxschneider@gmail.com>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/bisect--helper.c
git-bisect.sh