]> git.ipfire.org Git - thirdparty/git.git/commit - git-cvsimport.perl
perl: call timegm and timelocal with 4-digit year
authorBernhard M. Wiedemann <bwiedemann@suse.de>
Fri, 23 Feb 2018 17:20:45 +0000 (18:20 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 23 Feb 2018 22:47:06 +0000 (14:47 -0800)
commita40e06ee336d608cfe0928d91d2b44112d8fd1e2
tree4256cb0c84d3294290f188b37496c9583a9cdc7b
parentffa952497288d29d94b16675c6789ef83850def3
perl: call timegm and timelocal with 4-digit year

Amazingly, timegm(gmtime(0)) is only 0 before 2020 because perl's
timegm deviates from GNU timegm(3) in how it handles years.

man Time::Local says

 Whenever possible, use an absolute four digit year instead.

with a detailed explanation about ambiguity of 2-digit years above that.

Even though this ambiguity is error-prone with >50% of users getting it
wrong, it has been like this for 20+ years, so we just use 4-digit years
everywhere to be on the safe side.

We add some extra logic to cvsimport because it allows 2-digit year
input and interpreting an 18 as 1918 can be avoided easily and safely.

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/examples/git-svnimport.perl
git-cvsimport.perl
perl/Git.pm
perl/Git/SVN.pm