]> git.ipfire.org Git - thirdparty/git.git/commit - git-p4.py
git-p4: add P4CommandException to report errors talking to Perforce
authorLuke Diamand <luke@diamand.org>
Wed, 29 Jan 2020 11:12:42 +0000 (11:12 +0000)
committerJunio C Hamano <gitster@pobox.com>
Thu, 30 Jan 2020 20:20:57 +0000 (12:20 -0800)
commit5c3d5020e66caad0418b5696ba0f3d013641fcdd
treeac9899b658bc0c8693224f4ab49f1901a1050c98
parent837b3a6376804ec70b88f06c3f702a38c59196c3
git-p4: add P4CommandException to report errors talking to Perforce

Currently when there is a P4 error, git-p4 calls die() which just exits.

This then leaves the git-fast-import process still running, and can even
leave p4 itself still running.

As a result, git-p4 fails to exit cleanly. This is a particular problem
for people running the unit tests in regression.

Use this exception to report errors upwards, cleaning up as the error
propagates.

Signed-off-by: Luke Diamand <luke@diamand.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-p4.py