]> git.ipfire.org Git - thirdparty/git.git/commit - http-push.c
http-push: prevent format overflow warning with gcc >= 9
authorCarlo Marcelo Arenas Belón <carenas@gmail.com>
Tue, 14 May 2019 21:11:17 +0000 (14:11 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 15 May 2019 02:03:08 +0000 (11:03 +0900)
commit9dde06de130463c20f8b603ed3a3ffe10347f2f1
treece28534f3755ace4bb2975f1652d0bc6a62bcf50
parentaeb582a98374c094361cba1bd756dc6307432c42
http-push: prevent format overflow warning with gcc >= 9

In function 'finish_request',
    inlined from 'process_response' at http-push.c:248:2:
http-push.c:587:4: warning: '%s' directive argument is null [-Wformat-overflow=]
  587 |    fprintf(stderr, "Unable to get pack file %s\n%s",
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  588 |     request->url, curl_errorstr);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

request->url is needed for the error message if there was a failure
during fetch but was being cleared unnecessarily earlier.

note that the leak is prevented by calling release_request unconditionally
at the end.

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Suggested-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http-push.c