]> git.ipfire.org Git - thirdparty/git.git/commit - http.c
http: check CURLE_SSL_PINNEDPUBKEYNOTMATCH when emitting errors
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Fri, 24 Sep 2021 10:08:20 +0000 (12:08 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 27 Sep 2021 17:58:07 +0000 (10:58 -0700)
commit3e8084f1884ffea25b80f76b7a1bd0e5b3200c8a
tree5fd59e4a63a3c8a43d84d89c7cb884e1e10a506d
parentddb1055343948e0d0bc81f8d20245f1ada6430a0
http: check CURLE_SSL_PINNEDPUBKEYNOTMATCH when emitting errors

Change the error shown when a http.pinnedPubKey doesn't match to point
the http.pinnedPubKey variable added in aeff8a61216 (http: implement
public key pinning, 2016-02-15), e.g.:

    git -c http.pinnedPubKey=sha256/someNonMatchingKey ls-remote https://github.com/git/git.git
    fatal: unable to access 'https://github.com/git/git.git/' with http.pinnedPubkey configuration: SSL: public key does not match pinned public key!

Before this we'd emit the exact same thing without the " with
http.pinnedPubkey configuration". The advantage of doing this is that
we're going to get a translated message (everything after the ":" is
hardcoded in English in libcurl), and we've got a reference to the
git-specific configuration variable that's causing the error.

Unfortunately we can't test this easily, as there are no tests that
require https:// in the test suite, and t/lib-httpd.sh doesn't know
how to set up such tests. See [1] for the start of a discussion about
what it would take to have divergent "t/lib-httpd/apache.conf" test
setups. #leftoverbits

1. https://lore.kernel.org/git/YUonS1uoZlZEt+Yd@coredump.intra.peff.net/

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-curl-compat.h
http.c
http.h
remote-curl.c