]> git.ipfire.org Git - thirdparty/git.git/commit - http.c
http, imap-send: stop using CURLOPT_VERBOSE
authorJonathan Tan <jonathantanmy@google.com>
Mon, 11 May 2020 17:43:10 +0000 (10:43 -0700)
committerJunio C Hamano <gitster@pobox.com>
Mon, 11 May 2020 18:18:01 +0000 (11:18 -0700)
commit7167a62b9e2f648adc11411446f876f2458722a5
treeeb0b58dfdde6cd2ad37d1aff90f10ebb41c65f56
parent373e9bd66e2ba468f490e5e4ec1ccbe47853f8cd
http, imap-send: stop using CURLOPT_VERBOSE

Whenever GIT_CURL_VERBOSE is set, teach Git to behave as if
GIT_TRACE_CURL=1 and GIT_TRACE_CURL_NO_DATA=1 is set, instead of setting
CURLOPT_VERBOSE.

This is to prevent inadvertent revelation of sensitive data. In
particular, GIT_CURL_VERBOSE redacts neither the "Authorization" header
nor any cookies specified by GIT_REDACT_COOKIES.

Unifying the tracing mechanism also has the future benefit that any
improvements to the tracing mechanism will benefit both users of
GIT_CURL_VERBOSE and GIT_TRACE_CURL, and we do not need to remember to
implement any improvement twice.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/git.txt
http.c
http.h
imap-send.c
t/t5551-http-fetch-smart.sh
t/t5581-http-curl-verbose.sh
trace.c
trace.h