]> git.ipfire.org Git - thirdparty/git.git/commit - merge-recursive.c
merge-recursive: handle NULL in add_cacheinfo() correctly
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Sat, 26 Nov 2016 12:48:06 +0000 (13:48 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 28 Nov 2016 19:00:04 +0000 (11:00 -0800)
commit55e9f0e5c9a918c246b7eae1fe2a2e954f6426af
tree2cf4d7c8f11a4da2089ae41ebab4ff280f81e417
parent05f2dfb965476a59050b7c3446b1281bdcac7051
merge-recursive: handle NULL in add_cacheinfo() correctly

1335d76e45 ("merge: avoid "safer crlf" during recording of merge
results", 2016-07-08) tried to split make_cache_entry() call made
with CE_MATCH_REFRESH into a call to make_cache_entry() without one,
followed by a call to add_cache_entry(), refresh_cache() and another
add_cache_entry() as needed.  However the conversion was botched in
that it forgot that refresh_cache() can return NULL, which was
handled correctly in make_cache_entry() but in the updated code.

This fixes https://github.com/git-for-windows/git/issues/952

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
merge-recursive.c
t/t3501-revert-cherry-pick.sh