]> git.ipfire.org Git - thirdparty/git.git/commit - notes.c
Convert the users of for_each_string_list to for_each_string_list_item macro
authorAlex Riesen <raa.lkml@gmail.com>
Sat, 3 Jul 2010 12:41:54 +0000 (14:41 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 5 Jul 2010 18:44:35 +0000 (11:44 -0700)
commit8a57c6e9437eeebf849f0def03389078a510312e
tree9d772bcb995b18031145fda56d892911eb61bbd2
parent8d31635ce22a5ff35d6b023dca6438c09cf49dc9
Convert the users of for_each_string_list to for_each_string_list_item macro

The rule for selecting the candidates for conversion is: if the callback
function returns only 0 (the condition for for_each_string_list to exit
early), than it can be safely converted to the macro.

A notable exception are the callers in builtin/remote.c. If converted, the
readability in the file will suffer greately. Besides, the code is not very
performance critical (at the moment, at least): it does output formatting of
the list of remotes.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/fetch.c
builtin/ls-files.c
notes.c
resolve-undo.c