]> git.ipfire.org Git - thirdparty/git.git/commit - notes.c
notes.c: fix a segfault in notes_display_config()
authorNate Avers <nate@roosteregg.cc>
Mon, 23 Nov 2020 03:23:41 +0000 (22:23 -0500)
committerJunio C Hamano <gitster@pobox.com>
Mon, 23 Nov 2020 18:42:22 +0000 (10:42 -0800)
commitc3eb95a0d759d80d53ccb396627c400cd3db6e6d
treed5666fa66e8182f546750e524fc07eae13820685
parentb86a4be245d0ba077c97c6ab6b1cdbeb9dcc1342
notes.c: fix a segfault in notes_display_config()

If notes.displayRef is configured with no value[1], control should be
returned to the caller when notes.c:notes_display_config() checks if 'v'
is NULL. Otherwise, both git log --notes and git diff-tree --notes will
subsequently segfault when refs.h:has_glob_specials() calls strpbrk()
with a NULL first argument.

[1] Examples:
.git/config:
[notes]
displayRef
$ git -c notes.displayRef [...]

Signed-off-by: Nate Avers <nate@roosteregg.cc>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
notes.c