]> git.ipfire.org Git - thirdparty/git.git/commit - pack-bitmap.c
pack-bitmap.c: more aggressively free in free_bitmap_index()
authorTaylor Blau <me@ttaylorr.com>
Tue, 26 Oct 2021 21:01:26 +0000 (17:01 -0400)
committerJunio C Hamano <gitster@pobox.com>
Thu, 28 Oct 2021 22:32:14 +0000 (15:32 -0700)
commit655b8561d6b10f22f0e7350df9388110667001af
treefb687841f5a1471b248f54569307efcce0d18ff6
parent022815114a8a57188bc0e8fd622e10d5e22604dc
pack-bitmap.c: more aggressively free in free_bitmap_index()

The function free_bitmap_index() is somewhat lax in what it frees. There
are two notable examples:

  - While it does call kh_destroy_oid_map on the "bitmaps" map, which
    maps commit OIDs to their corresponding bitmaps, the bitmaps
    themselves are not freed. Note here that we recycle already-freed
    ewah_bitmaps into a pool, but these are handled correctly by
    ewah_pool_free().

  - We never bother to free the extended index's "positions" map, which
    we always allocate in load_bitmap().

Fix both of these.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
pack-bitmap.c