]> git.ipfire.org Git - thirdparty/git.git/commit - path.c
projects / thirdparty / git.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 6e9e91e) | patch
path.c: char is not (always) signed
authorTorsten Bögershausen <tboegi@web.de>
Thu, 25 Oct 2018 16:13:08 +0000 (18:13 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 26 Oct 2018 02:20:01 +0000 (11:20 +0900)
commit3063477445423fd5ec52efa073fb8d15c1641f4e
tree74f8bcf47c281305d24597044feed78c8f452046tree | snapshot
parent6e9e91e9cae74cd7feb9300563d40361b2b17dd2commit | diff
path.c: char is not (always) signed

If a "char" in C is signed or unsigned is not specified, because it is
out of tradition "implementation dependent".
Therefore constructs like "if (name[i] < 0)" are not portable,
use "if (name[i] & 0x80)" instead.

Detected by "gcc (Raspbian 6.3.0-18+rpi1+deb9u1) 6.3.0 20170516" when
setting
DEVELOPER = 1
DEVOPTS = extra-all

Signed-off-by: Torsten Bögershausen <tboegi@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
path.c diff | blob | blame | history
Unnamed repository; edit this file 'description' to name the repository.