]> git.ipfire.org Git - thirdparty/git.git/commit - progress.c
progress: treat "no terminal" as being in the foreground
authorJeff King <peff@peff.net>
Tue, 19 May 2015 05:24:57 +0000 (01:24 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 19 May 2015 16:35:14 +0000 (09:35 -0700)
commita4fb76ce1916939c7e6359f9416f2af4a760f6f1
tree9cff56e372052a64557d55b7a9a18986f2bf3280
parent9a9a41db83052b674b89c084e4ac8c1458f7b11e
progress: treat "no terminal" as being in the foreground

progress: treat "no terminal" as being in the foreground

Commit 85cb890 (progress: no progress in background,
2015-04-13) avoids sending progress from background
processes by checking that the process group id of the
current process is the same as that of the controlling
terminal.

If we don't have a terminal, however, this check never
succeeds, and we print no progress at all (until the final
"done" message). This can be seen when cloning a large
repository; instead of getting progress updates for
"counting objects", it will appear to hang then print the
final count.

We can fix this by treating an error return from tcgetpgrp()
as a signal to show the progress.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
progress.c