]> git.ipfire.org Git - thirdparty/git.git/commit - quote.c
trace: avoid unnecessary quoting
authorJeff King <peff@peff.net>
Mon, 15 Jan 2018 10:59:44 +0000 (17:59 +0700)
committerJunio C Hamano <gitster@pobox.com>
Tue, 16 Jan 2018 20:16:54 +0000 (12:16 -0800)
commit1fbdab21bb452ca4732bf088539247047465b99d
tree1b9f8229b5588ed959ebf0c7738856ebe3f3238f
parente35f11c29391e557964a39204fae6b89afab6a2a
trace: avoid unnecessary quoting

Trace output which contains arbitrary strings (e.g., the
arguments to commands which we are running) is always passed
through sq_quote_buf(). That function always adds
single-quotes, even if the output consists of vanilla
characters. This can make the output a bit hard to read.

Let's avoid the quoting if there are no characters which a
shell would interpret. Trace output doesn't necessarily need
to be shell-compatible, but:

  - the shell language is a good ballpark for what humans
    consider readable (well, humans versed in command line
    tools)

  - the run_command bits can be cut-and-pasted to a shell,
    and we'll keep that property

  - it covers any cases which would make the output
    visually ambiguous (e.g., embedded whitespace or quotes)

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
quote.c
quote.h
trace.c