]> git.ipfire.org Git - thirdparty/git.git/commit - quote.c
quote_path_relative(): remove redundant parameter
authorJiang Xin <worldhello.net@gmail.com>
Tue, 25 Jun 2013 15:53:45 +0000 (23:53 +0800)
committerJunio C Hamano <gitster@pobox.com>
Wed, 26 Jun 2013 18:16:48 +0000 (11:16 -0700)
commit39598f9983f759b5e38b9e762c695bad6c89a1b3
tree77a8bc04e6224853d4c30021a249909732c5b2d0
parentad66df2df14991e7436474d266cc6db823e6ae78
quote_path_relative(): remove redundant parameter

quote_path_relative() used to take a counted string as its parameter
(the string to be quoted).  With an earlier change, it now uses
relative_path() that does not take a counted string, and we have
been passing only the pointer to the string since then.

Remove the length parameter from quote_path_relative() to show that
this parameter was redundant.  All the changed lines show that the
caller passed either -1 (to ask the function run strlen() on the
string), or the length of the string, so the earlier conversion was
safe.

All the callers of quote_path_relative() that used to take counted string
have been audited to make sure that they are passing length of the actual
string (or -1 to ask the callee run strlen())

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/clean.c
builtin/grep.c
builtin/ls-files.c
quote.c
quote.h
wt-status.c