]> git.ipfire.org Git - thirdparty/git.git/commit - read-cache.c
cache API: add a "INDEX_STATE_INIT" macro/function, add release_index()
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Thu, 12 Jan 2023 12:55:27 +0000 (13:55 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 16 Jan 2023 18:46:58 +0000 (10:46 -0800)
commit2f6b1eb794ee1f152c1a4b519e3b6dcecd0b487f
treece148cd756ca33dd7147a7136eb33c30530da8eb
parent5bdf6d4ac0d06817ce22322aa0172b49e6026544
cache API: add a "INDEX_STATE_INIT" macro/function, add release_index()

Hopefully in some not so distant future, we'll get advantages from always
initializing the "repo" member of the "struct index_state". To make
that easier let's introduce an initialization macro & function.

The various ad-hoc initialization of the structure can then be changed
over to it, and we can remove the various "0" assignments in
discard_index() in favor of calling index_state_init() at the end.

While not strictly necessary, let's also change the CALLOC_ARRAY() of
various "struct index_state *" to use an ALLOC_ARRAY() followed by
index_state_init() instead.

We're then adding the release_index() function and converting some
callers (including some of these allocations) over to it if they
either won't need to use their "struct index_state" again, or are just
about to call index_state_init().

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Acked-by: Derrick Stolee <derrickstolee@github.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 files changed:
apply.c
builtin/difftool.c
builtin/sparse-checkout.c
builtin/stash.c
builtin/worktree.c
cache.h
merge-recursive.c
read-cache.c
repository.c
revision.c
split-index.c
unpack-trees.c