]> git.ipfire.org Git - thirdparty/git.git/commit - ref-filter.c
hashmap: provide deallocation function names
authorElijah Newren <newren@gmail.com>
Mon, 2 Nov 2020 18:55:05 +0000 (18:55 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 2 Nov 2020 20:15:50 +0000 (12:15 -0800)
commit6da1a258142ac2422c8c57c54b92eaed3c86226e
tree480a35cb1c8754d02f21233d2efd8e5d28ff24d0
parent33f20d82177871225e17d9dd44169a52a36c9f1d
hashmap: provide deallocation function names

hashmap_free(), hashmap_free_entries(), and hashmap_free_() have existed
for a while, but aren't necessarily the clearest names, especially with
hashmap_partial_clear() being added to the mix and lazy-initialization
now being supported.  Peff suggested we adopt the following names[1]:

  - hashmap_clear() - remove all entries and de-allocate any
    hashmap-specific data, but be ready for reuse

  - hashmap_clear_and_free() - ditto, but free the entries themselves

  - hashmap_partial_clear() - remove all entries but don't deallocate
    table

  - hashmap_partial_clear_and_free() - ditto, but free the entries

This patch provides the new names and converts all existing callers over
to the new naming scheme.

[1] https://lore.kernel.org/git/20201030125059.GA3277724@coredump.intra.peff.net/

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
22 files changed:
add-interactive.c
blame.c
bloom.c
builtin/fetch.c
builtin/shortlog.c
config.c
diff.c
diffcore-rename.c
dir.c
hashmap.c
hashmap.h
merge-recursive.c
name-hash.c
object.c
oidmap.c
patch-ids.c
range-diff.c
ref-filter.c
revision.c
sequencer.c
submodule-config.c
t/helper/test-hashmap.c