]> git.ipfire.org Git - thirdparty/git.git/commit - reflog-walk.h
rev-list: check reflog_info before showing usage
authorJeff King <peff@peff.net>
Fri, 7 Jul 2017 09:08:30 +0000 (05:08 -0400)
committerJunio C Hamano <gitster@pobox.com>
Sun, 9 Jul 2017 17:00:48 +0000 (10:00 -0700)
commit7f97de5ee1e1f9d28f45c8f7890e752f7b12bed1
treeeaeecf98f49cf177a3df093f70ea287da6521b31
parent7c2f08aa7a26e68475abe5c9fd7250aacbb6b7b2
rev-list: check reflog_info before showing usage

When git-rev-list sees no pending commits, it shows a usage
message. This works even when reflog-walking is requested,
because the reflog-walk code currently puts the reflog tips
into the pending queue.

In preparation for refactoring the reflog-walk code, let's
explicitly check whether we have any reflogs to walk. For
now this is a noop, but the existing reflog tests will make
sure that it kicks in after the refactoring. Likewise, we'll
add a test that "rev-list -g" without specifying any reflogs
continues to fail (so that we know our check does not kick
in too aggressively).

Note that the implementation needs to go into its own
sub-function, as the walk code does not expose its innards
outside of reflog-walk.c.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/rev-list.c
reflog-walk.c
reflog-walk.h
t/t1414-reflog-walk.sh