]> git.ipfire.org Git - thirdparty/git.git/commit - refs.c
refs: prevent accidental NULL dereference in write_pseudoref
authorbrian m. carlson <sandals@crustytoothpaste.net>
Sun, 15 Oct 2017 22:06:52 +0000 (22:06 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 16 Oct 2017 02:05:50 +0000 (11:05 +0900)
commit6ee18216d8d9ca8f76b01282b36bdf590a64d8fc
treeb29f5705e7051ef1e4e6841765517894b5184bf0
parentae077771b09fac4d663e3f8c039318a97eb3a15b
refs: prevent accidental NULL dereference in write_pseudoref

Several of the refs functions take NULL to indicate that the ref is not
to be updated.  If refs_update_ref were called with a NULL new object
ID, we could pass that NULL pointer to write_pseudoref, which would then
segfault when it dereferenced it.  Instead, simply return successfully,
since if we don't want to update the pseudoref, there's nothing to do.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
refs.c