]> git.ipfire.org Git - thirdparty/git.git/commit - refs.c
refs.c: add a strbuf argument to ref_transaction_commit for error logging
authorRonnie Sahlberg <sahlberg@google.com>
Fri, 20 Jun 2014 14:42:46 +0000 (07:42 -0700)
committerJunio C Hamano <gitster@pobox.com>
Mon, 14 Jul 2014 18:54:40 +0000 (11:54 -0700)
commit995f8746bc421a537e12622770a90be2205cd26f
treef10fab2b8568908fc8a941f3e488bbf7fa74519f
parent1b07255c95cdf2f7dbe7989a734248f60799f506
refs.c: add a strbuf argument to ref_transaction_commit for error logging

Add a strbuf argument to _commit so that we can pass an error string back to
the caller. So that we can do error logging from the caller instead of from
_commit.

Longer term plan is to first convert all callers to use onerr==QUIET_ON_ERR
and craft any log messages from the callers themselves and finally remove the
onerr argument completely.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Acked-by: Michael Haggerty <mhagger@alum.mit.edu>
builtin/update-ref.c
refs.c
refs.h