]> git.ipfire.org Git - thirdparty/git.git/commit - repository.h
tmp-objdir: disable ref updates when replacing the primary odb
authorNeeraj Singh <neerajsi@microsoft.com>
Mon, 6 Dec 2021 22:05:05 +0000 (22:05 +0000)
committerJunio C Hamano <gitster@pobox.com>
Wed, 8 Dec 2021 22:06:46 +0000 (14:06 -0800)
commitecd81dfc79cf12cc21fc0340da8ca8fcc5aa58a7
treec9e99733796f9a1004ddf6997075423716a4b202
parentb3cecf49eac00d62e361bf6e6e81392f5a2fb571
tmp-objdir: disable ref updates when replacing the primary odb

When creating a subprocess with a temporary ODB, we set the
GIT_QUARANTINE_ENVIRONMENT env var to tell child Git processes not
to update refs, since the tmp-objdir may go away.

Introduce a similar mechanism for in-process temporary ODBs when
we call tmp_objdir_replace_primary_odb. Now both mechanisms set
the disable_ref_updates flag on the odb, which is queried by
the ref_transaction_prepare function.

Peff's test case [1] was invoking ref updates via the cachetextconv
setting. That particular code silently does nothing when a ref
update is forbidden. See the call to notes_cache_put in
fill_textconv where errors are ignored.

[1] https://lore.kernel.org/git/YVOn3hDsb5pnxR53@coredump.intra.peff.net/

Reported-by: Jeff King <peff@peff.net>
Signed-off-by: Neeraj Singh <neerajsi@microsoft.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
environment.c
object-file.c
object-store.h
refs.c
repository.c
repository.h