]> git.ipfire.org Git - thirdparty/git.git/commit - revision.c
revision: forbid combining --graph and --no-walk
authorDongcan Jiang <dongcan.jiang@gmail.com>
Wed, 11 Mar 2015 02:13:02 +0000 (10:13 +0800)
committerJunio C Hamano <gitster@pobox.com>
Thu, 19 Mar 2015 18:07:51 +0000 (11:07 -0700)
commit695985f4837e7299dca10b5e45206dbd2c52c1e0
tree4dc6b51d89a4874c73a66f10b037f51218fee7bc
parent9874fca7122563e28d699a911404fc49d2a24f1c
revision: forbid combining --graph and --no-walk

Because "--graph" is about connected history while --no-walk is
about discrete points, it does not make sense to allow these two
options at the same time. [1]

This change makes a few calls to "show --graph" fail in t4052, but
asking to show one commit with graph is a nonsensical thing to do.
Thus, tests on "show --graph" in t4052 have been removed [2,3].
Same tests on "show" without --graph option have already been tested
in 4052.

3 testcases have been added to test this patch.

[1]: http://article.gmane.org/gmane.comp.version-control.git/216083
[2]: http://article.gmane.org/gmane.comp.version-control.git/264950
[3]: http://article.gmane.org/gmane.comp.version-control.git/265107

Helped-By: Eric Sunshine <sunshine@sunshineco.com>
Helped-By: René Scharfe <l.s.r@web.de>
Helped-By: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Dongcan Jiang <dongcan.jiang@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/rev-list-options.txt
revision.c
t/t4052-stat-output.sh
t/t4202-log.sh
t/t6014-rev-list-all.sh
t/t7007-show.sh