]> git.ipfire.org Git - thirdparty/git.git/commit - revision.c
graph API: fix bug in graph_is_interesting()
authorAdam Simpkins <simpkins@facebook.com>
Wed, 19 Aug 2009 02:34:33 +0000 (19:34 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 21 Aug 2009 19:41:25 +0000 (12:41 -0700)
commitbeb5af43a6114b551f14bc13f1beecfe8de930d9
tree4b86d035b89aec399e129669a5e162b478adf322
parent83e355a62cd05fba4533d59f9ab4e104c0596279
graph API: fix bug in graph_is_interesting()

Previously, graph_is_interesting() did not behave quite the same way as
the code in get_revision().  As a result, it would sometimes think
commits were uninteresting, even though get_revision() would return
them.  This resulted in incorrect lines in the graph output.

This change creates a get_commit_action() function, which
graph_is_interesting() and simplify_commit() both now use to determine
if a commit will be shown.  It is identical to the old simplify_commit()
behavior, except that it never calls rewrite_parents().

This problem was reported by Santi BĂ©jar.  The following command
would exhibit the problem before, but now works correctly:

  git log --graph --simplify-by-decoration --oneline v1.6.3.3

Previously git graph did not display the output for this command
correctly between f29ac4f and 66996ec, among other places.

Signed-off-by: Adam Simpkins <simpkins@facebook.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
graph.c
revision.c
revision.h
t/t6015-rev-list-show-all-parents.sh [new file with mode: 0755]