]> git.ipfire.org Git - thirdparty/git.git/commit - revision.c
revisions API: have release_revisions() release "filter"
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Wed, 13 Apr 2022 20:01:48 +0000 (22:01 +0200)
committerJunio C Hamano <gitster@pobox.com>
Thu, 14 Apr 2022 06:56:09 +0000 (23:56 -0700)
commite75d2f7f73420884c50613a8242812b55ad2a8fa
treefe61a8999ccca411e2f50f03750383dace090948
parent7a98d9ab00dc0a238b624b20c3884b50fe504e2b
revisions API: have release_revisions() release "filter"

Extend the the release_revisions() function so that it frees the
"filter" in the "struct rev_info". This in combination with a
preceding change to free "cmdline" means that we can mark another set
of tests as passing under "TEST_PASSES_SANITIZE_LEAK=true".

The "filter" member was added recently in ffaa137f646 (revision: put
object filter into struct rev_info, 2022-03-09), and this fixes leaks
intruded in the subsequent leak 7940941de1f (pack-objects: use
rev.filter when possible, 2022-03-09) and 105c6f14ad3 (bundle: parse
filter capability, 2022-03-09).

The "builtin/pack-objects.c" leak in 7940941de1f was effectively with
us already, but the variable was referred to by a "static" file-scoped
variable. The "bundle.c " leak in 105c6f14ad3 was newly introduced
with the new "filter" feature for bundles.

The "t5600-clone-fail-cleanup.sh" change here to add
"TEST_PASSES_SANITIZE_LEAK=true" is one of the cases where
run-command.c in not carrying the abort() exit code upwards would have
had that test passing before, but now it *actually* passes[1]. We
should fix the lack of 1=1 mapping of SANITIZE=leak testing to actual
leaks some other time, but it's an existing edge case, let's just mark
the really-passing test as passing for now.

1. https://lore.kernel.org/git/220303.86fsnz5o9w.gmgdl@evledraar.gmail.com/

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
18 files changed:
revision.c
t/t1060-object-corruption.sh
t/t2015-checkout-unborn.sh
t/t4207-log-decoration-colors.sh
t/t5301-sliding-window.sh
t/t5313-pack-bounds-checks.sh
t/t5316-pack-delta-depth.sh
t/t5320-delta-islands.sh
t/t5322-pack-objects-sparse.sh
t/t5506-remote-groups.sh
t/t5513-fetch-track.sh
t/t5532-fetch-proxy.sh
t/t5600-clone-fail-cleanup.sh
t/t5900-repo-selection.sh
t/t6101-rev-parse-parents.sh
t/t6114-keep-packs.sh
t/t7702-repack-cyclic-alternate.sh
t/t9127-git-svn-partial-rebuild.sh