]> git.ipfire.org Git - thirdparty/git.git/commit - run-command.c
run-command: add hint when a hook is ignored
authorDamien Marié <damien@dam.io>
Fri, 6 Oct 2017 08:07:55 +0000 (08:07 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 10 Oct 2017 04:21:46 +0000 (13:21 +0900)
commitf805a00a396ee91599902cebe55620b2a4c813b9
treeff5e8a8d4b5dabf8a80a7442fe8672d6e61822c3
parent217f2767cbcb562872437eed4dec62e00846d90c
run-command: add hint when a hook is ignored

When an hook is present but the file is not set as executable then git will
ignore the hook.
For now this is silent which can be confusing.

This commit adds this warning to improve the situation:

  hint: The 'pre-commit' hook was ignored because it's not set as executable.
  hint: You can disable this warning with `git config advice.ignoredHook false`

To allow the old use-case of enabling/disabling hooks via the executable flag a
new setting is introduced: advice.ignoredHook.

Signed-off-by: Damien Marié <damien@dam.io>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/config.txt
advice.c
advice.h
contrib/completion/git-completion.bash
run-command.c
t/t7520-ignored-hook-warning.sh [new file with mode: 0755]