]> git.ipfire.org Git - thirdparty/git.git/commit - sequencer.c
git-commit: populate the edit buffer with 2 blank lines before s-o-b
authorBrandon Casey <drafnel@gmail.com>
Fri, 22 Feb 2013 22:05:27 +0000 (14:05 -0800)
committerJunio C Hamano <gitster@pobox.com>
Sat, 23 Feb 2013 08:03:00 +0000 (00:03 -0800)
commit8c613fd5efa1c3bbd48845ed91c533192e699c08
treef8e42a81f5469406ad5f04324ef8e1ce7e2f6d00
parent959a26231f53b9cc7da40d36c550aef193647731
git-commit: populate the edit buffer with 2 blank lines before s-o-b

'commit -s' populates the edit buffer with a blank line before the
Signed-off-by line, to allow the user to immediately start typing
the log message.  But commit 33f2f9ab removed this space, forcing
the user to first push the Signed-off-by line down to open a place
to type the log message.

Fix this regression and let's ensure that the Signed-off-by line is
preceded by two blank lines, instead of just one, to hint that
something should be filled in, and that a blank line should separate
it from the body and the Signed-off-by line.

Add a test for this behavior.

Reported-by: John Keeping <john@keeping.me.uk>
Signed-off-by: Brandon Casey <drafnel@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
sequencer.c
t/t7502-commit.sh