]> git.ipfire.org Git - thirdparty/git.git/commit - sequencer.c
sequencer: do not die() in do_pick_commit()
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Fri, 26 Aug 2016 13:47:14 +0000 (15:47 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 29 Aug 2016 20:15:14 +0000 (13:15 -0700)
commitdbfad033d443f27c5579bbb67bd14243b0cbaba6
treec7e7011f52be924b674bc782e7a7cd560704a3c9
parentb9b946d4a4e9e30bc0dba9ce3ff81ab3d3666632
sequencer: do not die() in do_pick_commit()

Instead of dying there, let the caller high up in the callchain
notice the error and handle it (by dying, still).

The eventual caller of do_pick_commit() is sequencer_pick_revisions(),
which already relays a reported error from its helper functions
(including this one), and both of its two callers know how to react to
a negative return correctly.

So this makes do_pick_commit() callable from new callers that want it
not to die, without changing the external behaviour of anything
existing.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
sequencer.c